From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [PATCH v3 3/8] hash: fix to have more accurate key slot size Date: Mon, 9 Jul 2018 14:20:09 +0000 Message-ID: References: <1528455078-328182-1-git-send-email-yipeng1.wang@intel.com> <1530906406-289697-1-git-send-email-yipeng1.wang@intel.com> <1530906406-289697-4-git-send-email-yipeng1.wang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "Richardson, Bruce" , "honnappa.nagarahalli@arm.com" , "vguvva@caviumnetworks.com" , "brijesh.s.singh@gmail.com" To: "Wang, Yipeng1" Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 9D7101B432 for ; Mon, 9 Jul 2018 16:20:14 +0200 (CEST) In-Reply-To: <1530906406-289697-4-git-send-email-yipeng1.wang@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Wang, Yipeng1 > Sent: Friday, July 6, 2018 8:47 PM > To: De Lara Guarch, Pablo > Cc: dev@dpdk.org; Wang, Yipeng1 ; Richardson, > Bruce ; honnappa.nagarahalli@arm.com; > vguvva@caviumnetworks.com; brijesh.s.singh@gmail.com > Subject: [PATCH v3 3/8] hash: fix to have more accurate key slot size Titles always start with a verb whereas in your case, you are starting with= a noun. Better to change it to "fix key slot size accuracy"? Apart from that: Acked-by: Pablo de Lara >=20 > This commit calculates the needed key slot size more accurately. The prev= ious > local cache fix requires the free slot ring to be larger than actually ne= eded. > The calculation of the value is inaccurate. >=20 > Fixes: 5915699153d7 ("hash: fix scaling by reducing contention") > Cc: stable@dpdk.org