From mboxrd@z Thu Jan  1 00:00:00 1970
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH v4 1/3] crypto/openssl: add rsa and mod asym
	op
Date: Mon, 23 Jul 2018 12:32:59 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8FF70E@IRSMSX107.ger.corp.intel.com>
References: <1531404526-17984-1-git-send-email-shally.verma@caviumnetworks.com>
 <1531404526-17984-2-git-send-email-shally.verma@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "pathreya@caviumnetworks.com"
 <pathreya@caviumnetworks.com>, "nmurthy@caviumnetworks.com"
 <nmurthy@caviumnetworks.com>, Sunila Sahu <sunila.sahu@caviumnetworks.com>,
 Ashish Gupta <ashish.gupta@caviumnetworks.com>
To: Shally Verma <shally.verma@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id AE5F8235
 for <dev@dpdk.org>; Mon, 23 Jul 2018 14:33:05 +0200 (CEST)
In-Reply-To: <1531404526-17984-2-git-send-email-shally.verma@caviumnetworks.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Shally,

> -----Original Message-----
> From: Shally Verma [mailto:shally.verma@caviumnetworks.com]
> Sent: Thursday, July 12, 2018 3:09 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; pathreya@caviumnetworks.com;
> nmurthy@caviumnetworks.com; Sunila Sahu
> <sunila.sahu@caviumnetworks.com>; Ashish Gupta
> <ashish.gupta@caviumnetworks.com>
> Subject: [PATCH v4 1/3] crypto/openssl: add rsa and mod asym op
>=20
> From: Sunila Sahu <sunila.sahu@caviumnetworks.com>
>=20
> - Add compat.h to make pmd compatible to openssl-1.1.0 and
>   backward version
> - Add rsa sign/verify/encrypt/decrypt and modular operation
>   support
>=20
> Signed-off-by: Sunila Sahu <sunila.sahu@caviumnetworks.com>
> Signed-off-by: Shally Verma <shally.verma@caviumnetworks.com>
> Signed-off-by: Ashish Gupta <ashish.gupta@caviumnetworks.com>

...

> --- a/drivers/crypto/openssl/rte_openssl_pmd.c
> +++ b/drivers/crypto/openssl/rte_openssl_pmd.c

...

> +	case RTE_CRYPTO_ASYM_OP_VERIFY:
> +		ret =3D RSA_public_decrypt(op->rsa.sign.length,
> +				op->rsa.sign.data,
> +				op->rsa.sign.data,
> +				rsa,
> +				pad);
> +
> +		OPENSSL_LOG(DEBUG,
> +				"Length of public_decrypt %d "
> +				"length of message %zd\n",
> +				ret, op->rsa.message.length);
> +
> +		if (memcmp(op->rsa.sign.data, op->rsa.message.data,
> +					op->rsa.message.length)) {
> +			OPENSSL_LOG(ERR,
> +					"RSA sign Verification failed");
> +			return -1;
> +		}

There is a compilation issue here (missing "break"?):

drivers/crypto/openssl/rte_openssl_pmd.c:1905:6: error:
this statement may fall through [-Werror=3Dimplicit-fallthrough=3D]
   if (memcmp(op->rsa.sign.data, op->rsa.message.data,
      ^


> +	default:
> +		/* allow ops with invalid args to be pushed to
> +		 * completion queue
> +		 */
> +		cop->status =3D RTE_CRYPTO_OP_STATUS_INVALID_ARGS;
> +		break;
> +	}