From mboxrd@z Thu Jan  1 00:00:00 1970
From: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [PATCH v3 4/5] compress/zlib: support burst
	enqueue/dequeue
Date: Mon, 23 Jul 2018 12:36:35 +0000
Message-ID: <E115CCD9D858EF4F90C690B0DCB4D8977F8FF734@IRSMSX107.ger.corp.intel.com>
References: <1532197069-24224-1-git-send-email-shally.verma@caviumnetworks.com>
 <1532197069-24224-5-git-send-email-shally.verma@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "pathreya@caviumnetworks.com"
 <pathreya@caviumnetworks.com>, "mchalla@caviumnetworks.com"
 <mchalla@caviumnetworks.com>, "ashish.gupta@caviumnetworks.com"
 <ashish.gupta@caviumnetworks.com>, "sunila.sahu@caviumnetworks.com"
 <sunila.sahu@caviumnetworks.com>, Sunila Sahu <ssahu@caviumnetworks.com>
To: Shally Verma <shally.verma@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 1C0CDF72
 for <dev@dpdk.org>; Mon, 23 Jul 2018 14:36:39 +0200 (CEST)
In-Reply-To: <1532197069-24224-5-git-send-email-shally.verma@caviumnetworks.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Shally Verma [mailto:shally.verma@caviumnetworks.com]
> Sent: Saturday, July 21, 2018 7:18 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; pathreya@caviumnetworks.com;
> mchalla@caviumnetworks.com; ashish.gupta@caviumnetworks.com;
> sunila.sahu@caviumnetworks.com; Sunila Sahu <ssahu@caviumnetworks.com>
> Subject: [PATCH v3 4/5] compress/zlib: support burst enqueue/dequeue
>=20
> From: Sunila Sahu <ssahu@caviumnetworks.com>
>=20
> Signed-off-by: Sunila Sahu <sunila.sahu@caviumnetworks.com>
> Signed-off-by: Shally Verma <shally.verma@caviumnetworks.com>
> Signed-off-by: Ashish Gupta <ashish.gupta@caviumnetworks.com>
> ---
>  drivers/compress/zlib/zlib_pmd.c | 254

...

> +def_end:
> +	/* Update op stats */
> +	switch (op->status) {
> +	case RTE_COMP_OP_STATUS_SUCCESS:
> +		op->consumed +=3D strm->total_in;

Compilation issue here:

drivers/compress/zlib/zlib_pmd.c:94:16: error: this statement may fall thro=
ugh [-Werror=3Dimplicit-fallthrough=3D]
   op->consumed +=3D strm->total_in;
   ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~

I think you are missing a "/* Fall-through */" comment here.

Thanks,
Pablo

> +	case RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED:
> +		op->produced +=3D strm->total_out;
> +		break;