From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Yang, Zhiyong" <zhiyong.yang@intel.com>
Subject: Re: [PATCH v2] net/vhost: add pmd xstats
Date: Fri, 9 Sep 2016 08:54:50 +0000
Message-ID: <E182254E98A5DA4EB1E657AC7CB9BD2A3EB0149D@BGSMSX101.gar.corp.intel.com>
References: <1471608966-39077-1-git-send-email-zhiyong.yang@intel.com>
 <1473408927-40364-1-git-send-email-zhiyong.yang@intel.com>
 <E923DB57A917B54B9182A2E928D00FA6129631D3@IRSMSX102.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "yuanhan.liu@linux.intel.com" <yuanhan.liu@linux.intel.com>,
 "thomas.monjalon@6wind.com" <thomas.monjalon@6wind.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>, "dev@dpdk.org"
 <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 527685A72
 for <dev@dpdk.org>; Fri,  9 Sep 2016 10:55:29 +0200 (CEST)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA6129631D3@IRSMSX102.ger.corp.intel.com>
Content-Language: en-US
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi, Harry:

Your idea looks very good.

Thanks
--Zhiyong
> -----Original Message-----
> From: Van Haaren, Harry
> Sent: Friday, September 9, 2016 4:41 PM
> To: Yang, Zhiyong <zhiyong.yang@intel.com>; dev@dpdk.org
> Cc: yuanhan.liu@linux.intel.com; thomas.monjalon@6wind.com;
> "mailto:pmatilai"@redhat.com; Yang, Zhiyong <zhiyong.yang@intel.com>
> Subject: RE: [dpdk-dev] [PATCH v2] net/vhost: add pmd xstats
>=20
> Hi Zhiyong,
>=20
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Zhiyong Yang
> > To: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2] net/vhost: add pmd xstats
> >
> > +struct vhost_xstats {
> > +	uint64_t stat[16];
> > +};
>=20
> Perhaps we could create an enum to access the stat array?
>=20
> enum VHOST_STAT {
>    ...
>    VHOST_STAT_64_PKT,
>    ...
> };
>=20
> > +	{"broadcast_packets",
> > +			offsetof(struct vhost_queue, xstats.stat[8])},
>=20
> I think the "magic number" 8 here could be from the enum, and would be
> more clear which statistic is being accessed.
>=20
> > +		if (pkt_len =3D=3D 64) {
> > +			xstats_update->stat[1]++;
>=20
> Similarly, incrementing the counters would be more representative if it
> looked like
>=20
> xstats_update->stat[VHOST_STAT_64_PKT]++;   /* or similar */
>=20
> -Harry