From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D78C433EF for ; Thu, 2 Jun 2022 16:14:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236901AbiFBQOK convert rfc822-to-8bit (ORCPT ); Thu, 2 Jun 2022 12:14:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236699AbiFBQOJ (ORCPT ); Thu, 2 Jun 2022 12:14:09 -0400 Received: from mail.holtmann.org (coyote.holtmann.net [212.227.132.17]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D47A310D9; Thu, 2 Jun 2022 09:14:08 -0700 (PDT) Received: from smtpclient.apple (p4ff9fc30.dip0.t-ipconnect.de [79.249.252.48]) by mail.holtmann.org (Postfix) with ESMTPSA id ADDF5CED1A; Thu, 2 Jun 2022 18:14:07 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [PATCH v2 2/3] Bluetooth: btrtl: add support for the RTL8723CS From: Marcel Holtmann In-Reply-To: <20220524212155.16944-3-bage@debian.org> Date: Thu, 2 Jun 2022 18:14:07 +0200 Cc: Rob Herring , Maxime Ripard , Chen-Yu Tsai , Johan Hedberg , "David S. Miller" , Jakub Kicinski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Vasily Khoruzhick Content-Transfer-Encoding: 8BIT Message-Id: References: <20220524212155.16944-1-bage@debian.org> <20220524212155.16944-3-bage@debian.org> To: Bastian Germann X-Mailer: Apple Mail (2.3696.100.31) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bastien, > The Realtek RTL8723CS is SDIO WiFi chip. It also contains a Bluetooth > module which is connected via UART to the host. > > It shares lmp subversion with 8703B, so Realtek's userspace > initialization tool (rtk_hciattach) differentiates varieties of RTL8723CS > (CG, VF, XX) with RTL8703B using vendor's command to read chip type. > > Also this chip declares support for some features it doesn't support > so add a quirk to indicate that these features are broken. > > Signed-off-by: Vasily Khoruzhick > [move former btrtl_apply_quirks to btrtl_set_quirks] > [rebase on current tree] I don’t know what these mean. Can you just remove them. > Signed-off-by: Bastian Germann > --- > drivers/bluetooth/btrtl.c | 120 +++++++++++++++++++++++++++++++++++-- > drivers/bluetooth/btrtl.h | 5 ++ > drivers/bluetooth/hci_h5.c | 4 ++ > 3 files changed, 125 insertions(+), 4 deletions(-) Regards Marcel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCD39C43334 for ; Thu, 2 Jun 2022 16:15:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:References:Message-Id:Cc:Date: In-Reply-To:From:Subject:Mime-Version:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Nwf70Ip9DY9z8QexWndnowH2NcxCKmzTYN2tL800qn0=; b=BkgTETt9gN5Tza qC+WpaQL0XP/HniXqLPmy2nRRrE+/K0vzd4muTpj/ls+1v7iLaf4/cURM7Je0XaYa1FQGRx6lyaq6 OtqeqnKnjdh92YZJrPtmxiD06q/efWikBbEn2QqjY7ENfS99QM/U8EcL8IqnRoyJRJFtTIRbGeYmJ Wqs0P83mezEVXOFzQAGVs7WLPgfuS9XIhgZiC16Bdu2SlQ/AiBgEjItYLNQX35xj1dvfS1s20KPvX Wy8q41BxVdeNPfvfxtHhsxsz+93HC4/bfpS8CYLjWrJO6pkxjL+QpfZT5CKLh//PmKFcgmS8dJNhc gJJngzWQOy2GqC+RENUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwnSd-003kAk-UK; Thu, 02 Jun 2022 16:14:12 +0000 Received: from coyote.holtmann.net ([212.227.132.17] helo=mail.holtmann.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwnSa-003k9S-Nv for linux-arm-kernel@lists.infradead.org; Thu, 02 Jun 2022 16:14:10 +0000 Received: from smtpclient.apple (p4ff9fc30.dip0.t-ipconnect.de [79.249.252.48]) by mail.holtmann.org (Postfix) with ESMTPSA id ADDF5CED1A; Thu, 2 Jun 2022 18:14:07 +0200 (CEST) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [PATCH v2 2/3] Bluetooth: btrtl: add support for the RTL8723CS From: Marcel Holtmann In-Reply-To: <20220524212155.16944-3-bage@debian.org> Date: Thu, 2 Jun 2022 18:14:07 +0200 Cc: Rob Herring , Maxime Ripard , Chen-Yu Tsai , Johan Hedberg , "David S. Miller" , Jakub Kicinski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, Vasily Khoruzhick Message-Id: References: <20220524212155.16944-1-bage@debian.org> <20220524212155.16944-3-bage@debian.org> To: Bastian Germann X-Mailer: Apple Mail (2.3696.100.31) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220602_091408_957085_75269AF0 X-CRM114-Status: GOOD ( 15.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgQmFzdGllbiwKCj4gVGhlIFJlYWx0ZWsgUlRMODcyM0NTIGlzIFNESU8gV2lGaSBjaGlwLiBJ dCBhbHNvIGNvbnRhaW5zIGEgQmx1ZXRvb3RoCj4gbW9kdWxlIHdoaWNoIGlzIGNvbm5lY3RlZCB2 aWEgVUFSVCB0byB0aGUgaG9zdC4KPiAKPiBJdCBzaGFyZXMgbG1wIHN1YnZlcnNpb24gd2l0aCA4 NzAzQiwgc28gUmVhbHRlaydzIHVzZXJzcGFjZQo+IGluaXRpYWxpemF0aW9uIHRvb2wgKHJ0a19o Y2lhdHRhY2gpIGRpZmZlcmVudGlhdGVzIHZhcmlldGllcyBvZiBSVEw4NzIzQ1MKPiAoQ0csIFZG LCBYWCkgd2l0aCBSVEw4NzAzQiB1c2luZyB2ZW5kb3IncyBjb21tYW5kIHRvIHJlYWQgY2hpcCB0 eXBlLgo+IAo+IEFsc28gdGhpcyBjaGlwIGRlY2xhcmVzIHN1cHBvcnQgZm9yIHNvbWUgZmVhdHVy ZXMgaXQgZG9lc24ndCBzdXBwb3J0Cj4gc28gYWRkIGEgcXVpcmsgdG8gaW5kaWNhdGUgdGhhdCB0 aGVzZSBmZWF0dXJlcyBhcmUgYnJva2VuLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFZhc2lseSBLaG9y dXpoaWNrIDxhbmFyc291bEBnbWFpbC5jb20+Cj4gW21vdmUgZm9ybWVyIGJ0cnRsX2FwcGx5X3F1 aXJrcyB0byBidHJ0bF9zZXRfcXVpcmtzXQo+IFtyZWJhc2Ugb24gY3VycmVudCB0cmVlXQoKSSBk b27igJl0IGtub3cgd2hhdCB0aGVzZSBtZWFuLiBDYW4geW91IGp1c3QgcmVtb3ZlIHRoZW0uCgo+ IFNpZ25lZC1vZmYtYnk6IEJhc3RpYW4gR2VybWFubiA8YmFnZUBkZWJpYW4ub3JnPgo+IC0tLQo+ IGRyaXZlcnMvYmx1ZXRvb3RoL2J0cnRsLmMgIHwgMTIwICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrLS0KPiBkcml2ZXJzL2JsdWV0b290aC9idHJ0bC5oICB8ICAgNSArKwo+IGRy aXZlcnMvYmx1ZXRvb3RoL2hjaV9oNS5jIHwgICA0ICsrCj4gMyBmaWxlcyBjaGFuZ2VkLCAxMjUg aW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKClJlZ2FyZHMKCk1hcmNlbAoKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwg bWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK