From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB5dU-0004Iu-KF for qemu-devel@nongnu.org; Tue, 13 Jan 2015 12:52:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB5dR-0004gF-SL for qemu-devel@nongnu.org; Tue, 13 Jan 2015 12:52:12 -0500 Received: from mail-qc0-x236.google.com ([2607:f8b0:400d:c01::236]:34589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB5dR-0004gB-OK for qemu-devel@nongnu.org; Tue, 13 Jan 2015 12:52:09 -0500 Received: by mail-qc0-f182.google.com with SMTP id r5so3400696qcx.13 for ; Tue, 13 Jan 2015 09:52:09 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Programmingkid In-Reply-To: Date: Tue, 13 Jan 2015 12:52:05 -0500 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20150106140224.GK29775@stefanha-thinkpad.redhat.com> Subject: Re: [Qemu-devel] [PATCH v4] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Peter Maydell , qemu-devel qemu-devel On Jan 13, 2015, at 9:05 AM, Stefan Hajnoczi wrote: > On Tue, Jan 6, 2015 at 3:04 PM, Programmingkid > wrote: >>=20 >> On Jan 6, 2015, at 9:02 AM, Stefan Hajnoczi wrote: >>=20 >>> On Fri, Jan 02, 2015 at 04:44:38PM -0500, Programmingkid wrote: >>>> Removes redundant ret variable and renames sectorSize variable to = meet QEMU coding standards. >>>=20 >>> This is a changelog item for v4 of this patch. Changelogs should go >>> below the '---' line so they are not merged into git history. >>>=20 >>> The rationale is that when a patch is merged into git, the changelog >>> describing patch revisions that were posted on the mailing list is = not >>> relevant (we only see the final patch in git, not the revisions from = the >>> mailing list). >>>=20 >>> Patches usually look like this: >>>=20 >>> Subject: block/raw-posix: brief summary >>>=20 >>> A longer description of the problem, maybe a command-line to = reproduce a >>> bug, and some rationale for this code change. >>>=20 >>> Signed-off-by: Me >>> --- >>> v2: >>> * Fix int -> size_t for memory lengths [Requested by Bob] >>>=20 >>> The changelog at the bottom is useful to code reviewers but won't = get >>> merged in the git history. >>>=20 >>> Anyway, thanks for this patch. I have dropped this changelog line = and >>> merged it! >>>=20 >>>>=20 >>>> Signed-off-by: John Arbuckle >>>>=20 >>>> --- >>>> block/raw-posix.c | 18 +++++++++++++++++- >>>> configure | 2 +- >>>> 2 files changed, 18 insertions(+), 2 deletions(-) >>>=20 >>> Thanks, applied to my block tree: >>> https://github.com/stefanha/qemu/commits/block >>>=20 >>> Stefan >>=20 >> Thank you very much for accepting my patch. >=20 > Hi, > Unfortunately I had to drop this patch because it breaks -drive > file=3D/dev/null,... >=20 > /dev/null is a character device and we should not return -ENOTSUP when > the CD-ROM ioctls fail. >=20 > Please let it fail gracefully when the device is not a CD-ROM. >=20 > Stefan What is the exact command you use with QEMU involving the /dev/null = device? What value is suppose to be returned when using a device like /dev/null?=