[PATCH] wrong order of kzalloc arguments

[PATCH] wrong order of kzalloc arguments

[Al Viro]

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
 drivers/acpi/bay.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/bay.c b/drivers/acpi/bay.c
index 667fa1d..91082ce 100644
--- a/drivers/acpi/bay.c
+++ b/drivers/acpi/bay.c
@@ -296,7 +296,7 @@ static int bay_add(acpi_handle handle, int id)
 	/*
 	 * Initialize bay device structure
 	 */
-	new_bay = kzalloc(GFP_ATOMIC, sizeof(*new_bay));
+	new_bay = kzalloc(sizeof(*new_bay), GFP_ATOMIC);
 	INIT_LIST_HEAD(&new_bay->list);
 	new_bay->handle = handle;
 	new_bay->name = (char *)nbuffer.pointer;
-- 
1.5.0-rc2.GIT

Re: [PATCH] wrong order of kzalloc arguments

[Kristen Accardi]

On 2/9/07, Al Viro <viro@ftp.linux.org.uk> wrote:
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
>  drivers/acpi/bay.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/bay.c b/drivers/acpi/bay.c
> index 667fa1d..91082ce 100644
> --- a/drivers/acpi/bay.c
> +++ b/drivers/acpi/bay.c
> @@ -296,7 +296,7 @@ static int bay_add(acpi_handle handle, int id)
>         /*
>          * Initialize bay device structure
>          */
> -       new_bay = kzalloc(GFP_ATOMIC, sizeof(*new_bay));
> +       new_bay = kzalloc(sizeof(*new_bay), GFP_ATOMIC);
>         INIT_LIST_HEAD(&new_bay->list);
>         new_bay->handle = handle;
>         new_bay->name = (char *)nbuffer.pointer;
> --
> 1.5.0-rc2.GIT
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

Oops.  thanks for taking the time to review and fix this.

Kristen