[Qemu-devel] qemu vl.c

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/12/16 13:17:13

Modified files:
	.              : vl.c 

Log message:
	Redundant timer rearm optimisation by Anders Melchiorsen.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.383&r2=1.384

Re: [Qemu-devel] qemu vl.c

[Paul Brook]

On Sunday 16 December 2007, Andrzej Zaborowski wrote:
> CVSROOT:	/sources/qemu
> Module name:	qemu
> Changes by:	Andrzej Zaborowski <balrog>	07/12/16 13:17:13
>
> Modified files:
> 	.              : vl.c
>
> Log message:
> 	Redundant timer rearm optimisation by Anders Melchiorsen.

I think this is incorrect.

When a timer is modified, we need to rearm the host timer immediately. We can 
not wait for the old timer to fire, or for execution to fall back to the 
main_loop_wait.  Consider the case where the guest adds a timer interrupt and 
immediately enters a tight loop - Quite a common operation when calibrating a 
software delay loop. The timer won't be rearmed until some other event 
occurs. It the system is otherwise quiescent and you're not using SDL output 
it may never occur.

Paul

Re: [Qemu-devel] qemu vl.c

[Anders]

Paul Brook wrote:

>> 	Redundant timer rearm optimisation by Anders Melchiorsen.
> 
> I think this is incorrect.
> 
> When a timer is modified, we need to rearm the host timer immediately. We can 
> not wait for the old timer to fire, or for execution to fall back to the 
> main_loop_wait.  Consider the case where the guest adds a timer interrupt and 
> immediately enters a tight loop - Quite a common operation when calibrating a 
> software delay loop. The timer won't be rearmed until some other event 
> occurs. It the system is otherwise quiescent and you're not using SDL output 
> it may never occur.

Hi Paul,

I am certainly open to it not being correct, but currently I fail to see 
how it changes the scenario that you mention. The rearming is moved away 
from qemu_run_timers(), not qemu_mod_timer(). Can you elaborate?


There was a previous patch to remove the rearming when timers are modified,

http://cvs.savannah.gnu.org/viewvc/qemu/vl.c?root=qemu&view=log#rev1.345

and to me it seems that this might affect the case that you describe.


Cheers,
Anders.

Re: [Qemu-devel] qemu vl.c

[Paul Brook]

On Sunday 16 December 2007, Anders wrote:
> Paul Brook wrote:
> >> 	Redundant timer rearm optimisation by Anders Melchiorsen.
> >
> > I think this is incorrect.
> >
> > When a timer is modified, we need to rearm the host timer immediately. We
> > can not wait for the old timer to fire, or for execution to fall back to
> > the main_loop_wait.  Consider the case where the guest adds a timer
> > interrupt and immediately enters a tight loop - Quite a common operation
> > when calibrating a software delay loop. The timer won't be rearmed until
> > some other event occurs. It the system is otherwise quiescent and you're
> > not using SDL output it may never occur.
>
> Hi Paul,
>
> I am certainly open to it not being correct, but currently I fail to see
> how it changes the scenario that you mention. The rearming is moved away
> from qemu_run_timers(), not qemu_mod_timer(). Can you elaborate?

It's possible that this code has always been broken. You changes make it much 
more obviously so.

> There was a previous patch to remove the rearming when timers are modified,
>
> http://cvs.savannah.gnu.org/viewvc/qemu/vl.c?root=qemu&view=log#rev1.345

I think this this is unrealted.

Re: [Qemu-devel] qemu vl.c

[Avi Kivity]

Paul Brook wrote:
> On Sunday 16 December 2007, Anders wrote:
>   
>> Paul Brook wrote:
>>     
>>>> 	Redundant timer rearm optimisation by Anders Melchiorsen.
>>>>         
>>> I think this is incorrect.
>>>
>>> When a timer is modified, we need to rearm the host timer immediately. We
>>> can not wait for the old timer to fire, or for execution to fall back to
>>> the main_loop_wait.  Consider the case where the guest adds a timer
>>> interrupt and immediately enters a tight loop - Quite a common operation
>>> when calibrating a software delay loop. The timer won't be rearmed until
>>> some other event occurs. It the system is otherwise quiescent and you're
>>> not using SDL output it may never occur.
>>>       
>> Hi Paul,
>>
>> I am certainly open to it not being correct, but currently I fail to see
>> how it changes the scenario that you mention. The rearming is moved away
>> from qemu_run_timers(), not qemu_mod_timer(). Can you elaborate?
>>     
>
> It's possible that this code has always been broken. You changes make it much 
> more obviously so.
>
>   

I'm merging qemu-cvs into the kvm repository now, and with this commit 
in, kvm will hang after about a minute.  Attaching to it with gdb or 
strace will cause it to resume, so this is very likely a missing signal 
problem.

(qemu will happily run with this patch; kvm is much more sensitive to 
missed signals).


-- 
Any sufficiently difficult bug is indistinguishable from a feature.

Re: [Qemu-devel] qemu vl.c

[Anders]

>>>>> 	Redundant timer rearm optimisation by Anders Melchiorsen.

> I'm merging qemu-cvs into the kvm repository now, and with this commit
> in, kvm will hang after about a minute.  Attaching to it with gdb or
> strace will cause it to resume, so this is very likely a missing signal
> problem.

That is clearly not good.

I still cannot see anything wrong with my patch. As fewer signals are
delivered now, it is possible that this change highlights some old race.
It is certainly also possible that my patch is all wrong, even if I am not
able to see it.


The next few days I will be travelling, but when I get back, I was
planning to address Pauls concern by adding

  qemu_rearm_alarm_timer(alarm_timer);

to the bottom of qemu_mod_timer().

If you feel like it, you can try that out. I am predicting that I will
have a hard time reproducing your hang, as I have only been testing with
kvm, and obviously not seen this problem yet.

(What I really plan to add is a rearm only if the new timer is added at
the head of the list, but the above should do for a test)


Cheers,
Anders.

Re: [Qemu-devel] qemu vl.c

[andrzej zaborowski]

[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]

On 18/12/2007, Anders <mail@flac.kalibalik.dk> wrote:
>
> >>>>>   Redundant timer rearm optimisation by Anders Melchiorsen.
>
> > I'm merging qemu-cvs into the kvm repository now, and with this commit
> > in, kvm will hang after about a minute.  Attaching to it with gdb or
> > strace will cause it to resume, so this is very likely a missing signal
> > problem.
>
> That is clearly not good.
>
> I still cannot see anything wrong with my patch. As fewer signals are
> delivered now, it is possible that this change highlights some old race.

Yes, I don't see anything wrong in this change either but I see how
the scenario given by Paul was already buggy before. Paul confirmed on
IRC that this is also what he meant.

I suspect it was buggy since "unix" and "rtc" stopped being the only
available clock sources.

> It is certainly also possible that my patch is all wrong, even if I am not
> able to see it.
>
>
> The next few days I will be travelling, but when I get back, I was
> planning to address Pauls concern by adding
>
>   qemu_rearm_alarm_timer(alarm_timer);

That would be also my first guess at fixing this, but I have no good
test-case (obviously I wouldn't have committed the change if I had
such a test-case).

>
> to the bottom of qemu_mod_timer().
>
> If you feel like it, you can try that out. I am predicting that I will
> have a hard time reproducing your hang, as I have only been testing with
> kvm, and obviously not seen this problem yet.
>
> (What I really plan to add is a rearm only if the new timer is added at
> the head of the list, but the above should do for a test)

Attached is a small patch to do exactly this. The rearming in
main_loop_wait() can also be made conditional but I don't think there
would be a real gain.

Testing with KVM will be appreciated.

Regards

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: qemu-timers.patch --]
[-- Type: text/x-patch; name=qemu-timers.patch, Size: 402 bytes --]

diff --git a/vl.c b/vl.c
index 70950f8..7552fde 100644
--- a/vl.c
+++ b/vl.c
@@ -1041,6 +1041,10 @@ void qemu_mod_timer(QEMUTimer *ts, int64_t expire_time)
     ts->expire_time = expire_time;
     ts->next = *pt;
     *pt = ts;
+
+    /* rearm if the necessary */
+    if (pt == &active_timers[ts->clock->type])
+        qemu_rearm_alarm_timer(alarm_timer);
 }
 
 int qemu_timer_pending(QEMUTimer *ts)

Re: [Qemu-devel] qemu vl.c

[Avi Kivity]

andrzej zaborowski wrote:
> Attached is a small patch to do exactly this. The rearming in
> main_loop_wait() can also be made conditional but I don't think there
> would be a real gain.
>
> Testing with KVM will be appreciated.
>
> Regards
>   

Time in grub is completely off, Linux calibrate_delay() complains, 
'sleep 1' doesn't return, but FC6 x86-64 boots.

(this is with your patch on top of the re-applied patch I reverted earlier).

-- 
error compiling committee.c: too many arguments to function

Re: [Qemu-devel] qemu vl.c

[Anders]

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

Avi Kivity wrote:

> Time in grub is completely off, Linux calibrate_delay() complains, 
> 'sleep 1' doesn't return, but FC6 x86-64 boots.
> 
> (this is with your patch on top of the re-applied patch I reverted earlier).
> 

Now I have updated my kvm checkout, and I immediately got trouble 
booting the guest. So it seems something has changed since I made my 
first patch.

What I could find is that the "env" variable in host_alarm_handler() is 
always NULL now? Then the expiry flag has to be set outside of that 
conditional, or alarms will never expire.

Also, an optimization of the new rearming in qemu_mod_timer() is that it 
should not be done if we are currently running the expired timers. It 
will be done after all the running is over, anyway.

Attached is a reworked patch with these changes, it should apply against 
your kvm git master (i.e. do not re-apply the reverted one).


Anders.

[-- Attachment #2: kvm-reduce-rearm.diff --]
[-- Type: text/x-patch, Size: 1723 bytes --]

diff --git a/qemu/vl.c b/qemu/vl.c
index 28c5df4..000df7e 100644
--- a/qemu/vl.c
+++ b/qemu/vl.c
@@ -850,6 +850,7 @@ struct qemu_alarm_timer {
 };
 
 #define ALARM_FLAG_DYNTICKS  0x1
+#define ALARM_FLAG_EXPIRED   0x2
 
 static inline int alarm_has_dynticks(struct qemu_alarm_timer *t)
 {
@@ -1061,6 +1062,12 @@ void qemu_mod_timer(QEMUTimer *ts, int64_t expire_time)
     ts->expire_time = expire_time;
     ts->next = *pt;
     *pt = ts;
+
+    /* Rearm if necessary  */
+    if ((alarm_timer->flags & ALARM_FLAG_EXPIRED) == 0
+        && pt == &active_timers[ts->clock->type]) {
+        qemu_rearm_alarm_timer(alarm_timer);
+    }
 }
 
 int qemu_timer_pending(QEMUTimer *ts)
@@ -1095,7 +1102,6 @@ static void qemu_run_timers(QEMUTimer **ptimer_head, int64_t current_time)
         /* run the callback (the timer list can be modified) */
         ts->cb(ts->opaque);
     }
-    qemu_rearm_alarm_timer(alarm_timer);
 }
 
 int64_t qemu_get_clock(QEMUClock *clock)
@@ -1215,6 +1221,8 @@ static void host_alarm_handler(int host_signum)
 #endif
         CPUState *env = next_cpu;
 
+        alarm_timer->flags |= ALARM_FLAG_EXPIRED;
+
         if (env) {
             /* stop the currently executing cpu because a timer occured */
             cpu_interrupt(env, CPU_INTERRUPT_EXIT);
@@ -7726,6 +7734,11 @@ void main_loop_wait(int timeout)
     qemu_run_timers(&active_timers[QEMU_TIMER_REALTIME],
                     qemu_get_clock(rt_clock));
 
+    if (alarm_timer->flags & ALARM_FLAG_EXPIRED) {
+        alarm_timer->flags &= ~(ALARM_FLAG_EXPIRED);
+        qemu_rearm_alarm_timer(alarm_timer);
+    }
+
     /* Check bottom-halves last in case any of the earlier events triggered
        them.  */
     qemu_bh_poll();

[Qemu-devel] qemu vl.c

[Paul Brook]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Paul Brook <pbrook>	08/03/24 02:31:33

Modified files:
	.              : vl.c 

Log message:
	Put tap fd into nonblocking mode.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.412&r2=1.413

[Qemu-devel] qemu vl.c

[Aurelien Jarno]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Aurelien Jarno <aurel32>	08/03/09 23:43:49

Modified files:
	.              : vl.c 

Log message:
	Be consistent in -clock parameter. Display also the list of available
	sources if no valid clock name has been specified.
	(Hervé Poussineau)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.408&r2=1.409

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	08/02/03 03:45:47

Modified files:
	.              : vl.c 

Log message:
	Do not set RTC frequency if already set (Aurelien Jarno).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.402&r2=1.403

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	08/01/14 03:11:16

Modified files:
	.              : vl.c 

Log message:
	Clean-up /tmp directory after -smb use (Mark Jonckheere).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.396&r2=1.397

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	08/01/08 19:32:16

Modified files:
	.              : vl.c 

Log message:
	Fix segfault caused by fall through, by Juergen Lock.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.394&r2=1.395

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	08/01/05 19:41:48

Modified files:
	.              : vl.c 

Log message:
	Rearm timers in qemu_mod_timer when needed (Anders Melchiorsen).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.392&r2=1.393

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/12/24 13:58:47

Modified files:
	.              : vl.c 

Log message:
	Avoid the use of $ in format strings because it's system-specific - fixes drive names under Win32 (Eduardo Felipe).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.388&r2=1.389

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/12/16 11:48:54

Modified files:
	.              : vl.c 

Log message:
	Support alternative formats for MAC addresses, by Balazs Attila-Mihaly.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.381&r2=1.382

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/12/06 22:11:20

Modified files:
	.              : vl.c 

Log message:
	Give emulated drives more monitor-friendly name strings.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.376&r2=1.377

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/12/03 03:01:40

Modified files:
	.              : vl.c 

Log message:
	Ensure a SIGALRM results in a break out from the cpu loop.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.374&r2=1.375

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/11/24 23:27:16

Modified files:
	.              : vl.c 

Log message:
	Drop an unused variable (Samuel Thibault).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.369&r2=1.370

[Qemu-devel] qemu vl.c

[Jocelyn Mayer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Jocelyn Mayer <j_mayer>	07/11/19 01:05:22

Modified files:
	.              : vl.c 

Log message:
	Mark hex_dump as unused to avoid compilation warnings.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.368&r2=1.369

[Qemu-devel] qemu vl.c

[Paul Brook]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Paul Brook <pbrook>	07/11/15 19:04:09

Modified files:
	.              : vl.c 

Log message:
	Init dumb display if no others available.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.361&r2=1.362

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/10/26 17:21:59

Modified files:
	.              : vl.c 

Log message:
	Fix Windows build failure, by Stefan Weil.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.350&r2=1.351

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/10/21 23:20:46

Modified files:
	.              : vl.c 

Log message:
	Support tap down script, by Wolfram Gloger.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.349&r2=1.350

Re: [Qemu-devel] qemu vl.c

[Stefan Weil]

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

Thiemo Seufer schrieb:
> CVSROOT: /sources/qemu
> Module name: qemu
> Changes by: Thiemo Seufer <ths> 07/10/21 23:20:46
>
> Modified files:
> . : vl.c
>
> Log message:
> Support tap down script, by Wolfram Gloger.
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.349&r2=1.350
Hi Thiemo,

on Windows, vl.c raises a compilation error. This patch fixes it.

Stefan


[-- Attachment #2: vl.patch --]
[-- Type: text/x-diff, Size: 931 bytes --]

Index: vl.c
===================================================================
RCS file: /sources/qemu/qemu/vl.c,v
retrieving revision 1.350
diff -u -b -B -r1.350 vl.c
--- vl.c	21 Oct 2007 23:20:45 -0000	1.350
+++ vl.c	26 Oct 2007 15:07:02 -0000
@@ -8478,12 +8478,12 @@
     main_loop();
     quit_timers();
 
+#if !defined(_WIN32)
     /* close network clients */
     for(vlan = first_vlan; vlan != NULL; vlan = vlan->next) {
         VLANClientState *vc;
 
-        for(vc = vlan->first_client; vc != NULL; vc = vc->next)
-#if !defined(_WIN32)
+        for(vc = vlan->first_client; vc != NULL; vc = vc->next) {
             if (vc->fd_read == tap_receive) {
                 char ifname[64];
                 TAPState *s = vc->opaque;
@@ -8492,7 +8492,8 @@
                     s->down_script[0])
                     launch_script(s->down_script, ifname, s->fd);
             }
-#endif
     }
+    }
+#endif
     return 0;
 }

Re: [Qemu-devel] qemu vl.c

[Johannes Schindelin]

Hi,

On Fri, 26 Oct 2007, Stefan Weil wrote:

> Thiemo Seufer schrieb:
> > CVSROOT: /sources/qemu
> > Module name: qemu
> > Changes by: Thiemo Seufer <ths> 07/10/21 23:20:46
> >
> > Modified files:
> > . : vl.c
> >
> > Log message:
> > Support tap down script, by Wolfram Gloger.
> >
> > CVSWeb URLs:
> > http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.349&r2=1.350
> Hi Thiemo,
> 
> on Windows, vl.c raises a compilation error. This patch fixes it.

Which is identical to the patch that I linked to in my earlier mail, so 
now you have two people saying that this patch is correct.

Ciao,
Dscho

Re: [Qemu-devel] qemu vl.c

[Thiemo Seufer]

Johannes Schindelin wrote:
> Hi,
> 
> On Fri, 26 Oct 2007, Stefan Weil wrote:
> 
> > Thiemo Seufer schrieb:
> > > CVSROOT: /sources/qemu
> > > Module name: qemu
> > > Changes by: Thiemo Seufer <ths> 07/10/21 23:20:46
> > >
> > > Modified files:
> > > . : vl.c
> > >
> > > Log message:
> > > Support tap down script, by Wolfram Gloger.
> > >
> > > CVSWeb URLs:
> > > http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.349&r2=1.350
> > Hi Thiemo,
> > 
> > on Windows, vl.c raises a compilation error. This patch fixes it.
> 
> Which is identical to the patch that I linked to in my earlier mail, so 
> now you have two people saying that this patch is correct.

It was more a matter of having time at all...

Thanks to both of you,
Thiemo

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/10/04 19:59:04

Modified files:
	.              : vl.c 

Log message:
	Remove redundant qemu_rearm_alarm_timer() in qemu_del_timer, patch by Dan Kenigsberg.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.344&r2=1.345

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/10/04 19:47:09

Modified files:
	.              : vl.c 

Log message:
	(int64_t)UINT64_MAX is -1 and should not be assigned to nearest_delta_us, patch by Dan Kenigsberg.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.343&r2=1.344

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/09/17 21:25:21

Modified files:
	.              : vl.c 

Log message:
	Prevent segfaulting when -clock is specified multiple times.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.341&r2=1.342

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/09/16 19:53:43

Modified files:
	.              : vl.c 

Log message:
	Use UINT64_MAX instead of ULONG_LONG_MAX, suggested by Andreas Schwab.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.337&r2=1.338

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/08/28 22:21:41

Modified files:
	.              : vl.c 

Log message:
	Build fix for older GCCs.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.335&r2=1.336

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/08/26 17:31:30

Modified files:
	.              : vl.c 

Log message:
	Fix typo in comment, by Andreas Faerber.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.333&r2=1.334

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/08/26 17:29:15

Modified files:
	.              : vl.c 

Log message:
	Make dynticks conditional on __linux__. Spotted by Andreas Faerber.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.332&r2=1.333

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/08/25 01:34:19

Modified files:
	.              : vl.c 

Log message:
	Avoid SEGV in IOHandler dispatch, by Daniel P. Berrange.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.330&r2=1.331

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/08/24 01:46:57

Modified files:
	.              : vl.c 

Log message:
	De-noise startup.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.329&r2=1.330

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/08/24 01:36:32

Modified files:
	.              : vl.c 

Log message:
	Add support for dynamic ticks, by Luca Tettamanti and Dan Kenigsberg.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.328&r2=1.329

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/08/24 01:26:02

Modified files:
	.              : vl.c 

Log message:
	Implement -clock selection, by Luca Tettamanti.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.327&r2=1.328

[Qemu-devel] qemu vl.c

[Paul Brook]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Paul Brook <pbrook>	07/08/23 20:22:22

Modified files:
	.              : vl.c 

Log message:
	Suppress int<->pointer compiler warnings.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.326&r2=1.327

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/08/20 15:42:23

Modified files:
	.              : vl.c 

Log message:
	Windows build fix, spotted by Herve Poussineau.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.325&r2=1.326

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/08/19 22:09:40

Modified files:
	.              : vl.c 

Log message:
	Add -clock option, by Luca Tettamanti.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.324&r2=1.325

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/07/02 15:03:13

Modified files:
	.              : vl.c 

Log message:
	Retry interrupted open() calls (proposed by Yigael Felishman).
	Linux open(2) doesn't list EINTR, but FreeBSD's open(2) does.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.319&r2=1.320

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/07/02 13:31:53

Modified files:
	.              : vl.c 

Log message:
	Fix qemu_can_send_packet(), makes DHCP with multiple nics work - patch by Jason Wessel.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.318&r2=1.319

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/07/02 13:20:18

Modified files:
	.              : vl.c 

Log message:
	gdb stub support and loadvm should work together, patch by Jason Wessel

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.317&r2=1.318

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/06/29 23:26:08

Modified files:
	.              : vl.c 

Log message:
	Sanitize exit codes of help queries, this time for real.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.316&r2=1.317

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/06/28 15:14:49

Modified files:
	.              : vl.c 

Log message:
	Limit the use of qemu_chr_open_tty to __linux__ and __sun__, by Andreas
	Faerber.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.315&r2=1.316

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/06/28 14:05:38

Modified files:
	.              : vl.c 

Log message:
	Fix segfault when printing the help text, spotted by Stefan Weil.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.314&r2=1.315

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/06/25 11:48:07

Modified files:
	.              : vl.c 

Log message:
	Enable serial (tty) support on Solaris host, by Marion Hakanson.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.313&r2=1.314

Re: [Qemu-devel] qemu vl.c

[Andreas Färber]

Hello,

Am 25.06.2007 um 13:48 schrieb Thiemo Seufer:

> CVSROOT:	/sources/qemu
> Module name:	qemu
> Changes by:	Thiemo Seufer <ths>	07/06/25 11:48:07
>
> Modified files:
> 	.              : vl.c
>
> Log message:
> 	Enable serial (tty) support on Solaris host, by Marion Hakanson.
>
> CVSWeb URLs:
> http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c? 
> cvsroot=qemu&r1=1.313&r2=1.314
>
>

Unfortunately this has introduced a regression on Mac OS X:
qemu_chr_open_tty is being used although not defined.

Andreas

Re: [Qemu-devel] qemu vl.c

[Andreas Färber]

[-- Attachment #1: Type: text/plain, Size: 557 bytes --]


> Am 25.06.2007 um 13:48 schrieb Thiemo Seufer:
>
>> CVSROOT:	/sources/qemu
>> Module name:	qemu
>> Changes by:	Thiemo Seufer <ths>	07/06/25 11:48:07
>>
>> Modified files:
>> 	.              : vl.c
>>
>> Log message:
>> 	Enable serial (tty) support on Solaris host, by Marion Hakanson.
>>
>> CVSWeb URLs:
>> http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c? 
>> cvsroot=qemu&r1=1.313&r2=1.314
>>
>>
>
> Unfortunately this has introduced a regression on Mac OS X:
> qemu_chr_open_tty is being used although not defined.

Attached is a possible patch.

Andreas

[-- Attachment #2: vl.c_tty.diff --]
[-- Type: application/octet-stream, Size: 234 bytes --]

Index: vl.c
===================================================================
RCS file: /sources/qemu/qemu/vl.c,v
retrieving revision 1.314
diff -r1.314 vl.c
2963a2964
> #if defined(__linux__) || defined(__sun__)
2966a2968
> #endif

[-- Attachment #3: Type: text/plain, Size: 1 bytes --]

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/06/23 16:01:57

Modified files:
	.              : vl.c 

Log message:
	Return success for -M '?' query option.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.310&r2=1.311

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/06/22 08:23:44

Modified files:
	.              : vl.c 

Log message:
	Use HAS_ARG instead of numeric value (patch by Balazs Attila-Mihaly).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.309&r2=1.310

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/06/21 23:34:19

Modified files:
	.              : vl.c 

Log message:
	Fix segfault in -nographic mode, by Stefen Weil.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.307&r2=1.308

[Qemu-devel] qemu vl.c

[Paul Brook]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Paul Brook <pbrook>	07/05/28 02:29:59

Modified files:
	.              : vl.c 

Log message:
	Fix tap device counting.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.302&r2=1.303

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/05/18 17:46:59

Modified files:
	.              : vl.c 

Log message:
	Fix sysrq support from the monitor mux (originally by Jason Wessel).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.295&r2=1.296

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/05/13 14:54:54

Modified files:
	.              : vl.c 

Log message:
	Windows: redirect serial port to console, by Herve Poussineau.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.294&r2=1.295

[Qemu-devel] qemu vl.c

[Andrzej Zaborowski]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Andrzej Zaborowski <balrog>	07/05/03 10:13:54

Modified files:
	.              : vl.c 

Log message:
	Remove obsolete variables that came with VMware svga by mistake.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.293&r2=1.294

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/04/28 20:49:36

Modified files:
	.              : vl.c 

Log message:
	Fix typo, by Linus Nordberg.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.285&r2=1.286

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/04/18 18:11:47

Modified files:
	.              : vl.c 

Log message:
	Fix compiler warning.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.281&r2=1.282

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/04/18 17:56:03

Modified files:
	.              : vl.c 

Log message:
	Win32 Tap inferface PPC Guest issue, by Ely Soto.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.280&r2=1.281

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/03/25 20:27:04

Modified files:
	.              : vl.c 

Log message:
	Fix segfault with -nographic, by Enache Adrian.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.272&r2=1.273

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/03/25 15:58:03

Modified files:
	.              : vl.c 

Log message:
	Windows sockets like to be different. Inspired by a patch from Alex Consul.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.271&r2=1.272

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/03/22 12:36:53

Modified files:
	.              : vl.c 

Log message:
	Win32 build fix. FIXME: This disables locking of the pidfile, a
	Win32 replacement of lockf should be used here.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.269&r2=1.270

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/03/19 16:36:43

Modified files:
	.              : vl.c 

Log message:
	Close file descriptors when execing network tap setup script, by
	Daniel P. Berrange.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.268&r2=1.269

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/03/19 15:58:31

Modified files:
	.              : vl.c 

Log message:
	Improve -pidfile option, by Anthony Liguori.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.267&r2=1.268

[Qemu-devel] qemu vl.c

[Paul Brook]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Paul Brook <pbrook>	07/03/11 18:54:57

Modified files:
	.              : vl.c 

Log message:
	SMP half-idle fix.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.263&r2=1.264

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/02/28 21:59:44

Modified files:
	.              : vl.c 

Log message:
	Make removing IOHandlers safe from within an IOHandler, by Anthony Liguori.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.259&r2=1.260

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/02/21 17:25:30

Modified files:
	.              : vl.c 

Log message:
	Increase the number of multiplexed monitor devices.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.257&r2=1.258

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/02/19 01:10:26

Modified files:
	.              : vl.c 

Log message:
	Don't require a disk image for network boot, by Ferenc Wagner.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.254&r2=1.255

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/02/17 22:54:49

Modified files:
	.              : vl.c 

Log message:
	Solaris tap device, by Sittichai Palingsong.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.250&r2=1.251

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/02/10 21:50:42

Modified files:
	.              : vl.c 

Log message:
	Clean up serial code for Win 32, by Kazu.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.249&r2=1.250

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	07/02/02 03:30:55

Modified files:
	.              : vl.c 

Log message:
	Mingw build fix, by Johannes Schindelin.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.245&r2=1.246

Re: [Qemu-devel] qemu vl.c

[Kazu]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

Hi,

An attached patch cleans serial for Win32.

Regards,
Kazu

Sent: Friday, February 02, 2007 12:30 PM Thiemo Seufer wrote:

> CVSROOT: /sources/qemu
> Module name: qemu
> Changes by: Thiemo Seufer <ths> 07/02/02 03:30:55
>
> Modified files:
> .              : vl.c
>
> Log message:
> Mingw build fix, by Johannes Schindelin.
>
> CVSWeb URLs:
>
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.245&r2=1.246
>
>

[-- Attachment #2: qemu-20070202-serial.patch --]
[-- Type: application/octet-stream, Size: 4781 bytes --]

Index: vl.c
===================================================================
RCS file: /sources/qemu/qemu/vl.c,v
retrieving revision 1.246
diff -u -r1.246 vl.c
--- vl.c	2 Feb 2007 03:30:54 -0000	1.246
+++ vl.c	2 Feb 2007 04:58:36 -0000
@@ -1875,7 +1875,6 @@
 
 #ifdef _WIN32
 typedef struct {
-    CharDriverState *chr;
     int max_size;
     HANDLE hcom, hrecv, hsend;
     OVERLAPPED orecv, osend;
@@ -1891,8 +1890,10 @@
 static int win_chr_poll(void *opaque);
 static int win_chr_pipe_poll(void *opaque);
 
-static void win_chr_close2(WinCharState *s)
+static void win_chr_close(CharDriverState *chr)
 {
+    WinCharState *s = chr->opaque;
+
     if (s->hsend) {
         CloseHandle(s->hsend);
         s->hsend = NULL;
@@ -1906,19 +1907,14 @@
         s->hcom = NULL;
     }
     if (s->fpipe)
-        qemu_del_polling_cb(win_chr_pipe_poll, s);
+        qemu_del_polling_cb(win_chr_pipe_poll, chr);
     else
-        qemu_del_polling_cb(win_chr_poll, s);
+        qemu_del_polling_cb(win_chr_poll, chr);
 }
 
-static void win_chr_close(CharDriverState *chr)
+static int win_chr_init(CharDriverState *chr, const char *filename)
 {
     WinCharState *s = chr->opaque;
-    win_chr_close2(s);
-}
-
-static int win_chr_init(WinCharState *s, CharDriverState *chr, const char *filename)
-{
     COMMCONFIG comcfg;
     COMMTIMEOUTS cto = { 0, 0, 0, 0, 0};
     COMSTAT comstat;
@@ -1975,12 +1971,11 @@
         fprintf(stderr, "Failed ClearCommError\n");
         goto fail;
     }
-    s->chr = chr;
-    qemu_add_polling_cb(win_chr_poll, s);
+    qemu_add_polling_cb(win_chr_poll, chr);
     return 0;
 
  fail:
-    win_chr_close2(s);
+    win_chr_close(chr);
     return -1;
 }
 
@@ -2018,14 +2013,17 @@
     return len1 - len;
 }
 
-static int win_chr_read_poll(WinCharState *s)
+static int win_chr_read_poll(CharDriverState *chr)
 {
-    s->max_size = qemu_chr_can_read(s->chr);
+    WinCharState *s = chr->opaque;
+
+    s->max_size = qemu_chr_can_read(chr);
     return s->max_size;
 }
 
-static void win_chr_readfile(WinCharState *s)
+static void win_chr_readfile(CharDriverState *chr)
 {
+    WinCharState *s = chr->opaque;
     int ret, err;
     uint8_t buf[1024];
     DWORD size;
@@ -2041,31 +2039,34 @@
     }
 
     if (size > 0) {
-        qemu_chr_read(s->chr, buf, size);
+        qemu_chr_read(chr, buf, size);
     }
 }
 
-static void win_chr_read(WinCharState *s)
+static void win_chr_read(CharDriverState *chr)
 {
+    WinCharState *s = chr->opaque;
+
     if (s->len > s->max_size)
         s->len = s->max_size;
     if (s->len == 0)
         return;
     
-    win_chr_readfile(s);
+    win_chr_readfile(chr);
 }
 
 static int win_chr_poll(void *opaque)
 {
-    WinCharState *s = opaque;
+    CharDriverState *chr = opaque;
+    WinCharState *s = chr->opaque;
     COMSTAT status;
     DWORD comerr;
     
     ClearCommError(s->hcom, &comerr, &status);
     if (status.cbInQue > 0) {
         s->len = status.cbInQue;
-        win_chr_read_poll(s);
-        win_chr_read(s);
+        win_chr_read_poll(chr);
+        win_chr_read(chr);
         return 1;
     }
     return 0;
@@ -2088,7 +2089,7 @@
     chr->chr_write = win_chr_write;
     chr->chr_close = win_chr_close;
 
-    if (win_chr_init(s, chr, filename) < 0) {
+    if (win_chr_init(chr, filename) < 0) {
         free(s);
         free(chr);
         return NULL;
@@ -2099,21 +2100,23 @@
 
 static int win_chr_pipe_poll(void *opaque)
 {
-    WinCharState *s = opaque;
+    CharDriverState *chr = opaque;
+    WinCharState *s = chr->opaque;
     DWORD size;
 
     PeekNamedPipe(s->hcom, NULL, 0, NULL, &size, NULL);
     if (size > 0) {
         s->len = size;
-        win_chr_read_poll(s);
-        win_chr_read(s);
+        win_chr_read_poll(chr);
+        win_chr_read(chr);
         return 1;
     }
     return 0;
 }
 
-static int win_chr_pipe_init(WinCharState *s, const char *filename)
+static int win_chr_pipe_init(CharDriverState *chr, const char *filename)
 {
+    WinCharState *s = chr->opaque;
     OVERLAPPED ov;
     int ret;
     DWORD size;
@@ -2165,11 +2168,11 @@
         CloseHandle(ov.hEvent);
         ov.hEvent = NULL;
     }
-    qemu_add_polling_cb(win_chr_pipe_poll, s);
+    qemu_add_polling_cb(win_chr_pipe_poll, chr);
     return 0;
 
  fail:
-    win_chr_close2(s);
+    win_chr_close(chr);
     return -1;
 }
 
@@ -2191,7 +2194,7 @@
     chr->chr_write = win_chr_write;
     chr->chr_close = win_chr_close;
     
-    if (win_chr_pipe_init(s, filename) < 0) {
+    if (win_chr_pipe_init(chr, filename) < 0) {
         free(s);
         free(chr);
         return NULL;

Re: [Qemu-devel] qemu vl.c

[Johannes Schindelin]

Hi,

On Sat, 3 Feb 2007, Kazu wrote:

> An attached patch cleans serial for Win32.

Sorry for messing it up.

Ciao,
Dscho

[Qemu-devel] qemu vl.c

[Paul Brook]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Paul Brook <pbrook>	07/01/27 17:19:39

Modified files:
	.              : vl.c 

Log message:
	Accept --foo as an alias for -foo.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.240&r2=1.241

Re: [Qemu-devel] qemu vl.c

[Stefan Weil]

Paul Brook schrieb:
> Log message:
> 	Accept --foo as an alias for -foo.
Great. Most command line programs use --foo for
long parameters. Will this be the new standard
for QEMU, so documentation should be changed?
I'd appreciate that.

Stefan

Re: [Qemu-devel] qemu vl.c

[Paul Brook]

On Saturday 27 January 2007 18:22, Stefan Weil wrote:
> Paul Brook schrieb:
> > Log message:
> > 	Accept --foo as an alias for -foo.
>
> Great. Most command line programs use --foo for
> long parameters. Will this be the new standard
> for QEMU, so documentation should be changed?
> I'd appreciate that.

I've no particularly strong preference. My main motivation was to make --help 
work :-)

Th normal convention is for long option to use -- and single letter options to 
use -, with -foo being equivalent to -f -o -o. Obviously this would break 
backwards compatibility, so I'm not sure we want to go that far.

Paul

[Qemu-devel] qemu vl.c

[Paul Brook]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Paul Brook <pbrook>	07/01/27 17:11:41

Modified files:
	.              : vl.c 

Log message:
	Accept -help.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.239&r2=1.240

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Fabrice Bellard <bellard>	07/01/09 19:44:41

Modified files:
	.              : vl.c 

Log message:
	ifname arg fix

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.235&r2=1.236

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	06/12/23 22:51:27

Modified files:
	.              : vl.c 

Log message:
	Null character instead of numeric null.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.227&r2=1.228

[Qemu-devel] qemu vl.c

[Paul Brook]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Paul Brook <pbrook>	06/12/23 15:37:34

Modified files:
	.              : vl.c 

Log message:
	Solaris SMBD hacks (Ben Taylor).

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.226&r2=1.227

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	06/12/22 21:20:52

Modified files:
	.              : vl.c 

Log message:
	Windows build fix, namespace cleanup, fix error message, by Stefan Weil.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.225&r2=1.226

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	06/12/22 19:25:31

Modified files:
	.              : vl.c 

Log message:
	Support for unidirectional pipes, by Ed Swierk.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.224&r2=1.225

[Qemu-devel] qemu vl.c

[Thiemo Seufer]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Thiemo Seufer <ths>	06/12/22 17:29:05

Modified files:
	.              : vl.c 

Log message:
	Fix -cdrom breakage.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.223&r2=1.224

[Qemu-devel] qemu vl.c

[Paul Brook]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Paul Brook <pbrook>	06/11/01 01:44:16

Modified files:
	.              : vl.c 

Log message:
	Remove FD on close.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.217&r2=1.218

[Qemu-devel] qemu vl.c

[Paul Brook]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Paul Brook <pbrook>	06/09/10 14:39:54

Modified files:
	.              : vl.c 

Log message:
	Avoid (repeatedly) trying to read stdin after it has closed.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.213&r2=1.214

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Fabrice Bellard <bellard>	06/09/09 11:10:18

Modified files:
	.              : vl.c 

Log message:
	two stop bits support

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.212&r2=1.213

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Fabrice Bellard <bellard>	06/08/17 09:43:50

Modified files:
	.              : vl.c 

Log message:
	win32 compilation fix

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.207&r2=1.208

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Fabrice Bellard <bellard>	06/08/07 21:34:46

Modified files:
	.              : vl.c 

Log message:
	copyright update

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.206&r2=1.207

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Fabrice Bellard <bellard>	06/08/06 13:36:11

Modified files:
	.              : vl.c 

Log message:
	use zlib to compress ram snapshots - correctly save qemu clock

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.205&r2=1.206

[Qemu-devel] qemu vl.c

[Paul Brook]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Paul Brook <pbrook>	06/07/15 17:40:09

Modified files:
	.              : vl.c 

Log message:
	Defer timer initialization until after commandline processing.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.200&r2=1.201

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Fabrice Bellard <bellard>	06/07/14 09:36:13

Modified files:
	.              : vl.c 

Log message:
	win32 compilation - force process affinity on win32 as a workaround for SMP issues

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.198&r2=1.199

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Fabrice Bellard <bellard>	06/06/26 20:03:44

Modified files:
	.              : vl.c 

Log message:
	fix crash when closing windows (Frediano Ziglio)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.194&r2=1.195

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Changes by:	Fabrice Bellard <bellard>	06/06/25 16:25:21

Modified files:
	.              : vl.c 

Log message:
	removed unused code - init timers earlier

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/vl.c?cvsroot=qemu&r1=1.191&r2=1.192

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	06/05/01 13:33:02

Modified files:
	.              : vl.c 

Log message:
	use a single select for slirp and qemu sockets

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/vl.c.diff?tr1=1.183&tr2=1.184&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	06/05/01 13:28:36

Modified files:
	.              : vl.c 

Log message:
	workaround: force /dev/rtc usage on Linux

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/vl.c.diff?tr1=1.182&tr2=1.183&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	06/05/01 13:23:04

Modified files:
	.              : vl.c 

Log message:
	better win32 timers - use win32 event to wake up cpu in idle mode (kazu)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/vl.c.diff?tr1=1.181&tr2=1.182&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	06/05/01 12:43:29

Modified files:
	.              : vl.c 

Log message:
	fix for hosts resuming from software suspend (initial patch by John Coiner)

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/vl.c.diff?tr1=1.180&tr2=1.181&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	06/04/30 22:20:58

Modified files:
	.              : vl.c 

Log message:
	typo

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/vl.c.diff?tr1=1.178&tr2=1.179&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Paul Brook]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Paul Brook <pbrook@savannah.gnu.org>	06/03/28 20:20:38

Modified files:
	.              : vl.c 

Log message:
	Use 3-argument open call when creating file.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/vl.c.diff?tr1=1.165&tr2=1.166&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Paul Brook]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Paul Brook <pbrook@savannah.gnu.org>	06/02/10 17:34:03

Modified files:
	.              : vl.c 

Log message:
	Avoid crash if -redir or -smb used without -net user.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/vl.c.diff?tr1=1.163&tr2=1.164&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	06/02/08 22:46:31

Modified files:
	.              : vl.c 

Log message:
	added last_io_time field - '-kernel-kqemu' experimental option

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/vl.c.diff?tr1=1.162&tr2=1.163&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	06/02/01 21:29:26

Modified files:
	.              : vl.c 

Log message:
	win32 socket support

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/vl.c.diff?tr1=1.158&tr2=1.159&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	06/01/08 10:53:14

Modified files:
	.              : vl.c 

Log message:
	kqemu and SMP are currently not compatible

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/vl.c.diff?tr1=1.157&tr2=1.158&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/12/18 19:09:37

Modified files:
	.              : vl.c 

Log message:
	avoid echo on pty devices (David Decotigny) - fixes in the command line help

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/vl.c.diff?tr1=1.155&tr2=1.156&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/sources/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/12/18 18:02:24

Modified files:
	.              : vl.c 

Log message:
	use IPPROTO_IP instead of SOL_IP

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/qemu/qemu/vl.c.diff?tr1=1.154&tr2=1.155&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/11/27 19:10:42

Modified files:
	.              : vl.c 

Log message:
	win32 compile fix

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.150&tr2=1.151&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/11/26 20:10:07

Modified files:
	.              : vl.c 

Log message:
	using _exit in fork() (Kamo Hiroyasu)

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.149&tr2=1.150&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/11/23 21:01:03

Modified files:
	.              : vl.c 

Log message:
	better SMP scheduling

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.147&tr2=1.148&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/11/11 00:00:38

Modified files:
	.              : vl.c 

Log message:
	API for changes in VM state (malc)

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.144&tr2=1.145&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/09/03 21:33:44

Modified files:
	.              : vl.c 

Log message:
	kqemu_enabled test

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.135&tr2=1.136&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/09/03 15:28:59

Modified files:
	.              : vl.c 

Log message:
	avoid losing chars in serial console

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.133&tr2=1.134&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/06/05 14:49:17

Modified files:
	.              : vl.c 

Log message:
	added -M machine option - permit to put CDROM on hdb on PPC to handle the case where a single IDE controller is present

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.127&tr2=1.128&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/04/06 20:32:23

Modified files:
	.              : vl.c 

Log message:
	use standard TCX display size for sparc

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.124&tr2=1.125&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/03/01 21:28:45

Modified files:
	.              : vl.c 

Log message:
	Samba 3 support

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.120&tr2=1.121&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/01/30 22:57:54

Modified files:
	.              : vl.c 

Log message:
	fixed sparc cpu load/save

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.118&tr2=1.119&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/01/26 21:56:26

Modified files:
	.              : vl.c 

Log message:
	i386 linux 2.6 timer fix

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.117&tr2=1.118&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <bellard@savannah.gnu.org>	05/01/15 21:50:11

Modified files:
	.              : vl.c 

Log message:
	-nographic fix

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.116&tr2=1.117&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice@bellard.org>	05/01/09 00:03:14

Modified files:
	.              : vl.c 

Log message:
	compilation fix

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.114&tr2=1.115&r1=text&r2=text

Re: [Qemu-devel] qemu vl.c

[Phil Krylov]

Hello Fabrice,

thanks a lot! Now vl.c compiles here (OS X), but further compilation stops at:

make[1]: Entering directory `/Users/phil/build/qemu/i386-softmmu'
...
../dyngen -o op.h op.o
dyngen: blr expected at the end of op_pmaddwd_mmx
make[1]: *** [op.h] Error 1

-- Ph.

Re: [Qemu-devel] qemu vl.c

[Daniel Egger]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

On 09.01.2005, at 01:58, Phil Krylov wrote:

> thanks a lot! Now vl.c compiles here (OS X), but further compilation 
> stops at:
> dyngen: blr expected at the end of op_pmaddwd_mmx

Which compiler? For gcc >= 3.4 you'll need to supply
-fno-tree-ch as additional flag for the uops.

Servus,
       Daniel

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 478 bytes --]

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice@bellard.org>	05/01/06 20:43:38

Modified files:
	.              : vl.c 

Log message:
	x86_64 save/restore

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.112&tr2=1.113&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice@bellard.org>	05/01/03 23:36:21

Modified files:
	.              : vl.c 

Log message:
	initial x86_64 support

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.111&tr2=1.112&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice@bellard.org>	04/12/12 22:20:04

Modified files:
	.              : vl.c 

Log message:
	no need to use -k for Windows

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.109&tr2=1.110&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice@bellard.org>	04/11/14 15:42:28

Modified files:
	.              : vl.c 

Log message:
	boot device 'b' is not supported

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.105&tr2=1.106&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/12/02 17:18:11

Modified files:
	.              : vl.c 

Log message:
	disable keyboard interrupts if keyboard clock disabled (may not be fully correct) - added keyboard ID for extended keyboard

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.33&tr2=1.34&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/11/16 14:46:02

Modified files:
	.              : vl.c 

Log message:
	more hack for CMOS interruption (enable linux /dev/rtc not to hang) - auto boot on cdrom if only device present

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.32&tr2=1.33&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/11/16 10:59:30

Modified files:
	.              : vl.c 

Log message:
	quick and dirty CMOS irq emulation (windows install uses it) - emm386 keyboard fix (need a better way...) - better serial emulation (windows install uses it) - LDT and TR caches init fix

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.31&tr2=1.32&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/11/11 08:36:08

Modified files:
	.              : vl.c 

Log message:
	hardware level IDE CD-ROM emulation - added second IDE interface for up to 4 IDE disks emulation - added -boot command to enable CD boot

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.28&tr2=1.29&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/11/04 18:35:21

Modified files:
	.              : vl.c 

Log message:
	a20 support - keyboard led fix

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.27&tr2=1.28&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/10/29 20:11:23

Modified files:
	.              : vl.c 

Log message:
	endianness and portability fixes

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.26&tr2=1.27&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/10/27 18:37:01

Modified files:
	.              : vl.c 

Log message:
	fixed idt/gdt relocation bug - added support for Redhat kernels

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.25&tr2=1.26&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/10/27 16:18:35

Modified files:
	.              : vl.c 

Log message:
	disabled signal hacks for softmmu version (qemu should be much more portable now...)

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.23&tr2=1.24&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/09/30 18:11:17

Modified files:
	.              : vl.c 

Log message:
	tun-fd option support for external tundev config (Rusty Russell)

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.20&tr2=1.21&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/09/30 17:40:47

Modified files:
	.              : vl.c 

Log message:
	buffer overflow fix - handle case where stdin is closed (Rusty Russell)

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.19&tr2=1.20&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/09/30 17:07:02

Modified files:
	.              : vl.c 

Log message:
	simplified invocation - added automatic IDE disk geometry guessing to reuse old disk images directly

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.18&tr2=1.19&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/09/16 17:46:04

Modified files:
	.              : vl.c 

Log message:
	glibc 2.3.x fix

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.17&tr2=1.18&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/07/27 18:19:01

Modified files:
	.              : vl.c 

Log message:
	refresh clock dummy emulation (netbsd boot fix)

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.14&tr2=1.15&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/07/26 14:11:40

Modified files:
	.              : vl.c 

Log message:
	keyboard emulation - accepts to boot with Bochs BIOS and LGPL'ed VGA BIOS

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.13&tr2=1.14&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/07/04 10:38:25

Modified files:
	.              : vl.c 

Log message:
	added IDE WIN_READ_NATIVE_MAX command (2.5.xx fix) - added support for proper system shutdown

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.10&tr2=1.11&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/07/01 11:07:57

Modified files:
	.              : vl.c 

Log message:
	fixed date storage in CMOS

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.8&tr2=1.9&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/06/30 19:36:21

Modified files:
	.              : vl.c 

Log message:
	added PIC debug

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.7&tr2=1.8&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/06/30 09:06:40

Modified files:
	.              : vl.c 

Log message:
	added IDE mult support - reduced irq latency (IDE should have good performances now)

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.6&tr2=1.7&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/06/27 08:01:39

Modified files:
	.              : vl.c 

Log message:
	more precise timer emulation - fixed NE2000 probe problems - added VLTMPDIR support

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.3&tr2=1.4&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/06/25 12:20:35

Modified files:
	.              : vl.c 

Log message:
	VL license of the day is MIT/BSD

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.2&tr2=1.3&r1=text&r2=text

[Qemu-devel] qemu vl.c

[Fabrice Bellard]

CVSROOT:	/cvsroot/qemu
Module name:	qemu
Branch: 	
Changes by:	Fabrice Bellard <fabrice.bellard@free.fr>	03/06/24 20:07:40

Modified files:
	.              : vl.c 

Log message:
	added NE2000 emulation

CVSWeb URLs:
http://savannah.gnu.org/cgi-bin/viewcvs/qemu/qemu/vl.c.diff?tr1=1.1&tr2=1.2&r1=text&r2=text