From mboxrd@z Thu Jan  1 00:00:00 1970
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
Date: Tue, 25 Mar 2014 11:00:52 +0100
Subject: [U-Boot] [PATCH] build:arm: Remove setting of CROSS_COMPILE
 environment variable
In-Reply-To: <20140325095545.5220d6a2@amdc2363>
References: <20140318162248.GC16360@bill-the-cat>
	<20140318230939.62536707@jawa>
	<20140319115535.7A59.AA925319@jp.panasonic.com>
	<20140325095545.5220d6a2@amdc2363>
Message-ID: <E1WSOA9-0008RY-CK@janus>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Lukasz,

On Tue, 25 Mar 2014 09:55:45 +0100, Lukasz Majewski
<l.majewski@samsung.com> wrote:

> Hi Albert,
> 
> > Hi Lukasz, Tom,
> > 
> > 
> > > Hi Tom,
> > > 
> > > > On Tue, Mar 18, 2014 at 04:46:48PM +0100, Lukasz Majewski wrote:
> > > > 
> > > > > After Kbuild introduction, the CROSS_COMPILE environment
> > > > > variable has been set to some default value (prefix arm-linux-).
> > > > 
> > > > Note that this is quite a long-standing thing.  Perhaps we're now
> > > > not detecting a native build when we used to?
> > > 
> > > My point is that we are relying on assigning default prefix (i.e.
> > > arm-linux-)
> > > 
> > > For example OSELAS toolchains can have an arbitrary prefix
> > > (e.g. arm-linux-gnueabi-).
> > > 
> > > When I cross compile I set explicitly "CROSS_COMPILE=<toolchain>
> > > make" and it works as it should (with or without this patch). Such
> > > approach seems natural for me.
> > >
> > > However, I don't know what is the exact rationale for seting this
> > > arm-linux- prefix to CROSS_COMPILE.
> > > I can only guess, that it is connected with situation when one just
> > > type "make" on x86_64 host and expect u-boot to be CROSS_COMPILE'd
> > > out of the box.
> > 
> > Agree.
> > It is useful only for people using "arm-linux-gcc" on x86 host.
> > I usually use "arm-linux-gnueabi-gcc". Someone else may be using other
> > prefixes.
> > 
> > I think there is no rationale more sophisticated than that it just has
> > been there since long time before.
> > 
> > So, I agree with this patch except a little misleading
> > commit description I commented below.
> > 
> > Acked-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> > 
> 
> Albert, could you take this patch for your arm repository?

I can. How would you like me to rephrase the commit message?

Amicalement,
-- 
Albert.