From: rmk+kernel@arm.linux.org.uk (Russell King)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] ARM: SWP emulation: always enable when SMP is enabled
Date: Fri, 04 Jul 2014 20:52:07 +0100 [thread overview]
Message-ID: <E1X39Wh-0000lq-KV@rmk-PC.arm.linux.org.uk> (raw)
In-Reply-To: <20140704195134.GJ21766@n2100.arm.linux.org.uk>
SWP is deprecated in ARMv6 and ARMv7 CPUs, but more importantly, when
running on a SMP system, SWP doesn't guarantee atomicity. This means
it can't really be used (by userspace) for locking purposes in a SMP
environment.
Currently, many configurations leave the SWP emulation disabled, which
means we never know if userspace executes this instruction on ARMv7
hardware. Rectify this by enabling SWP emulation for ARMv7 with SMP
(where we can trap the instruction.)
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
arch/arm/mm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/mm/Kconfig b/arch/arm/mm/Kconfig
index c348eaee7ee2..c78c7db6aa83 100644
--- a/arch/arm/mm/Kconfig
+++ b/arch/arm/mm/Kconfig
@@ -669,7 +669,7 @@ config ARM_VIRT_EXT
details.
config SWP_EMULATE
- bool "Emulate SWP/SWPB instructions"
+ bool "Emulate SWP/SWPB instructions" if !SMP
depends on CPU_V7
default y if SMP
select HAVE_PROC_CPU if PROC_FS
--
1.8.3.1
next prev parent reply other threads:[~2014-07-04 19:52 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 19:51 [PATCH 0/4] ABI updates Russell King - ARM Linux
2014-07-04 19:52 ` [PATCH 1/4] ARM: alignment: save last kernel aligned fault location Russell King
2014-07-04 19:52 ` Russell King [this message]
2014-07-04 19:52 ` [PATCH 3/4] ARM: SWP emulation: only initialise on ARMv7 CPUs Russell King
2014-07-04 19:52 ` [PATCH 4/4] ARM: hwcap: disable HWCAP_SWP if the CPU advertises it has exclusives Russell King
2014-07-04 20:11 ` Arnd Bergmann
2014-07-04 20:51 ` Russell King - ARM Linux
2014-07-04 20:58 ` Arnd Bergmann
2014-07-04 21:48 ` Russell King - ARM Linux
2014-07-05 18:46 ` Arnd Bergmann
2014-07-07 11:02 ` Catalin Marinas
2014-07-07 11:17 ` Russell King - ARM Linux
2014-07-07 12:05 ` Catalin Marinas
2014-07-07 13:13 ` Russell King - ARM Linux
2014-07-07 13:46 ` Catalin Marinas
2014-07-07 15:31 ` Russell King - ARM Linux
2014-07-07 15:59 ` Catalin Marinas
2014-07-07 16:31 ` Russell King - ARM Linux
2014-07-07 17:50 ` Catalin Marinas
2014-07-07 9:34 ` Will Deacon
2014-07-07 9:41 ` Russell King - ARM Linux
2014-07-07 9:51 ` Will Deacon
2014-07-04 20:12 ` [PATCH 0/4] ABI updates Arnd Bergmann
2014-07-07 11:19 ` Tony Lindgren
2014-07-07 11:23 ` Russell King - ARM Linux
2014-07-07 13:23 ` Tony Lindgren
2014-07-07 13:52 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1X39Wh-0000lq-KV@rmk-PC.arm.linux.org.uk \
--to=rmk+kernel@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.