From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756458AbcJYTeG (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Oct 2016 15:34:06 -0400
Received: from quechua.inka.de ([193.197.184.2]:48830 "EHLO mail.inka.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750806AbcJYTeD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Oct 2016 15:34:03 -0400
X-Greylist: delayed 911 seconds by postgrey-1.27 at vger.kernel.org; Tue, 25 Oct 2016 15:34:03 EDT
To: linux-kernel@vger.kernel.org
Subject: Re: [RFC] shutdown machine when li-ion battery goes below 3V
References: <20161024212250.GA31336@amd>
Organization: 
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
From: Olaf Titz <olaf@bigred.inka.de>
Date: Tue, 25 Oct 2016 21:18:46 +0200
Message-ID: <E1bz7FE-0007t1-Tp@bigred.inka.de>
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +	res = bq27xxx_battery_voltage(di, &val);
> +	if (res)
> +		return res;
> +
> +	mV = val.intval / 1000;

Reading that code I stumbled over the comment in
bq27xxx_battery_voltage saying that it returns millivolts. The code
here, the code in bq27xxx_battery_voltage and power_supply.h all
indicate that it in fact returns microvolts. Please double-check and
fix, as it stands now the code looks inconsistent (but not knowing that
device at all I don't feel fit to submit a fix).

regards, Olaf