All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+kernel@armlinux.org.uk>
To: linux-mips@linux-mips.org, linux-nfs@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	target-devel@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH 4.10-rc3 05/13] net: bgmac: fix build errors when linux/phy*.h is removed from net/dsa.h
Date: Tue, 31 Jan 2017 19:18:48 +0000	[thread overview]
Message-ID: <E1cYdx2-0000WP-Ot@rmk-PC.armlinux.org.uk> (raw)
In-Reply-To: <20170131191704.GA8281@n2100.armlinux.org.uk>

drivers/net/ethernet/broadcom/bgmac.c:1015:17: error: dereferencing pointer to incomplete type 'struct mii_bus'
drivers/net/ethernet/broadcom/bgmac.c:1185:2: error: implicit declaration of function 'phy_start' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1198:2: error: implicit declaration of function 'phy_stop' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1239:9: error: implicit declaration of function 'phy_mii_ioctl' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1389:28: error: 'phy_ethtool_get_link_ksettings' undeclared here (not in a function)
drivers/net/ethernet/broadcom/bgmac.c:1390:28: error: 'phy_ethtool_set_link_ksettings' undeclared here (not in a function)
drivers/net/ethernet/broadcom/bgmac.c:1403:13: error: dereferencing pointer to incomplete type 'struct phy_device'
drivers/net/ethernet/broadcom/bgmac.c:1417:3: error: implicit declaration of function 'phy_print_status' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1424:26: error: storage size of 'fphy_status' isn't known
drivers/net/ethernet/broadcom/bgmac.c:1424:9: error: variable 'fphy_status' has initializer but incomplete type
drivers/net/ethernet/broadcom/bgmac.c:1425:11: warning: excess elements in struct initializer
drivers/net/ethernet/broadcom/bgmac.c:1425:3: error: unknown field 'link' specified in initializer
drivers/net/ethernet/broadcom/bgmac.c:1426:12: note: in expansion of macro 'SPEED_1000'
drivers/net/ethernet/broadcom/bgmac.c:1426:3: error: unknown field 'speed' specified in initializer
drivers/net/ethernet/broadcom/bgmac.c:1427:13: note: in expansion of macro 'DUPLEX_FULL'
drivers/net/ethernet/broadcom/bgmac.c:1427:3: error: unknown field 'duplex' specified in initializer
drivers/net/ethernet/broadcom/bgmac.c:1432:12: error: implicit declaration of function 'fixed_phy_register' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1432:31: error: 'PHY_POLL' undeclared (first use in this function)
drivers/net/ethernet/broadcom/bgmac.c:1438:8: error: implicit declaration of function 'phy_connect_direct' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1439:6: error: 'PHY_INTERFACE_MODE_MII' undeclared (first use in this function)
drivers/net/ethernet/broadcom/bgmac.c:1521:2: error: implicit declaration of function 'phy_disconnect' [-Werror=implicit-function-declaration]
drivers/net/ethernet/broadcom/bgmac.c:1541:15: error: expected declaration specifiers or '...' before string constant

Add linux/phy.h to bgmac.c

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 drivers/net/ethernet/broadcom/bgmac.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/broadcom/bgmac.c b/drivers/net/ethernet/broadcom/bgmac.c
index 0e066dc6b8cc..58a2bd3c0458 100644
--- a/drivers/net/ethernet/broadcom/bgmac.c
+++ b/drivers/net/ethernet/broadcom/bgmac.c
@@ -12,6 +12,8 @@
 #include <linux/bcma/bcma.h>
 #include <linux/etherdevice.h>
 #include <linux/bcm47xx_nvram.h>
+#include <linux/phy.h>
+#include <linux/phy_fixed.h>
 #include "bgmac.h"
 
 static bool bgmac_wait_value(struct bgmac *bgmac, u16 reg, u32 mask,
-- 
2.7.4

  parent reply	other threads:[~2017-01-31 19:22 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18  0:14 [PATCH RFC] net: dsa: remove unnecessary phy.h include Russell King - ARM Linux
2017-01-18  1:11 ` Vivien Didelot
2017-01-18  1:13 ` Florian Fainelli
2017-01-18 21:37 ` David Miller
2017-01-18 21:46   ` Russell King - ARM Linux
2017-01-18 21:48     ` David Miller
2017-01-18 21:47   ` David Miller
2017-01-31 19:17 ` [PATCH 4.10-rc3 00/13] " Russell King - ARM Linux
2017-01-31 19:17   ` Russell King - ARM Linux
2017-01-31 19:17   ` Russell King - ARM Linux
2017-01-31 19:18   ` [PATCH 4.10-rc3 01/13] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
2017-01-31 19:48     ` Anna Schumaker
2017-01-31 19:48       ` Anna Schumaker
2017-01-31 19:48       ` Anna Schumaker
2017-01-31 19:48       ` Anna Schumaker
2017-01-31 19:18   ` [PATCH 4.10-rc3 02/13] net: cgroups: " Russell King
2017-01-31 19:18   ` [PATCH 4.10-rc3 03/13] net: macb: " Russell King
2017-02-01  9:40     ` Nicolas Ferre
2017-02-01  9:40       ` Nicolas Ferre
2017-02-01  9:40       ` Nicolas Ferre
2017-02-01  9:40       ` Nicolas Ferre
2017-01-31 19:18   ` [PATCH 4.10-rc3 04/13] net: lan78xx: " Russell King
2017-01-31 19:18   ` Russell King [this message]
2017-02-01  9:55     ` [PATCH 4.10-rc3 05/13] net: bgmac: " Rafał Miłecki
2017-01-31 19:18   ` [PATCH 4.10-rc3 06/13] net: fman: " Russell King
2017-01-31 19:18   ` [PATCH 4.10-rc3 07/13] net: mvneta: " Russell King
2017-02-01 10:27     ` Thomas Petazzoni
2017-02-01 10:27       ` Thomas Petazzoni
2017-01-31 19:19   ` [PATCH 4.10-rc3 08/13] net: emac: " Russell King
2017-01-31 20:15     ` Timur Tabi
2017-01-31 20:15       ` Timur Tabi
2017-01-31 19:19   ` [PATCH 4.10-rc3 09/13] iscsi: " Russell King
2017-01-31 19:32     ` Bart Van Assche
2017-01-31 19:32       ` Bart Van Assche
2017-01-31 19:32       ` Bart Van Assche
2017-01-31 19:32       ` Bart Van Assche
2017-01-31 19:19   ` [PATCH 4.10-rc3 10/13] MIPS: Octeon: Remove unnecessary MODULE_*() Russell King
2017-01-31 19:19   ` [PATCH 4.10-rc3 11/13] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h Russell King
2017-02-01 19:07     ` Felix Manlunas
2017-02-01 19:07       ` Felix Manlunas
2017-02-01 19:07       ` Felix Manlunas
2017-02-01 19:07       ` Felix Manlunas
2017-01-31 19:19   ` [PATCH 4.10-rc3 12/13] net: ath5k: " Russell King
2017-02-01  5:34     ` Kalle Valo
2017-01-31 19:19   ` [PATCH 4.10-rc3 13/13] net: dsa: remove unnecessary phy*.h includes Russell King
2017-02-01  2:42   ` [PATCH 4.10-rc3 00/13] net: dsa: remove unnecessary phy.h include Florian Fainelli
2017-02-01  2:42     ` Florian Fainelli
2017-02-01  2:42     ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1cYdx2-0000WP-Ot@rmk-PC.armlinux.org.uk \
    --to=rmk+kernel@armlinux.org.uk \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.