All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V1] regulator: core: Fix voltage change propagations to supply regulators
@ 2017-05-25 10:03 Tirupathi Reddy
  2017-06-05 10:36 ` Tirupathi Reddy T
  2017-06-28 19:49   ` Mark Brown
  0 siblings, 2 replies; 5+ messages in thread
From: Tirupathi Reddy @ 2017-05-25 10:03 UTC (permalink / raw)
  To: broonie, lgirdwood; +Cc: linux-kernel, linux-arm-msm, Tirupathi Reddy

Some regulators support get_voltage and some support get_voltage_sel
operations. Do voltage change propagation only when the current
regulator has a minimum dropout voltage specified or if the current
regulator lacks both get_voltage and get_voltage_sel operations.

Signed-off-by: Tirupathi Reddy <tirupath@codeaurora.org>
---
 drivers/regulator/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index c0d9ae8..9fecbd4 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2938,7 +2938,8 @@ static int regulator_set_voltage_unlocked(struct regulator *regulator,
 	if (rdev->supply &&
 	    regulator_ops_is_valid(rdev->supply->rdev,
 				   REGULATOR_CHANGE_VOLTAGE) &&
-	    (rdev->desc->min_dropout_uV || !rdev->desc->ops->get_voltage)) {
+	    (rdev->desc->min_dropout_uV || !(rdev->desc->ops->get_voltage ||
+					   rdev->desc->ops->get_voltage_sel))) {
 		int current_supply_uV;
 		int selector;
 
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH V1] regulator: core: Fix voltage change propagations to supply regulators
  2017-05-25 10:03 [PATCH V1] regulator: core: Fix voltage change propagations to supply regulators Tirupathi Reddy
@ 2017-06-05 10:36 ` Tirupathi Reddy T
  2017-06-06 15:41   ` Mark Brown
  2017-06-28 19:49   ` Mark Brown
  1 sibling, 1 reply; 5+ messages in thread
From: Tirupathi Reddy T @ 2017-06-05 10:36 UTC (permalink / raw)
  To: broonie, lgirdwood; +Cc: linux-kernel, linux-arm-msm

Mark,

Could you please take a look and provide any feedback.

Thanks
Tirupathi Reddy

On 5/25/2017 3:33 PM, Tirupathi Reddy wrote:
> Some regulators support get_voltage and some support get_voltage_sel
> operations. Do voltage change propagation only when the current
> regulator has a minimum dropout voltage specified or if the current
> regulator lacks both get_voltage and get_voltage_sel operations.
>
> Signed-off-by: Tirupathi Reddy <tirupath@codeaurora.org>
> ---
>   drivers/regulator/core.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index c0d9ae8..9fecbd4 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -2938,7 +2938,8 @@ static int regulator_set_voltage_unlocked(struct regulator *regulator,
>   	if (rdev->supply &&
>   	    regulator_ops_is_valid(rdev->supply->rdev,
>   				   REGULATOR_CHANGE_VOLTAGE) &&
> -	    (rdev->desc->min_dropout_uV || !rdev->desc->ops->get_voltage)) {
> +	    (rdev->desc->min_dropout_uV || !(rdev->desc->ops->get_voltage ||
> +					   rdev->desc->ops->get_voltage_sel))) {
>   		int current_supply_uV;
>   		int selector;
>   

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH V1] regulator: core: Fix voltage change propagations to supply regulators
  2017-06-05 10:36 ` Tirupathi Reddy T
@ 2017-06-06 15:41   ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2017-06-06 15:41 UTC (permalink / raw)
  To: Tirupathi Reddy T; +Cc: lgirdwood, linux-kernel, linux-arm-msm

[-- Attachment #1: Type: text/plain, Size: 1101 bytes --]

On Mon, Jun 05, 2017 at 04:06:12PM +0530, Tirupathi Reddy T wrote:
> Mark,
> 
> Could you please take a look and provide any feedback.

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

Please don't send content free pings and please allow a reasonable time
for review.  People get busy, go on holiday, attend conferences and so 
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review.  If there have been
review comments then people may be waiting for those to be addressed.

Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, though there are some other maintainers who like them - if in
doubt look at how patches for the subsystem are normally handled.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Applied "regulator: core: Fix voltage change propagations to supply regulators" to the regulator tree
  2017-05-25 10:03 [PATCH V1] regulator: core: Fix voltage change propagations to supply regulators Tirupathi Reddy
@ 2017-06-28 19:49   ` Mark Brown
  2017-06-28 19:49   ` Mark Brown
  1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2017-06-28 19:49 UTC (permalink / raw)
  To: Tirupathi Reddy; +Cc: Mark Brown

The patch

   regulator: core: Fix voltage change propagations to supply regulators

has been applied to the regulator tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 2c2874b191d54fbf9216524e629558eee89e1d20 Mon Sep 17 00:00:00 2001
From: Tirupathi Reddy <tirupath@codeaurora.org>
Date: Thu, 25 May 2017 15:33:17 +0530
Subject: [PATCH] regulator: core: Fix voltage change propagations to supply
 regulators

Some regulators support get_voltage() and some support get_voltage_sel()
operations but currently we only propagate changes if the regulator has
a get_voltage() operation.  Also do this if we've got get_voltage_sel()

[Rewite commit message for clarity -- broonie]

Signed-off-by: Tirupathi Reddy <tirupath@codeaurora.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index c0d9ae8d0860..9fecbd4e3546 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2938,7 +2938,8 @@ static int regulator_set_voltage_unlocked(struct regulator *regulator,
 	if (rdev->supply &&
 	    regulator_ops_is_valid(rdev->supply->rdev,
 				   REGULATOR_CHANGE_VOLTAGE) &&
-	    (rdev->desc->min_dropout_uV || !rdev->desc->ops->get_voltage)) {
+	    (rdev->desc->min_dropout_uV || !(rdev->desc->ops->get_voltage ||
+					   rdev->desc->ops->get_voltage_sel))) {
 		int current_supply_uV;
 		int selector;
 
-- 
2.13.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Applied "regulator: core: Fix voltage change propagations to supply regulators" to the regulator tree
@ 2017-06-28 19:49   ` Mark Brown
  0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2017-06-28 19:49 UTC (permalink / raw)
  To: Tirupathi Reddy
  Cc: Mark Brown, broonie, lgirdwood, linux-kernel, linux-arm-msm,
	linux-kernel

The patch

   regulator: core: Fix voltage change propagations to supply regulators

has been applied to the regulator tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 2c2874b191d54fbf9216524e629558eee89e1d20 Mon Sep 17 00:00:00 2001
From: Tirupathi Reddy <tirupath@codeaurora.org>
Date: Thu, 25 May 2017 15:33:17 +0530
Subject: [PATCH] regulator: core: Fix voltage change propagations to supply
 regulators

Some regulators support get_voltage() and some support get_voltage_sel()
operations but currently we only propagate changes if the regulator has
a get_voltage() operation.  Also do this if we've got get_voltage_sel()

[Rewite commit message for clarity -- broonie]

Signed-off-by: Tirupathi Reddy <tirupath@codeaurora.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/regulator/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index c0d9ae8d0860..9fecbd4e3546 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2938,7 +2938,8 @@ static int regulator_set_voltage_unlocked(struct regulator *regulator,
 	if (rdev->supply &&
 	    regulator_ops_is_valid(rdev->supply->rdev,
 				   REGULATOR_CHANGE_VOLTAGE) &&
-	    (rdev->desc->min_dropout_uV || !rdev->desc->ops->get_voltage)) {
+	    (rdev->desc->min_dropout_uV || !(rdev->desc->ops->get_voltage ||
+					   rdev->desc->ops->get_voltage_sel))) {
 		int current_supply_uV;
 		int selector;
 
-- 
2.13.2

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-06-28 19:49 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-25 10:03 [PATCH V1] regulator: core: Fix voltage change propagations to supply regulators Tirupathi Reddy
2017-06-05 10:36 ` Tirupathi Reddy T
2017-06-06 15:41   ` Mark Brown
2017-06-28 19:49 ` Applied "regulator: core: Fix voltage change propagations to supply regulators" to the regulator tree Mark Brown
2017-06-28 19:49   ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.