From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755856AbeCSP1q (ORCPT ); Mon, 19 Mar 2018 11:27:46 -0400 Received: from h1.radempa.de ([176.9.142.194]:39190 "EHLO mail.cosmopool.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755819AbeCSP1n (ORCPT ); Mon, 19 Mar 2018 11:27:43 -0400 From: Harald Geyer To: Maxime Ripard cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andre Przywara , Icenowy Zheng , info@olimex.com Subject: Re: [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop In-reply-to: <20180318202251.5gpv6sblfr4edxmj@flea> References: <20180315162510.11669-1-harald@ccbib.org> <20180315162510.11669-6-harald@ccbib.org> <20180318202251.5gpv6sblfr4edxmj@flea> Comments: In-reply-to Maxime Ripard message dated "Sun, 18 Mar 2018 21:22:51 +0100." MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1667.1521473255.1@stardust.g4.wien.funkfeuer.at> Date: Mon, 19 Mar 2018 16:27:36 +0100 Message-Id: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Maxime Ripard writes: > On Thu, Mar 15, 2018 at 04:25:10PM +0000, Harald Geyer wrote: > > + leds { > > + compatible = "gpio-leds"; > > + > > + capslock { > > + label = "leds:green:capslock"; > > The first part is supposed to be the name of the boards. I did sed > s/leds/teres-i/, and applied, I'm not sure what good this convention would do, if anything it seems to make it harder to write portable scripts, but in the end I don't care. > together with all the patches but the > PWM (so I had to drop the backlight node as well). > > Please coordinate with Andre about who should send the PWM support. Seems the patch got broken because only the backlight node but not the pwm node was removed. Anyway, since Andre has already sent an updated version of his series, maybe just revert the broken patch, merge his series and then apply the original teres-i patch again? I'm going to test his patches soon, but I don't expect any problems. Thanks, Harald From mboxrd@z Thu Jan 1 00:00:00 1970 From: harald@ccbib.org (Harald Geyer) Date: Mon, 19 Mar 2018 16:27:36 +0100 Subject: [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop In-Reply-To: <20180318202251.5gpv6sblfr4edxmj@flea> References: <20180315162510.11669-1-harald@ccbib.org> <20180315162510.11669-6-harald@ccbib.org> <20180318202251.5gpv6sblfr4edxmj@flea> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Maxime Ripard writes: > On Thu, Mar 15, 2018 at 04:25:10PM +0000, Harald Geyer wrote: > > + leds { > > + compatible = "gpio-leds"; > > + > > + capslock { > > + label = "leds:green:capslock"; > > The first part is supposed to be the name of the boards. I did sed > s/leds/teres-i/, and applied, I'm not sure what good this convention would do, if anything it seems to make it harder to write portable scripts, but in the end I don't care. > together with all the patches but the > PWM (so I had to drop the backlight node as well). > > Please coordinate with Andre about who should send the PWM support. Seems the patch got broken because only the backlight node but not the pwm node was removed. Anyway, since Andre has already sent an updated version of his series, maybe just revert the broken patch, merge his series and then apply the original teres-i patch again? I'm going to test his patches soon, but I don't expect any problems. Thanks, Harald