[patch 1/2] xen/arm: Free p2m entry if fail to add it to RB tree

[patch 1/2] xen/arm: Free p2m entry if fail to add it to RB tree

[Hillf Danton]

[-- Attachment #1.1: Type: text/plain, Size: 580 bytes --]

Release the newly allocated p2m entry if we detect a duplicate in the RB tree.

Cc: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Hillf Danton <hdanton@sina.com>
---

--- a/arch/arm/xen/p2m.c	2019-04-30 12:32:05.363768200 +0800
+++ b/arch/arm/xen/p2m.c	2019-04-30 12:41:29.774041800 +0800
@@ -156,6 +156,7 @@ bool __set_phys_to_machine_multi(unsigne
	rc = xen_add_phys_to_mach_entry(p2m_entry);
	if (rc < 0) {
		write_unlock_irqrestore(&p2m_lock, irqflags);
+		kfree(p2m_entry);
		return false;
	}
	write_unlock_irqrestore(&p2m_lock, irqflags);
--


[-- Attachment #1.2: Type: text/html, Size: 2719 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [patch 1/2] xen/arm: Free p2m entry if fail to add it to RB tree

[Hillf Danton]

[-- Attachment #1.1: Type: text/plain, Size: 580 bytes --]

Release the newly allocated p2m entry if we detect a duplicate in the RB tree.

Cc: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Hillf Danton <hdanton@sina.com>
---

--- a/arch/arm/xen/p2m.c	2019-04-30 12:32:05.363768200 +0800
+++ b/arch/arm/xen/p2m.c	2019-04-30 12:41:29.774041800 +0800
@@ -156,6 +156,7 @@ bool __set_phys_to_machine_multi(unsigne
	rc = xen_add_phys_to_mach_entry(p2m_entry);
	if (rc < 0) {
		write_unlock_irqrestore(&p2m_lock, irqflags);
+		kfree(p2m_entry);
		return false;
	}
	write_unlock_irqrestore(&p2m_lock, irqflags);
--


[-- Attachment #1.2: Type: text/html, Size: 2719 bytes --]

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [patch 1/2] xen/arm: Free p2m entry if fail to add it to RB tree

[Stefano Stabellini]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1006 bytes --]

Hi Hillf,

Thanks for the patch. Please send emails in plain text, no html. Refer
to Documentation/process/submitting-patches.rst.


On Tue, 30 Apr 2019, Hillf Danton wrote:
> Release the newly allocated p2m entry if we detect a duplicate in the RB tree.

Space damage aside due to html, the patch looks good.
  
 
> Cc: Stefano Stabellini <sstabellini@kernel.org>
> 
> Signed-off-by: Hillf Danton <hdanton@sina.com>
> 
> ---
> 
>  
> 
> --- a/arch/arm/xen/p2m.c 2019-04-30 12:32:05.363768200 +0800
> 
> +++ b/arch/arm/xen/p2m.c    2019-04-30 12:41:29.774041800 +0800
> 
> @@ -156,6 +156,7 @@ bool __set_phys_to_machine_multi(unsigne
> 
>        rc = xen_add_phys_to_mach_entry(p2m_entry);
> 
>        if (rc < 0) {
> 
>              write_unlock_irqrestore(&p2m_lock, irqflags);
> 
> +           kfree(p2m_entry);
> 
>              return false;
> 
>        }
> 
>        write_unlock_irqrestore(&p2m_lock, irqflags);
> 
> --
> 
>  
> 
> 
> 

[-- Attachment #2: Type: text/plain, Size: 157 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel