Re: [PATCH v2 1/7] iio: light: rpr0521 disable sensor -bugfix

["Koivunen, Mikko" <Mikko.Koivunen@fi.rohmeurope.com>]

On 8.4.2017 17:47, Jonathan Cameron wrote:
> On 07/04/17 13:07, Mikko Koivunen wrote:
>> Sensor was marked enabled on each call even if the call was for disabling
>> sensor.
>>
>> Signed-off-by: Mikko Koivunen <mikko.koivunen@fi.rohmeurope.com>
> What effect does this have on device operation?

Actually none with current code.
Because it's never called for disabling, not even in_poweroff(). This
could also be fixed by removing second parameter and hardcoding status
as _MODE_x_ENABLE.

> What I'm looking for is info on whether this wants to go to stable as
> it will cause the device not to work, or whether it is wasting power etc.
>
> Also useful to add a fixes tag as that makes it easy for stable maintainers
> to filter incoming patches for relevance to their trees.
>
> Will be looking for Acks from Daniel on all of these as he wrote the original
> and is still active.
>
> Jonathan
>> ---
>> Tested on LeMaker HiKey with AOSP7.1 kernel 4.4.
>>
>>  drivers/iio/light/rpr0521.c |   11 ++++++++---
>>  1 file changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/light/rpr0521.c b/drivers/iio/light/rpr0521.c
>> index 7de0f39..c15529b 100644
>> --- a/drivers/iio/light/rpr0521.c
>> +++ b/drivers/iio/light/rpr0521.c
>> @@ -197,8 +197,10 @@ static int rpr0521_als_enable(struct rpr0521_data *data, u8 status)
>>  	if (ret < 0)
>>  		return ret;
>>  
>> -	data->als_dev_en = true;
>> -
>> +	if (status & RPR0521_MODE_ALS_MASK)
>> +		data->als_dev_en = true;
>> +	else
>> +		data->als_dev_en = false;
>>  	return 0;
>>  }
>>  
>> @@ -212,7 +214,10 @@ static int rpr0521_pxs_enable(struct rpr0521_data *data, u8 status)
>>  	if (ret < 0)
>>  		return ret;
>>  
>> -	data->pxs_dev_en = true;
>> +	if (status & RPR0521_MODE_PXS_MASK)
>> +		data->pxs_dev_en = true;
>> +	else
>> +		data->pxs_dev_en = false;
>>  
>>  	return 0;
>>  }
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>