All of lore.kernel.org
 help / color / mirror / Atom feed
From: Premi, Sanjeev <premi@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Coding Style cleanup
Date: Tue, 20 Dec 2011 10:32:39 +0000	[thread overview]
Message-ID: <E28AAFD00EFAA646AE3DF9B89CD24A8909D2BB@DBDE01.ent.ti.com> (raw)
In-Reply-To: <20111219153642.5539D138EE40@gemini.denx.de>

> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de] 
> Sent: Monday, December 19, 2011 9:07 PM
> To: Premi, Sanjeev
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH] Coding Style cleanup
> 
> Dear "Premi, Sanjeev",
> 
> In message 
> <E28AAFD00EFAA646AE3DF9B89CD24A8909B469@DBDE01.ent.ti.com> you wrote:
> >
> > > @@ -563,6 +556,7 @@ extern unsigned long=20
> > > get_board_sys_clk(unsigned long dummy);
> > >  	"tftp $fdtaddr $tftppath/$fdtfile;"		=09
> > > 	\
> > >  	"bootm $loadaddr - $fdtaddr"
> > > =20
> > > +
> > >  #define CONFIG_RAMBOOTCOMMAND			=09
> > 
> > This appears to be a stray addition.
> 
> ...which appears to be added by your mailer.  I don;t see it in the
> patch.

I was referring to the extra line added by the "+" sign.

[quoting from original patch]
@@ -563,6 +556,7 @@ extern unsigned long get_board_sys_clk(unsigned long dummy);
 	"tftp $fdtaddr $tftppath/$fdtfile;"				\
 	"bootm $loadaddr - $fdtaddr"
 
+
 #define CONFIG_RAMBOOTCOMMAND						\
 	"setenv bootargs root=/dev/ram rw "				\
 	"console=$consoledev,$baudrate $othbootargs;"			\
[/quote]

~sanjeev

> 
> Best regards,
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> When the ax entered the forest, the trees said, "The handle is one of
> us!"                                               -- Turkish proverb
> 

  reply	other threads:[~2011-12-20 10:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-19 11:10 [U-Boot] [PATCH] Coding Style cleanup Wolfgang Denk
2011-12-19 15:17 ` Premi, Sanjeev
2011-12-19 15:36   ` Wolfgang Denk
2011-12-20 10:32     ` Premi, Sanjeev [this message]
2011-12-20 12:01       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E28AAFD00EFAA646AE3DF9B89CD24A8909D2BB@DBDE01.ent.ti.com \
    --to=premi@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.