From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41903 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PD0Pz-0007OK-Rc
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 15:51:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1PD0PJ-0007rM-W4
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 15:51:07 -0400
Received: from cantor.suse.de ([195.135.220.2]:40718 helo=mx1.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1PD0PJ-0007rH-OE
	for qemu-devel@nongnu.org; Mon, 01 Nov 2010 15:51:05 -0400
Subject: Re: [Qemu-devel] [PATCH 02/40] elf: Add notes implementation
Mime-Version: 1.0 (Apple Message framework v1081)
Content-Type: text/plain; charset=us-ascii
From: Alexander Graf <agraf@suse.de>
In-Reply-To: <4CCF0A13.1060202@mail.berlios.de>
Date: Mon, 1 Nov 2010 15:51:02 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <E2FC622E-64DE-48E9-99A2-47CA09D5298E@suse.de>
References: <1288623713-28062-1-git-send-email-agraf@suse.de>	<1288623713-28062-3-git-send-email-agraf@suse.de>
	<AANLkTiksFJ78Tid9MLHNyvxbKe4K3eBjgUf=1Lt8UkOK@mail.gmail.com>
	<4CCF0A13.1060202@mail.berlios.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel Developers <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>


On 01.11.2010, at 14:42, Stefan Weil wrote:

> Am 01.11.2010 19:29, schrieb Blue Swirl:
>> On Mon, Nov 1, 2010 at 3:01 PM, Alexander Graf<agraf@suse.de>  wrote:
>>  =20
>>> ---
>>>  hw/elf_ops.h |   61 =
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>>>  hw/loader.c  |    7 ++++++
>>>  hw/loader.h  |    3 ++
>>>  3 files changed, 70 insertions(+), 1 deletions(-)
>>>=20
>>> diff --git a/hw/elf_ops.h b/hw/elf_ops.h
>>> index 8b63dfc..645d058 100644
>>> --- a/hw/elf_ops.h
>>> +++ b/hw/elf_ops.h
>>> @@ -189,6 +189,44 @@ static int glue(load_symbols, SZ)(struct elfhdr =
*ehdr, int fd, int must_swab,
>>>     return -1;
>>>  }
>>>=20
>>> +static void glue(elf_read_notes, SZ)(uint8_t *data, int data_len,
>>> +                                     ElfHandlers *handlers, int =
must_swab)
>>> +{
>>> +    uint8_t *p =3D data;
>>> +
>>> +    while ((ulong)&p[3]<  (ulong)&data[data_len]) {
>>>    =20
>> Please use 'unsigned long'.
>>  =20
>=20
> Why is a type cast used here? I see no reason for it.

Pointers can't be compared, you have to cast them to values first.


Alex