All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philip Rakity <prakity@marvell.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Pierre Tardy <tardyp@gmail.com>,
	"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [RFC} sdhci.c set_ios -- disable global interrupts and Question on Power Management
Date: Mon, 14 Feb 2011 09:27:52 -0800	[thread overview]
Message-ID: <E318EA02-8219-41BD-81B0-90C91E84F2D8@marvell.com> (raw)
In-Reply-To: <20110214095528.GA30100@pengutronix.de>


I wonder if I can remove the locking (spin_lock).  The disable and enable irq should be enough.  

Thoughts ..

Philip

On Feb 14, 2011, at 1:55 AM, Wolfram Sang wrote:

> 
>> It looks like the mdelay are not in the fastpath, so why bother.
> 
> On embedded systems, we had audio streaming or CAN communication or similar
> running in parallel. Currently, those mdelays (there are a couple, sadly)
> produce significant latencies, e.g. when inserting/removing a card. The latter
> gets especially bad with BROKEN_CARD_DETECTION.
> 
> The proper solution is probably to check the locking and see if it can be made
> fine-granular, I'd assume?
> 
> Regards,
> 
>   Wolfram
> 
> -- 
> Pengutronix e.K.                           | Wolfram Sang                |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |


  reply	other threads:[~2011-02-14 17:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-13  5:39 [RFC} sdhci.c set_ios -- disable global interrupts and Question on Power Management Philip Rakity
2011-02-13 10:25 ` Pierre Tardy
2011-02-13 17:57   ` Philip Rakity
2011-02-14  5:50     ` Philip Rakity
2011-02-14  9:29       ` Pierre Tardy
2011-02-14  9:55         ` Wolfram Sang
2011-02-14 17:27           ` Philip Rakity [this message]
2011-02-15  9:13             ` Wolfram Sang
2011-02-14 18:34         ` Philip Rakity
2011-02-14 18:41           ` Tardy, Pierre
2011-02-14 20:17             ` Philip Rakity
2011-02-14 20:44             ` Philip Rakity
2011-02-15  8:39             ` Wolfram Sang
2011-02-15  3:09         ` Philip Rakity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E318EA02-8219-41BD-81B0-90C91E84F2D8@marvell.com \
    --to=prakity@marvell.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=tardyp@gmail.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.