From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C13DC433DB for ; Tue, 2 Feb 2021 10:54:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F6C964DAE for ; Tue, 2 Feb 2021 10:54:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230009AbhBBKxz (ORCPT ); Tue, 2 Feb 2021 05:53:55 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.52]:16871 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbhBBKxx (ORCPT ); Tue, 2 Feb 2021 05:53:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1612263061; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=PeVAVapo36NVgNgQvCQ5f98Kwxxzz3njm4fOPjoLqmE=; b=oKLvU7zwZSdbyQUiwxFp6lmK7NLKyoXencqyjn1aAOKJ2G4W+Bucc6maOZRFI3NG+5 XlB53vdqMo1HI6kJ6xn0hawqIaL8FEGuOsXJSoCXgFlLedPURgAaIRaZdHt7TPyF1ofD Iqj73iyYIAK9pbI3gQd8ehdbpkUvbuwr7hcM3WgIEkF4hY6WgyQbT1H8Gavg0UsY7LFM izGFNa2H8RkUG6VMrS0Gx9LtLrdaGrte6LiAYxU0CzKtXgnwlriGy3d91aWjfLDdIcTe sesW0ub4yP21vSSYXvUK7VwEAEOXqeItfIGR8fSb7kECmZWyEocWKmcQaOTYxXTL4la5 4D0Q== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7wpz8NMGH/PqwDOsGq4=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.16.0 DYNA|AUTH) with ESMTPSA id R01a2bx12AonLh7 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Tue, 2 Feb 2021 11:50:49 +0100 (CET) Subject: Re: BOG: commit 89c7cb1608ac3 ("of/device: Update dma_range_map only when dev has valid dma-ranges") seems to break Pinephone display or LCDC Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: text/plain; charset=utf-8 From: "H. Nikolaus Schaller" In-Reply-To: Date: Tue, 2 Feb 2021 11:50:48 +0100 Cc: Robin Murphy , Yong Wu , Rob Herring , Frank Rowand , Linux Kernel Mailing List , linux-arm-kernel , Discussions about the Letux Kernel Content-Transfer-Encoding: quoted-printable Message-Id: References: <81FE44A3-38C8-4B78-BB77-C09B4FC80B0A@goldelico.com> To: Paul Kocialkowski X-Mailer: Apple Mail (2.3124) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, > Am 02.02.2021 um 10:56 schrieb Paul Kocialkowski = : >=20 > Hi Nikolaus, >=20 > On Tue 02 Feb 21, 10:18, H. Nikolaus Schaller wrote: >> Hi, >> since v5.11-rc6 my Pinephone display shows some moir=C3=A9 pattern. >>=20 >> I did a bisect between v5.11-rc5 and v5.11-rc6 and it told me that >> the commit mentioned in the subject is the reason. >>=20 >> Reverting it makes the display work again and re-reverting fail = again. >>=20 >> IMHO it seems as if the display DMA of the pinephone (allwinner = suni-a54) >> got influenced and stopped to scan the framebuffer. >>=20 >> The only dma-ranges I could find are defined here: >>=20 >> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi >>=20 >> dma-ranges =3D <0x00000000 0x40000000 0xc0000000>; >>=20 >> but I can't tell if they are "valid" or not. >>=20 >> Any insights are welcome. And please direct to the right = people/mailing lists >> if they are missing. >=20 > This may not be strictly the same thing, but is this patch in your = tree: > = https://patchwork.kernel.org/project/linux-arm-kernel/patch/20210115175831= .1184260-2-paul.kocialkowski@bootlin.com/ >=20 > If not, it's worth a try to add it. No, it hasn't arrived in v5.11-rc6 (or linux-next) yet. But it fixes the issue. great and many thanks, Nikolaus > If it is, it's worth doing a revert. >=20 > My understanding is like DE2 does not need a particular DMA range and = has DRAM > starting at 0x40000000 (just like the CPU) but it will map DRAM in a = loop > before and after this address. >=20 > I suspect the issue shows because the pinephone has 2 GiB RAM while = for other > boards with < 2 GiB RAM, removing 0x40000000 to the DMA addresses = still points > to the same location. So IMO the MBUS dma-ranges shouldn't apply to = DE2. > I think this is already the case in dt, but the mbus driver may add it = if you > don't have that patch. >=20 > I think I have a few A64 boards around, but probably not with 2 GiB = RAM. > If adding the patch doesn't help, I'll try to make a few test. >=20 > Cheers! >=20 > Paul >=20 > --=20 > Paul Kocialkowski, Bootlin > Embedded Linux and kernel engineering > https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8F88C433DB for ; Tue, 2 Feb 2021 10:52:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EFC564DAE for ; Tue, 2 Feb 2021 10:52:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EFC564DAE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goldelico.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:References:Message-Id:Date:In-Reply-To:From: Mime-Version:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bDhhAEm0bGsoWHIYggT33rz58ycKxUh8/sbxWa9GX0U=; b=2OqgZ8s4GzBdZQPkpwlzOP9ut Rpn6T6ItSboQHFFwMorJ01vgwPaPewFdIbfJjs0JSWuG4OuO7PQKmRzfe61b9qao9MZM68qOePgEB cUSCrwbO6Rj0is4en9y2P0qOqzNSYx8PuP9G7FTjRGwWghZn1Kz8kLE2pYU1fiHl9nraFOL8NZaSB bdmVE20okUE2F/2/JoDmCtEugxsAM0ZZKQoJWRIoOywyosfT6P8F/q5ZGo/D/l2E4q6+VgUE0PQhU 2fpbUi0VmRTvq+jrQxs/UYR4PTD0GD+DrbDk8NU9UYuW31dzr75ORk2MYUqbMuTrkjUN0U5xSKpfc t8StsaZbw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6tGx-0001Es-Kx; Tue, 02 Feb 2021 10:51:03 +0000 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.53]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6tGu-0001Da-FQ for linux-arm-kernel@lists.infradead.org; Tue, 02 Feb 2021 10:51:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1612263058; s=strato-dkim-0002; d=goldelico.com; h=To:References:Message-Id:Cc:Date:In-Reply-To:From:Subject:Cc:Date: From:Subject:Sender; bh=PeVAVapo36NVgNgQvCQ5f98Kwxxzz3njm4fOPjoLqmE=; b=qZ511A1Y+7bFSTVTmZzgkWBPBHvWZDsUGihuBBPHK3c1G6+I+M02qAqKwXNzJ5qrvS UzhohIQOjwYHftnRVfdwipXDnYgMekeIl9gTZTaZZIb2vM9PiiyLurObzwR1Syy/3TtZ dF1wZhQFSCZb4jk8lEMvDO9B/cl4QlPItRWY8C1GVgCqpBeHo27vISs5ul/YiLgHJ1bl Bk8QGHkc3oHHRxM1iPzbah4rjlKM33O4HTn5nOaSwferSXBEKQChjGBW7jZy6v+ZkJiK Uq70xodaZhu+FGixQzaDlG7PDaUOUpnaYx052iKQrLD7+Sko0epDIGoFbM28YgUHXPme ydAA== X-RZG-AUTH: ":JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj7wpz8NMGH/PqwDOsGq4=" X-RZG-CLASS-ID: mo00 Received: from imac.fritz.box by smtp.strato.de (RZmta 47.16.0 DYNA|AUTH) with ESMTPSA id R01a2bx12AonLh7 (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Tue, 2 Feb 2021 11:50:49 +0100 (CET) Subject: Re: BOG: commit 89c7cb1608ac3 ("of/device: Update dma_range_map only when dev has valid dma-ranges") seems to break Pinephone display or LCDC Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: "H. Nikolaus Schaller" In-Reply-To: Date: Tue, 2 Feb 2021 11:50:48 +0100 Message-Id: References: <81FE44A3-38C8-4B78-BB77-C09B4FC80B0A@goldelico.com> To: Paul Kocialkowski X-Mailer: Apple Mail (2.3124) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210202_055100_737560_BED031C5 X-CRM114-Status: GOOD ( 24.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Frank Rowand , Linux Kernel Mailing List , Yong Wu , Discussions about the Letux Kernel , Robin Murphy , linux-arm-kernel Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgUGF1bCwKCj4gQW0gMDIuMDIuMjAyMSB1bSAxMDo1NiBzY2hyaWViIFBhdWwgS29jaWFsa293 c2tpIDxwYXVsLmtvY2lhbGtvd3NraUBib290bGluLmNvbT46Cj4gCj4gSGkgTmlrb2xhdXMsCj4g Cj4gT24gVHVlIDAyIEZlYiAyMSwgMTA6MTgsIEguIE5pa29sYXVzIFNjaGFsbGVyIHdyb3RlOgo+ PiBIaSwKPj4gc2luY2UgdjUuMTEtcmM2IG15IFBpbmVwaG9uZSBkaXNwbGF5IHNob3dzIHNvbWUg bW9pcsOpIHBhdHRlcm4uCj4+IAo+PiBJIGRpZCBhIGJpc2VjdCBiZXR3ZWVuIHY1LjExLXJjNSBh bmQgdjUuMTEtcmM2IGFuZCBpdCB0b2xkIG1lIHRoYXQKPj4gdGhlIGNvbW1pdCBtZW50aW9uZWQg aW4gdGhlIHN1YmplY3QgaXMgdGhlIHJlYXNvbi4KPj4gCj4+IFJldmVydGluZyBpdCBtYWtlcyB0 aGUgZGlzcGxheSB3b3JrIGFnYWluIGFuZCByZS1yZXZlcnRpbmcgZmFpbCBhZ2Fpbi4KPj4gCj4+ IElNSE8gaXQgc2VlbXMgYXMgaWYgdGhlIGRpc3BsYXkgRE1BIG9mIHRoZSBwaW5lcGhvbmUgKGFs bHdpbm5lciBzdW5pLWE1NCkKPj4gZ290IGluZmx1ZW5jZWQgYW5kIHN0b3BwZWQgdG8gc2NhbiB0 aGUgZnJhbWVidWZmZXIuCj4+IAo+PiBUaGUgb25seSBkbWEtcmFuZ2VzIEkgY291bGQgZmluZCBh cmUgZGVmaW5lZCBoZXJlOgo+PiAKPj4gCWFyY2gvYXJtNjQvYm9vdC9kdHMvYWxsd2lubmVyL3N1 bjUwaS1hNjQuZHRzaQo+PiAKPj4gCWRtYS1yYW5nZXMgPSA8MHgwMDAwMDAwMCAweDQwMDAwMDAw IDB4YzAwMDAwMDA+Owo+PiAKPj4gYnV0IEkgY2FuJ3QgdGVsbCBpZiB0aGV5IGFyZSAidmFsaWQi IG9yIG5vdC4KPj4gCj4+IEFueSBpbnNpZ2h0cyBhcmUgd2VsY29tZS4gQW5kIHBsZWFzZSBkaXJl Y3QgdG8gdGhlIHJpZ2h0IHBlb3BsZS9tYWlsaW5nIGxpc3RzCj4+IGlmIHRoZXkgYXJlIG1pc3Np bmcuCj4gCj4gVGhpcyBtYXkgbm90IGJlIHN0cmljdGx5IHRoZSBzYW1lIHRoaW5nLCBidXQgaXMg dGhpcyBwYXRjaCBpbiB5b3VyIHRyZWU6Cj4gaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9w cm9qZWN0L2xpbnV4LWFybS1rZXJuZWwvcGF0Y2gvMjAyMTAxMTUxNzU4MzEuMTE4NDI2MC0yLXBh dWwua29jaWFsa293c2tpQGJvb3RsaW4uY29tLwo+IAo+IElmIG5vdCwgaXQncyB3b3J0aCBhIHRy eSB0byBhZGQgaXQuCgpObywgaXQgaGFzbid0IGFycml2ZWQgaW4gdjUuMTEtcmM2IChvciBsaW51 eC1uZXh0KSB5ZXQuCgpCdXQgaXQgZml4ZXMgdGhlIGlzc3VlLgoKZ3JlYXQgYW5kIG1hbnkgdGhh bmtzLApOaWtvbGF1cwoKPiBJZiBpdCBpcywgaXQncyB3b3J0aCBkb2luZyBhIHJldmVydC4KPiAK PiBNeSB1bmRlcnN0YW5kaW5nIGlzIGxpa2UgREUyIGRvZXMgbm90IG5lZWQgYSBwYXJ0aWN1bGFy IERNQSByYW5nZSBhbmQgaGFzIERSQU0KPiBzdGFydGluZyBhdCAweDQwMDAwMDAwIChqdXN0IGxp a2UgdGhlIENQVSkgYnV0IGl0IHdpbGwgbWFwIERSQU0gaW4gYSBsb29wCj4gYmVmb3JlIGFuZCBh ZnRlciB0aGlzIGFkZHJlc3MuCj4gCj4gSSBzdXNwZWN0IHRoZSBpc3N1ZSBzaG93cyBiZWNhdXNl IHRoZSBwaW5lcGhvbmUgaGFzIDIgR2lCIFJBTSB3aGlsZSBmb3Igb3RoZXIKPiBib2FyZHMgd2l0 aCA8IDIgR2lCIFJBTSwgcmVtb3ZpbmcgMHg0MDAwMDAwMCB0byB0aGUgRE1BIGFkZHJlc3NlcyBz dGlsbCBwb2ludHMKPiB0byB0aGUgc2FtZSBsb2NhdGlvbi4gU28gSU1PIHRoZSBNQlVTIGRtYS1y YW5nZXMgc2hvdWxkbid0IGFwcGx5IHRvIERFMi4KPiBJIHRoaW5rIHRoaXMgaXMgYWxyZWFkeSB0 aGUgY2FzZSBpbiBkdCwgYnV0IHRoZSBtYnVzIGRyaXZlciBtYXkgYWRkIGl0IGlmIHlvdQo+IGRv bid0IGhhdmUgdGhhdCBwYXRjaC4KPiAKPiBJIHRoaW5rIEkgaGF2ZSBhIGZldyBBNjQgYm9hcmRz IGFyb3VuZCwgYnV0IHByb2JhYmx5IG5vdCB3aXRoIDIgR2lCIFJBTS4KPiBJZiBhZGRpbmcgdGhl IHBhdGNoIGRvZXNuJ3QgaGVscCwgSSdsbCB0cnkgdG8gbWFrZSBhIGZldyB0ZXN0Lgo+IAo+IENo ZWVycyEKPiAKPiBQYXVsCj4gCj4gLS0gCj4gUGF1bCBLb2NpYWxrb3dza2ksIEJvb3RsaW4KPiBF bWJlZGRlZCBMaW51eCBhbmQga2VybmVsIGVuZ2luZWVyaW5nCj4gaHR0cHM6Ly9ib290bGluLmNv bQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK