From: Timothy Shimmin <tes@sgi.com>
To: David Chinner <dgc@sgi.com>, Neil Brown <neilb@suse.de>
Cc: xfs@oss.sgi.com
Subject: Re: XFS and write barriers.
Date: Tue, 27 Mar 2007 14:58:06 +1100 [thread overview]
Message-ID: <E4668B41AB231E3CEA239371@timothy-shimmins-power-mac-g5.local> (raw)
In-Reply-To: <20070325031927.GG32602149@melbourne.sgi.com>
--On 25 March 2007 2:19:27 PM +1100 David Chinner <dgc@sgi.com> wrote:
> On Fri, Mar 23, 2007 at 07:00:46PM +1100, Neil Brown wrote:
>> On Friday March 23, tes@sgi.com wrote:
>> > >
>> > > I think this test should just be removed and the xfs_barrier_test
>> > > should be the main mechanism for seeing if barriers work.
>> > >
>> > Oh okay.
>> > This is all Christoph's (hch) code, so it would be good for him to comment here.
>> > The external log and readonly tests can stay though.
>> >
>>
>> Why no barriers on an external log device??? Not important, just
>> curious.
>
> because we need to synchronize across 2 devices, not one, so issuing
> barriers on an external log device does nothing to order the metadata
> written to the other device...
>
I have wondered in the past (sgi-bug#954969) about doing a blk_issue_flush
on the metadata device at xlog_sync time prior to the log write on
the log device.
27/July/06 - pv#954969
Currently, if one uses external logs then the barrier support is turned off.
The reaon for this is that a write barrier is normally only done on the data
device which has the log.
With an external log it means that a write barrier on a log device will not
do any flushing on the metadata device.
This pv is opened to explore the possibility of issuing an explicit metadata
device flush at xlog_sync time before doing a write barrier on the log data
to the log device.
This would guarantee if the tail moved because a metadata thought its
data was really on disk, would now be true as we would do a flush of
its device. Then we could do our log write without worrying that
our log write will overwrite log data when its metadata hadn't really made it.
Perhaps I'm missing something.
Dave (dgc) said he'd think about it.
I haven't heard back from Christoph yet, and he added the
code for our barrier support in xfs.
--Tim
--Tim
prev parent reply other threads:[~2007-03-27 4:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-23 1:26 XFS and write barriers Neil Brown
2007-03-23 5:30 ` David Chinner
2007-03-23 7:49 ` Neil Brown
2007-03-25 4:17 ` David Chinner
2007-03-25 23:21 ` Neil Brown
2007-03-26 3:14 ` David Chinner
2007-03-26 4:27 ` Neil Brown
2007-03-26 9:04 ` David Chinner
2007-03-29 14:56 ` Martin Steigerwald
2007-03-29 15:18 ` David Chinner
2007-03-29 16:49 ` Martin Steigerwald
2007-03-23 9:50 ` Christoph Hellwig
2007-03-25 3:51 ` David Chinner
2007-03-25 23:58 ` Neil Brown
2007-03-26 1:11 ` Neil Brown
2007-03-23 6:20 ` Timothy Shimmin
2007-03-23 8:00 ` Neil Brown
2007-03-25 3:19 ` David Chinner
2007-03-26 0:01 ` Neil Brown
2007-03-26 3:58 ` David Chinner
2007-03-27 3:58 ` Timothy Shimmin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E4668B41AB231E3CEA239371@timothy-shimmins-power-mac-g5.local \
--to=tes@sgi.com \
--cc=dgc@sgi.com \
--cc=neilb@suse.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.