From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755612AbcAMRaZ (ORCPT ); Wed, 13 Jan 2016 12:30:25 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:30745 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755545AbcAMRaV (ORCPT ); Wed, 13 Jan 2016 12:30:21 -0500 From: Daniel Sanders To: James Hogan , "Michael S. Tsirkin" CC: LKML , Michal Marek , "linux-kbuild@vger.kernel.org" , "Linux MIPS Mailing List" , Ralf Baechle Subject: RE: [PATCH] ld-version: fix it on Fedora Thread-Topic: [PATCH] ld-version: fix it on Fedora Thread-Index: AQHRTiSm06OWSy7R702Mpze/gPXRWp75re5g Date: Wed, 13 Jan 2016 17:30:18 +0000 Message-ID: References: <1452189189-31188-1-git-send-email-mst@redhat.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [192.168.14.109] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id u0DHUW4R017836 Hi, The version number that's giving me problems is 2.24.51.20140217 which ld-version.sh converts to 2036931700 (20000000+2400000+510000+2014021700). At the moment, I'm wondering whether we really need to handle more than three version number components. Another thought is that the comparison could be inside ld-version.sh (or a replacement) so that it can compare the array of version components directly instead of using a constructed integer as a proxy. > -----Original Message----- > From: james@albanarts.com [mailto:james@albanarts.com] On Behalf Of > James Hogan > Sent: 13 January 2016 17:06 > To: Michael S. Tsirkin > Cc: LKML; Michal Marek; linux-kbuild@vger.kernel.org; Linux MIPS Mailing > List; Ralf Baechle; Daniel Sanders > Subject: Re: [PATCH] ld-version: fix it on Fedora > > Cc'ing Daniel, who has hit further breakage due to unusual version numbers. > > On 7 January 2016 at 17:55, Michael S. Tsirkin wrote: > > On Fedora 23, ld --version outputs: > > GNU ld version 2.25-15.fc23 > > > > But ld-version.sh fails to parse this, so e.g. mips build fails to > > enable VDSO, printing a warning that binutils >= 2.24 is required. > > > > To fix, teach ld-version to parse this format. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > > > Which tree should this be merged through? Mine? MIPS? > > > > scripts/ld-version.sh | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/scripts/ld-version.sh b/scripts/ld-version.sh > > index 198580d..25d23c8 100755 > > --- a/scripts/ld-version.sh > > +++ b/scripts/ld-version.sh > > @@ -2,6 +2,8 @@ > > # extract linker version number from stdin and turn into single number > > { > > gsub(".*)", ""); > > + gsub(".*version ", ""); > > + gsub("-.*", ""); > > split($1,a, "."); > > print a[1]*10000000 + a[2]*100000 + a[3]*10000 + a[4]*100 + a[5]; > > exit > > -- > > MST > >