All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nixiaoming <nixiaoming@huawei.com>
To: Mukesh Ojha <mojha@codeaurora.org>,
	"jbrunet@baylibre.com" <jbrunet@baylibre.com>,
	"mturquette@baylibre.com" <mturquette@baylibre.com>,
	"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
	"soren.brinkmann@xilinx.com" <soren.brinkmann@xilinx.com>
Cc: "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] clk:Fix divide-by-zero in divider_ro_round_rate_parent
Date: Sat, 30 Mar 2019 13:40:38 +0000	[thread overview]
Message-ID: <E490CD805F7529488761C40FD9D26EF12AAC8ED0@DGGEMM527-MBS.china.huawei.com> (raw)
In-Reply-To: <fcbcceb2-e59b-465a-ec36-cde354425898@codeaurora.org>

On 3/30/2019 5:44 PM, Mukesh Ojha wrote:
>On 3/30/2019 8:01 AM, nixiaoming wrote:
>> In the function divider_recalc_rate() The judgment of the return value of
>> _get_div() indicates that the return value of _get_div() may be 0.
>
>s/may be/can be

Thank you for your comments.
I will fix it in a later patch.
>
>> In order to avoid the divide-by-zero error, add check the return values.
>s/add check the/add check for
>
Thank you for your comments.
I will fix it in a later patch.

>> of _get_div() in the divider_ro_round_rate_parent()
>>
>> Signed-off-by: nixiaoming <nixiaoming@huawei.com>
>
>
>Please fix the commit text.
>Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
>
>Cheers,
>-Mukesh
>

Thanks

      reply	other threads:[~2019-03-30 13:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-30  2:31 [PATCH v2 1/2] clk:Fix divide-by-zero in divider_ro_round_rate_parent nixiaoming
2019-03-30  9:44 ` Mukesh Ojha
2019-03-30 13:40   ` Nixiaoming [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E490CD805F7529488761C40FD9D26EF12AAC8ED0@DGGEMM527-MBS.china.huawei.com \
    --to=nixiaoming@huawei.com \
    --cc=jbrunet@baylibre.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mojha@codeaurora.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --cc=soren.brinkmann@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.