From: Brad Bishop <bradleyb@fuzziesquirrel.com>
To: Joel Stanley <joel@jms.id.au>
Cc: Eddie James <eajames@linux.vnet.ibm.com>,
Andrew Jeffery <andrew@aj.id.au>,
"Edward A. James" <eajames@us.ibm.com>,
OpenBMC Maillist <openbmc@lists.ozlabs.org>
Subject: Re: [PATCH linux dev-4.10 v5 31/31] drivers: hwmon: occ: Cancel occ operations in remove()
Date: Mon, 16 Oct 2017 14:34:11 -0400 [thread overview]
Message-ID: <E5EB43D9-7C66-4768-91CD-18624E307522@fuzziesquirrel.com> (raw)
In-Reply-To: <CACPK8Xc7f0AYTSfuSBC2=kgPaYvWFw7q5O8y-tF=-TSNG7xyDw@mail.gmail.com>
>>>
>>> Why not spin_lock_irqsave/spin_unlock_irqsave? Same throughout this patch.
>>
>>
>> Well spin_lock_irq/spin_unlock_irq is used through the occ and sbefifo
>> drivers. Just following suit here. I can switch it if necessary.
>
> If you understand the differences and used the non-save/restore
> versions intentionally, then we can keep the driver as it is.
This is my fault. The initial sbefifo driver introduced this. I don’t remember
what my mode of thinking was. Regardless, it sounds like it was wrong.
>
> In general, to be safe, more experienced kernel hackers than myself
> recommend the irqsave/irqrestore versions of the spin lock functions
> as they are safe to call from any context (IRQ or otherwise).
>
> Cheers,
>
> Joel
prev parent reply other threads:[~2017-10-16 18:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-06 14:29 [PATCH linux dev-4.10 v5 31/31] drivers: hwmon: occ: Cancel occ operations in remove() Eddie James
2017-10-09 2:00 ` Joel Stanley
2017-10-09 14:33 ` Eddie James
2017-10-10 2:57 ` Joel Stanley
2017-10-16 18:34 ` Brad Bishop [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E5EB43D9-7C66-4768-91CD-18624E307522@fuzziesquirrel.com \
--to=bradleyb@fuzziesquirrel.com \
--cc=andrew@aj.id.au \
--cc=eajames@linux.vnet.ibm.com \
--cc=eajames@us.ibm.com \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.