From mboxrd@z Thu Jan 1 00:00:00 1970 From: Koushik Chakravarty Subject: tools/libxl - Async Task Cancellation Query Date: Wed, 8 Apr 2015 08:37:54 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9057501988442746667==" Return-path: Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson , Euan Harris Cc: "'xen-devel@lists.xensource.com'" List-Id: xen-devel@lists.xenproject.org --===============9057501988442746667== Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_E638B0CB6CFBD44183ABE72A42E666268B0D48SINPEX01CL03citri_" --_000_E638B0CB6CFBD44183ABE72A42E666268B0D48SINPEX01CL03citri_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Ian, I am currently looking into the asynchronous task cancellation in libxl and= have a few very specific queries, if you could answer. 1. In libxl_domain_resume(),why is libxl_ao_complete called before AO_IN= PROGRESS? 2. In libxl_ao_cancel() - the function goes through the ctx->aos_inprogr= ess and tries to find a suitable libxl_ao that matches the input libxl_asyn= cop_how. It does so, by a few 'if' checks. Regarding this - a. Where does the libxl__ao get inserted to the ctx->aos_inprogress? I c= ould not find that somehow - sorry if I overlooked. b. Can I suggest adding a unique private 'id' field to the libxl_asyncop= _how structure, that will be populated by AO_CREATE? This will help finding= the matching corresponding libxl_ao from the ctx->aos_inprogress in libxl_= ao_cancel() quicker by looking for search->id =3D=3D libxl_asyncop_how->id. 3. In libxl_device_vkb_add(), shouldn't the function invoke libxl__ao_ab= ort in the error path? Thanks in advance! Regards, Koushik Chakravarty Mobile - +91-9663396424 --_000_E638B0CB6CFBD44183ABE72A42E666268B0D48SINPEX01CL03citri_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi Ian,

 

I am currently looking into the asynchronous task= cancellation in libxl and have a few very specific queries, if you could a= nswer.

 

1.    In libxl_domain_resume(),why is libxl_ao_= complete called before AO_INPROGRESS?

2.    In libxl_ao_cancel() – the function= goes through the ctx->aos_inprogress and tries to find a suitable libxl= _ao that matches the input libxl_asyncop_how. It does so, by a few ‘if’ checks. Regarding this –

a.    Where does the libxl__ao get inserted to = the ctx->aos_inprogress? I could not find that somehow – sorry if = I overlooked.

b.    Can I suggest adding a unique private = 216;id’ field to the libxl_asyncop_how structure, that will be popula= ted by AO_CREATE? This will help finding the matching corresponding libxl_ao from the ctx->aos_inprogress in libxl_ao_cancel() quicker by l= ooking for search->id =3D=3D libxl_asyncop_how->id.=

3.    In libxl_device_vkb_add(), shouldn’= t the function invoke libxl__ao_abort in the error path?

 

Thanks in advance!

 

Regard= s,

Koushi= k Chakravarty

Mobile= - +91-9663396424

 

--_000_E638B0CB6CFBD44183ABE72A42E666268B0D48SINPEX01CL03citri_-- --===============9057501988442746667== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============9057501988442746667==--