All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhuo, Qiuxu" <qiuxu.zhuo-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Matt Fleming
	<matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>,
	"Luck, Tony" <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: RE: [PATCH v3 1/2] efi: Add 'nr_config_table' variable in efi structure
Date: Thu, 22 Jun 2017 08:42:52 +0000	[thread overview]
Message-ID: <E6AF1AFDEA62A94A97508F458CBDD47F6F5A53F1@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <CAKv+Gu8fQmPRoxR67gm1yBvN0Z8ShY++TW07_RUYRsv-BAu_1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

> From: linux-efi-owner@vger.kernel.org [mailto:linux-efi-owner@vger.kernel.org] On Behalf Of Ard Biesheuvel
>>         efi.config_table = (unsigned long)efi.systab->tables;
>> +       efi.nr_config_table = (unsigned long)efi.systab->nr_tables;
>
>As it turns out, we never assign efi.config_table on ARM/arm64, and this needs to be fixed, so I queued a patch in the EFI -next branch.
>Could you rebase your series onto that, and make sure you add a similar line as this one to uefi_init() in drivers/firmware/efi/arm-init.c?
   
OK,  will add it to  uefi_init() in drivers/firmware/efi/arm-init.c in v4.


>>         .config_table           = EFI_INVALID_TABLE_ADDR,
>> +       .nr_config_table        = EFI_INVALID_TABLE_ADDR,
>
>nr_config_table is not a physical address, so please just initialize it to 0

OK, will correct it in v4.

Thanks!

BR
qiuxu



      parent reply	other threads:[~2017-06-22  8:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19 17:54 [PATCH v3 1/2] efi: Add 'nr_config_table' variable in efi structure Qiuxu Zhuo
     [not found] ` <20170619175423.70656-1-qiuxu.zhuo-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2017-06-20 23:28   ` Kees Cook
     [not found]     ` <CAGXu5jLuaU2H3y3VHYhR5qndcdD-pAgfC+_x+8PsACKjVjrmPw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-21  8:36       ` Zhuo, Qiuxu
2017-06-21 12:07   ` Ard Biesheuvel
     [not found]     ` <CAKv+Gu8fQmPRoxR67gm1yBvN0Z8ShY++TW07_RUYRsv-BAu_1g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-06-22  8:42       ` Zhuo, Qiuxu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E6AF1AFDEA62A94A97508F458CBDD47F6F5A53F1@SHSMSX101.ccr.corp.intel.com \
    --to=qiuxu.zhuo-ral2jqcrhueavxtiumwx3w@public.gmane.org \
    --cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
    --cc=tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.