All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jie, Yang" <yang.jie@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Takashi Iwai <tiwai@suse.de>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"tanu.kaskinen@linux.intel.com" <tanu.kaskinen@linux.intel.com>,
	"Girdwood, Liam R" <liam.r.girdwood@intel.com>
Subject: Re: [PATCH v9 0/7] ALSA: jack: Refactoring for jack kctls
Date: Fri, 24 Apr 2015 04:37:45 +0000	[thread overview]
Message-ID: <E7B1D079BA13FB44A978CC8F69C7D6A90551FDC7@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20150423181822.GA22845@sirena.org.uk>

> -----Original Message-----
> From: Mark Brown [mailto:broonie@kernel.org]
> Sent: Friday, April 24, 2015 2:18 AM
> To: Jie, Yang
> Cc: Takashi Iwai; alsa-devel@alsa-project.org; Girdwood, Liam R;
> tanu.kaskinen@linux.intel.com
> Subject: Re: [PATCH v9 0/7] ALSA: jack: Refactoring for jack kctls
> 
> On Thu, Apr 23, 2015 at 01:45:07PM +0000, Jie, Yang wrote:
> 
> > Hi, Mark, per my understanding, we didn't create specific kcontrols
> > for each ASoC jack, now, my new change reuse the jack pins' info to
> > create these kcontrols, which can be seen and controlled from upper
> > layer (e.g. PA).
> 
> I have not been keeping up with this series because it's quite large and there
> have been many revisions in a short period of time, along with a large
> number of other substantial patch serieses from your colleagues.
 
I can imagine and understand that. Care yourself, Mark. :)

To simplify it, let me summarize it:
only the patch 5 in the series ([PATCH v9 5/7] ASoC: jack: create kctls according
to jack pins info) change ASoC code, when looking into it, you can find only one
line is added:
+	snd_jack_add_new_kctl(jack->jack, pins[i].pin, pins[i].mask);

So the patch will create extra kcontrols for ASoC jack, comparing to the current
upstream code.

Thanks,
~Keyon

      reply	other threads:[~2015-04-24  4:37 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23  2:32 [PATCH v9 0/7] ALSA: jack: Refactoring for jack kctls Jie Yang
2015-04-23  2:32 ` [PATCH v9 1/7] ALSA: jack: implement kctl creating for jack device Jie Yang
2015-04-23  2:32 ` [PATCH v9 2/7] ALSA: Jack: handle jack embedded kcontrol creating within ctljack Jie Yang
2015-04-23  2:32 ` [PATCH v9 3/7] ALSA: jack: extend snd_jack_new to support phantom jack Jie Yang
2015-04-23  2:32 ` [PATCH v9 4/7] ALSA: hda - Update to use the new jack kctls method Jie Yang
2015-04-23  2:32 ` [PATCH v9 5/7] ASoC: jack: create kctls according to jack pins info Jie Yang
2015-04-27 19:33   ` Mark Brown
2015-04-23  2:32 ` [PATCH v9 6/7] ALSA: jack: remove exporting ctljack functions Jie Yang
2015-04-23  2:32 ` [PATCH v9 7/7] ALSA: Docs: Add documentation for Jack kcontrols Jie Yang
2015-04-23 12:47 ` [PATCH v9 0/7] ALSA: jack: Refactoring for jack kctls Takashi Iwai
2015-04-23 13:45   ` Jie, Yang
2015-04-23 15:00     ` Takashi Iwai
2015-04-23 15:20       ` Liam Girdwood
2015-04-24  4:27         ` Jie, Yang
2015-04-23 18:18     ` Mark Brown
2015-04-24  4:37       ` Jie, Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E7B1D079BA13FB44A978CC8F69C7D6A90551FDC7@SHSMSX101.ccr.corp.intel.com \
    --to=yang.jie@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@intel.com \
    --cc=tanu.kaskinen@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.