From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shankar, Uma" Subject: Re: [PATCH 01/13] drm/i915: Clean up intel_plane_atomic_check_with_state() Date: Wed, 16 Jan 2019 16:08:38 +0000 Message-ID: References: <20190111170823.4441-1-ville.syrjala@linux.intel.com> <20190111170823.4441-2-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1C4E6F124 for ; Wed, 16 Jan 2019 16:08:44 +0000 (UTC) In-Reply-To: <20190111170823.4441-2-ville.syrjala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org DQoNCj4tLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPkZyb206IFZpbGxlIFN5cmphbGEgW21h aWx0bzp2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbV0NCj5TZW50OiBGcmlkYXksIEphbnVh cnkgMTEsIDIwMTkgMTA6MzggUE0NCj5UbzogaW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zw0KPkNjOiBTaGFua2FyLCBVbWEgPHVtYS5zaGFua2FyQGludGVsLmNvbT47IFJvcGVyLCBNYXR0 aGV3IEQNCj48bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4NCj5TdWJqZWN0OiBbUEFUQ0ggMDEv MTNdIGRybS9pOTE1OiBDbGVhbiB1cA0KPmludGVsX3BsYW5lX2F0b21pY19jaGVja193aXRoX3N0 YXRlKCkNCj4NCj5Gcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPg0KPg0KPlJlbmFtZSBzb21lIG9mIHRoZSBzdGF0ZSB2YXJpYWJsZXMgaW4NCj5pbnRl bF9wbGFuZV9hdG9taWNfY2hlY2tfd2l0aF9zdGF0ZSgpIHRvIG1ha2UgaXQgbGVzcyBjb25mdXNp bmcuDQoNCkxvb2tzIG9rIHRvIG1lLg0KUmV2aWV3ZWQtYnk6IFVtYSBTaGFua2FyIDx1bWEuc2hh bmthckBpbnRlbC5jb20+DQoNCj5TaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPg0KPi0tLQ0KPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9hdG9taWNfcGxhbmUuYyB8IDM2ICsrKysrKysrKysrLS0tLS0tLS0tLS0tDQo+IDEgZmls ZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMoLSkNCj4NCj5kaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYXRvbWljX3BsYW5lLmMNCj5iL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2F0b21pY19wbGFuZS5jDQo+aW5kZXggNjgzYTc1ZGFkNGZi Li41MGJlMmM1ZGQ3NmUgMTAwNjQ0DQo+LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf YXRvbWljX3BsYW5lLmMNCj4rKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9hdG9taWNf cGxhbmUuYw0KPkBAIC0xMTAsNDEgKzExMCwzOSBAQCBpbnRlbF9wbGFuZV9kZXN0cm95X3N0YXRl KHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLCAgfQ0KPg0KPiBpbnQgaW50ZWxfcGxhbmVfYXRvbWlj X2NoZWNrX3dpdGhfc3RhdGUoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUNCj4qb2xkX2Ny dGNfc3RhdGUsDQo+LQkJCQkJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUsDQo+ KwkJCQkJc3RydWN0IGludGVsX2NydGNfc3RhdGUgKm5ld19jcnRjX3N0YXRlLA0KPiAJCQkJCWNv bnN0IHN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZQ0KPipvbGRfcGxhbmVfc3RhdGUsDQo+LQkJCQkJ c3RydWN0IGludGVsX3BsYW5lX3N0YXRlICppbnRlbF9zdGF0ZSkNCj4rCQkJCQlzdHJ1Y3QgaW50 ZWxfcGxhbmVfc3RhdGUNCj4qbmV3X3BsYW5lX3N0YXRlKQ0KPiB7DQo+LQlzdHJ1Y3QgZHJtX3Bs YW5lICpwbGFuZSA9IGludGVsX3N0YXRlLT5iYXNlLnBsYW5lOw0KPi0Jc3RydWN0IGRybV9wbGFu ZV9zdGF0ZSAqc3RhdGUgPSAmaW50ZWxfc3RhdGUtPmJhc2U7DQo+LQlzdHJ1Y3QgaW50ZWxfcGxh bmUgKmludGVsX3BsYW5lID0gdG9faW50ZWxfcGxhbmUocGxhbmUpOw0KPisJc3RydWN0IGludGVs X3BsYW5lICpwbGFuZSA9DQo+K3RvX2ludGVsX3BsYW5lKG5ld19wbGFuZV9zdGF0ZS0+YmFzZS5w bGFuZSk7DQo+IAlpbnQgcmV0Ow0KPg0KPi0JY3J0Y19zdGF0ZS0+YWN0aXZlX3BsYW5lcyAmPSB+ QklUKGludGVsX3BsYW5lLT5pZCk7DQo+LQljcnRjX3N0YXRlLT5udjEyX3BsYW5lcyAmPSB+QklU KGludGVsX3BsYW5lLT5pZCk7DQo+LQlpbnRlbF9zdGF0ZS0+YmFzZS52aXNpYmxlID0gZmFsc2U7 DQo+KwluZXdfY3J0Y19zdGF0ZS0+YWN0aXZlX3BsYW5lcyAmPSB+QklUKHBsYW5lLT5pZCk7DQo+ KwluZXdfY3J0Y19zdGF0ZS0+bnYxMl9wbGFuZXMgJj0gfkJJVChwbGFuZS0+aWQpOw0KPisJbmV3 X3BsYW5lX3N0YXRlLT5iYXNlLnZpc2libGUgPSBmYWxzZTsNCj4NCj4tCS8qIElmIHRoaXMgaXMg YSBjdXJzb3IgcGxhbmUsIG5vIGZ1cnRoZXIgY2hlY2tzIGFyZSBuZWVkZWQuICovDQo+LQlpZiAo IWludGVsX3N0YXRlLT5iYXNlLmNydGMgJiYgIW9sZF9wbGFuZV9zdGF0ZS0+YmFzZS5jcnRjKQ0K PisJaWYgKCFuZXdfcGxhbmVfc3RhdGUtPmJhc2UuY3J0YyAmJiAhb2xkX3BsYW5lX3N0YXRlLT5i YXNlLmNydGMpDQo+IAkJcmV0dXJuIDA7DQo+DQo+LQlyZXQgPSBpbnRlbF9wbGFuZS0+Y2hlY2tf cGxhbmUoY3J0Y19zdGF0ZSwgaW50ZWxfc3RhdGUpOw0KPisJcmV0ID0gcGxhbmUtPmNoZWNrX3Bs YW5lKG5ld19jcnRjX3N0YXRlLCBuZXdfcGxhbmVfc3RhdGUpOw0KPiAJaWYgKHJldCkNCj4gCQly ZXR1cm4gcmV0Ow0KPg0KPiAJLyogRklYTUUgcHJlLWc0eCBkb24ndCB3b3JrIGxpa2UgdGhpcyAq Lw0KPi0JaWYgKHN0YXRlLT52aXNpYmxlKQ0KPi0JCWNydGNfc3RhdGUtPmFjdGl2ZV9wbGFuZXMg fD0gQklUKGludGVsX3BsYW5lLT5pZCk7DQo+KwlpZiAobmV3X3BsYW5lX3N0YXRlLT5iYXNlLnZp c2libGUpDQo+KwkJbmV3X2NydGNfc3RhdGUtPmFjdGl2ZV9wbGFuZXMgfD0gQklUKHBsYW5lLT5p ZCk7DQo+DQo+LQlpZiAoc3RhdGUtPnZpc2libGUgJiYgc3RhdGUtPmZiLT5mb3JtYXQtPmZvcm1h dCA9PSBEUk1fRk9STUFUX05WMTIpDQo+LQkJY3J0Y19zdGF0ZS0+bnYxMl9wbGFuZXMgfD0gQklU KGludGVsX3BsYW5lLT5pZCk7DQo+KwlpZiAobmV3X3BsYW5lX3N0YXRlLT5iYXNlLnZpc2libGUg JiYNCj4rCSAgICBuZXdfcGxhbmVfc3RhdGUtPmJhc2UuZmItPmZvcm1hdC0+Zm9ybWF0ID09IERS TV9GT1JNQVRfTlYxMikNCj4rCQluZXdfY3J0Y19zdGF0ZS0+bnYxMl9wbGFuZXMgfD0gQklUKHBs YW5lLT5pZCk7DQo+DQo+LQlpZiAoc3RhdGUtPnZpc2libGUgfHwgb2xkX3BsYW5lX3N0YXRlLT5i YXNlLnZpc2libGUpDQo+LQkJY3J0Y19zdGF0ZS0+dXBkYXRlX3BsYW5lcyB8PSBCSVQoaW50ZWxf cGxhbmUtPmlkKTsNCj4rCWlmIChuZXdfcGxhbmVfc3RhdGUtPmJhc2UudmlzaWJsZSB8fCBvbGRf cGxhbmVfc3RhdGUtPmJhc2UudmlzaWJsZSkNCj4rCQluZXdfY3J0Y19zdGF0ZS0+dXBkYXRlX3Bs YW5lcyB8PSBCSVQocGxhbmUtPmlkKTsNCj4NCj4gCXJldHVybiBpbnRlbF9wbGFuZV9hdG9taWNf Y2FsY19jaGFuZ2VzKG9sZF9jcnRjX3N0YXRlLA0KPi0JCQkJCSAgICAgICAmY3J0Y19zdGF0ZS0+ YmFzZSwNCj4rCQkJCQkgICAgICAgJm5ld19jcnRjX3N0YXRlLT5iYXNlLA0KPiAJCQkJCSAgICAg ICBvbGRfcGxhbmVfc3RhdGUsDQo+LQkJCQkJICAgICAgIHN0YXRlKTsNCj4rCQkJCQkgICAgICAg Jm5ld19wbGFuZV9zdGF0ZS0+YmFzZSk7DQo+IH0NCj4NCj4gc3RhdGljIGludCBpbnRlbF9wbGFu ZV9hdG9taWNfY2hlY2soc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsDQo+LS0NCj4yLjE5LjINCg0K X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==