From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Shankar, Uma" Subject: Re: [PATCH 11/13] drm/i915: Turn off pipe gamma when it's not needed. Date: Thu, 17 Jan 2019 05:32:38 +0000 Message-ID: References: <20190111170823.4441-1-ville.syrjala@linux.intel.com> <20190111170823.4441-12-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id D60F689D84 for ; Thu, 17 Jan 2019 05:32:43 +0000 (UTC) In-Reply-To: <20190111170823.4441-12-ville.syrjala@linux.intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org DQoNCj4tLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPkZyb206IFZpbGxlIFN5cmphbGEgW21h aWx0bzp2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbV0NCj5TZW50OiBGcmlkYXksIEphbnVh cnkgMTEsIDIwMTkgMTA6MzggUE0NCj5UbzogaW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y Zw0KPkNjOiBTaGFua2FyLCBVbWEgPHVtYS5zaGFua2FyQGludGVsLmNvbT47IFJvcGVyLCBNYXR0 aGV3IEQNCj48bWF0dGhldy5kLnJvcGVyQGludGVsLmNvbT4NCj5TdWJqZWN0OiBbUEFUQ0ggMTEv MTNdIGRybS9pOTE1OiBUdXJuIG9mZiBwaXBlIGdhbW1hIHdoZW4gaXQncyBub3QgbmVlZGVkLg0K DQpGdWxsIHN0b3AgY2FuIGJlIGRyb3BwZWQuDQoNCj4NCj5Gcm9tOiBWaWxsZSBTeXJqw6Rsw6Qg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPg0KPg0KPlRoZSBwaXBlIGludGVybmFsIHBy ZWNpc2lvbiBpcyBoaWdoZXIgdGhhbiB3aGF0IHdlIGN1cnJlbnRseSBwcm9ncmFtIHRvIHRoZQ0K PmRlZ2FtbWEvZ2FtbWEgTFVUcy4gV2UgY2FuIGdldCBhIGhpZ2hlciBxdWFsaXR5IGltYWdlIGJ5 IGJ5cGFzc2luZyB0aGUgTFVUcw0KPndoZW4gdGhleSdyZSBub3QgbmVlZGVkLiBMZXQncyBkbyB0 aGF0Lg0KPg0KPkVhY2ggcGxhbmUgaGFzIGl0cyBvd24gY29udHJvbCBiaXQgZm9yIHRoaXMsIHNv IHdlIGhhdmUgdG8gdXBkYXRlIGFsbCBhY3RpdmUgcGxhbmVzLg0KPlRoZSB3YXkgd2UndmUgZG9u ZSB0aGlzIHdlIGRvbid0IGFjdHVhbGx5IGhhdmUgdG8gcnVuIHRocm91Z2ggdGhlIHdob2xlDQo+ LmNoZWNrX3BsYW5lKCkgdGhpbmcuIEFuZCB3ZSBhY3R1YWxseSBkbyB0aGUgLmNvbG9yX2NoZWNr KCkgYWZ0ZXIgLmNoZWNrX3BsYW5lKCkNCj5zbyB3ZSBjb3VsZG4ndCBldmVuIGRvIHRoYXQgd2l0 aG91dCBzaHVmZmxpbmcgdGhlIGNvZGUgYXJvdW5kLg0KPg0KPkFkZGl0aW9uYWxseSBvbiBwcmUt c2tsIHdlIGhhdmUgdG8gdXBkYXRlIHRoZSBwcmltYXJ5IHBsYW5lIHJlZ2FyZGxlc3Mgb2YNCj53 aGV0aGVyIGl0J3MgYWN0aXZlIG9yIG5vdCBvbiBhY2NvdW50IG9mIHRoZSBwcmltYXlyIHBsYW5l IGdhbW1hIGVuYWJsZSBiaXQgYWxzbw0KDQpUeXBvIGluIHByaW1hcnkuDQoNCk92ZXJhbGwgbG9v a3Mgb2sgdG8gbWUuDQpSZXZpZXdlZC1ieTogVW1hIFNoYW5rYXIgPHVtYS5zaGFua2FyQGludGVs LmNvbT4NCg0KPmFmZmVjdGluZyB0aGUgcGlwZSBib3R0b20gY29sb3IuDQo+DQo+U2lnbmVkLW9m Zi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4NCj4t LS0NCj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYyB8IDU1ICsrKysrKysrKysr KysrKysrKysrKysrKysrKystLQ0KPiAxIGZpbGUgY2hhbmdlZCwgNTMgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkNCj4NCj5kaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfY29sb3IuYw0KPmIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY29sb3IuYw0KPmluZGV4 IDhkN2VhOTAyYTM0Yi4uYThiNzQyOGE2NGJmIDEwMDY0NA0KPi0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2NvbG9yLmMNCj4rKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9j b2xvci5jDQo+QEAgLTYzMywyNyArNjMzLDc4IEBAIHZvaWQgaW50ZWxfY29sb3JfY29tbWl0KGNv bnN0IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlDQo+KmNydGNfc3RhdGUpDQo+IAlkZXZfcHJpdi0+ ZGlzcGxheS5jb2xvcl9jb21taXQoY3J0Y19zdGF0ZSk7DQo+IH0NCj4NCj4rc3RhdGljIGJvb2wg bmVlZF9wbGFuZV91cGRhdGUoc3RydWN0IGludGVsX3BsYW5lICpwbGFuZSwNCj4rCQkJICAgICAg Y29uc3Qgc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpIHsNCj4rCXN0cnVjdCBk cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUocGxhbmUtPmJhc2UuZGV2KTsNCj4r DQo+KwkvKg0KPisJICogT24gcHJlLVNLTCB0aGUgcGlwZSBnYW1tYSBlbmFibGUgYW5kIHBpcGUg Y3NjIGVuYWJsZSBmb3INCj4rCSAqIHRoZSBwaXBlIGJvdHRvbSBjb2xvciBhcmUgY29uZmlndXJl ZCB2aWEgdGhlIHByaW1hcnkgcGxhbmUuDQo+KwkgKiBXZSBoYXZlIHRvIHJlY29uZmlndXJlIHRo YXQgZXZlbiBpZiB0aGUgcGxhbmUgaXMgaW5hY3RpdmUuDQo+KwkgKi8NCj4rCXJldHVybiBjcnRj X3N0YXRlLT5hY3RpdmVfcGxhbmVzICYgQklUKHBsYW5lLT5pZCkgfHwNCj4rCQkoSU5URUxfR0VO KGRldl9wcml2KSA8IDkgJiYNCj4rCQkgcGxhbmUtPmlkID09IFBMQU5FX1BSSU1BUlkpOw0KPit9 DQo+Kw0KPitzdGF0aWMgaW50DQo+K2ludGVsX2NvbG9yX2FkZF9hZmZlY3RlZF9wbGFuZXMoc3Ry dWN0IGludGVsX2NydGNfc3RhdGUNCj4rKm5ld19jcnRjX3N0YXRlKSB7DQo+KwlzdHJ1Y3QgaW50 ZWxfY3J0YyAqY3J0YyA9IHRvX2ludGVsX2NydGMobmV3X2NydGNfc3RhdGUtPmJhc2UuY3J0Yyk7 DQo+KwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNydGMtPmJh c2UuZGV2KTsNCj4rCXN0cnVjdCBpbnRlbF9hdG9taWNfc3RhdGUgKnN0YXRlID0NCj4rCQl0b19p bnRlbF9hdG9taWNfc3RhdGUobmV3X2NydGNfc3RhdGUtPmJhc2Uuc3RhdGUpOw0KPisJY29uc3Qg c3RydWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9jcnRjX3N0YXRlID0NCj4rCQlpbnRlbF9hdG9t aWNfZ2V0X29sZF9jcnRjX3N0YXRlKHN0YXRlLCBjcnRjKTsNCj4rCXN0cnVjdCBpbnRlbF9wbGFu ZSAqcGxhbmU7DQo+Kw0KPisJaWYgKG5ld19jcnRjX3N0YXRlLT5nYW1tYV9lbmFibGUgPT0gb2xk X2NydGNfc3RhdGUtPmdhbW1hX2VuYWJsZSkNCj4rCQlyZXR1cm4gMDsNCj4rDQo+Kwlmb3JfZWFj aF9pbnRlbF9wbGFuZV9vbl9jcnRjKCZkZXZfcHJpdi0+ZHJtLCBjcnRjLCBwbGFuZSkgew0KPisJ CXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGU7DQo+Kw0KPisJCWlmICghbmVl ZF9wbGFuZV91cGRhdGUocGxhbmUsIG5ld19jcnRjX3N0YXRlKSkNCj4rCQkJY29udGludWU7DQo+ Kw0KPisJCXBsYW5lX3N0YXRlID0gaW50ZWxfYXRvbWljX2dldF9wbGFuZV9zdGF0ZShzdGF0ZSwg cGxhbmUpOw0KPisJCWlmIChJU19FUlIocGxhbmVfc3RhdGUpKQ0KPisJCQlyZXR1cm4gUFRSX0VS UihwbGFuZV9zdGF0ZSk7DQo+Kw0KPisJCW5ld19jcnRjX3N0YXRlLT51cGRhdGVfcGxhbmVzIHw9 IEJJVChwbGFuZS0+aWQpOw0KPisJfQ0KPisNCj4rCXJldHVybiAwOw0KPit9DQo+Kw0KPiBpbnQg aW50ZWxfY29sb3JfY2hlY2soc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpICB7 DQo+IAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGNydGNfc3Rh dGUtPmJhc2UuY3J0Yy0+ZGV2KTsNCj4gCWNvbnN0IHN0cnVjdCBkcm1fcHJvcGVydHlfYmxvYiAq Z2FtbWFfbHV0ID0gY3J0Y19zdGF0ZS0NCj4+YmFzZS5nYW1tYV9sdXQ7DQo+IAljb25zdCBzdHJ1 Y3QgZHJtX3Byb3BlcnR5X2Jsb2IgKmRlZ2FtbWFfbHV0ID0gY3J0Y19zdGF0ZS0NCj4+YmFzZS5k ZWdhbW1hX2x1dDsNCj4gCXNpemVfdCBnYW1tYV9sZW5ndGgsIGRlZ2FtbWFfbGVuZ3RoOw0KPisJ aW50IHJldDsNCj4NCj4gCWRlZ2FtbWFfbGVuZ3RoID0gSU5URUxfSU5GTyhkZXZfcHJpdiktPmNv bG9yLmRlZ2FtbWFfbHV0X3NpemU7DQo+IAlnYW1tYV9sZW5ndGggPSBJTlRFTF9JTkZPKGRldl9w cml2KS0+Y29sb3IuZ2FtbWFfbHV0X3NpemU7DQo+DQo+LQljcnRjX3N0YXRlLT5nYW1tYV9lbmFi bGUgPSB0cnVlOw0KPisJY3J0Y19zdGF0ZS0+Z2FtbWFfZW5hYmxlID0gZ2FtbWFfbHV0IHx8IGRl Z2FtbWFfbHV0Ow0KPg0KPiAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPj0gOSB8fA0KPiAJICAg IElTX0JST0FEV0VMTChkZXZfcHJpdikgfHwgSVNfSEFTV0VMTChkZXZfcHJpdikpDQo+IAkJY3J0 Y19zdGF0ZS0+Y3NjX2VuYWJsZSA9IHRydWU7DQo+DQo+KwlyZXQgPSBpbnRlbF9jb2xvcl9hZGRf YWZmZWN0ZWRfcGxhbmVzKGNydGNfc3RhdGUpOw0KPisJaWYgKHJldCkNCj4rCQlyZXR1cm4gcmV0 Ow0KPisNCj4gCS8qDQo+IAkgKiBXZSBhbHNvIGFsbG93IG5vIGRlZ2FtbWEgbHV0L2N0bSBhbmQg YSBnYW1tYSBsdXQgYXQgdGhlIGxlZ2FjeQ0KPiAJICogc2l6ZSAoMjU2IGVudHJpZXMpLg0KPiAJ ICovDQo+LQlpZiAoY3J0Y19zdGF0ZV9pc19sZWdhY3lfZ2FtbWEoY3J0Y19zdGF0ZSkpIHsNCj4r CWlmICghY3J0Y19zdGF0ZS0+Z2FtbWFfZW5hYmxlIHx8DQo+KwkgICAgY3J0Y19zdGF0ZV9pc19s ZWdhY3lfZ2FtbWEoY3J0Y19zdGF0ZSkpIHsNCj4gCQljcnRjX3N0YXRlLT5nYW1tYV9tb2RlID0g R0FNTUFfTU9ERV9NT0RFXzhCSVQ7DQo+IAkJcmV0dXJuIDA7DQo+IAl9DQo+LS0NCj4yLjE5LjIN Cg0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==