From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Subject: Re: [PATCH v2 02/15] eventdev: add APIs for extended
	stats
Date: Mon, 6 Feb 2017 10:37:31 +0000
Message-ID: <E923DB57A917B54B9182A2E928D00FA6129EE494@IRSMSX102.ger.corp.intel.com>
References: <1484580885-148524-1-git-send-email-harry.van.haaren@intel.com>
 <1485879273-86228-1-git-send-email-harry.van.haaren@intel.com>
 <1485879273-86228-3-git-send-email-harry.van.haaren@intel.com>
 <20170206082232.GC25242@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce"
 <bruce.richardson@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 1C3A9293B
 for <dev@dpdk.org>; Mon,  6 Feb 2017 11:37:49 +0100 (CET)
In-Reply-To: <20170206082232.GC25242@localhost.localdomain>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Monday, February 6, 2017 8:23 AM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>
> Subject: Re: [PATCH v2 02/15] eventdev: add APIs for extended stats
>=20
> On Tue, Jan 31, 2017 at 04:14:20PM +0000, Harry van Haaren wrote:
> > From: Bruce Richardson <bruce.richardson@intel.com>
> >
> > Add in APIs for extended stats so that eventdev implementations can rep=
ort
> > out information on their internal state. The APIs are based on, but not
> > identical to, the equivalent ethdev functions.
>=20
> The APIs Looks good. One minor comment though,
>=20
> Can you add statistics specific to per event queue and event
> port?, To improve the cases like below in the application code(taken from
> app/test/test_sw_eventdev.c).
>=20
> IMO, it is useful because,
> - ethdev has similar semantics
> - majority of the implementations will have port and queue specific stati=
stics counters

I'm not totally sure what you're asking but if I understand correctly, you'=
re suggesting a struct based stats API like this?

struct rte_event_dev_port_stats {
    uint64_t rx;
    uint64_t tx;
    ...
};

struct rte_event_dev_queue_stats {
    uint64_t rx;
    uint64_t tx;
    ...
};

/** a get function to get a specific port's statistics. The *stats* pointer=
 is filled in */=20
int rte_event_dev_port_stats_get(dev, uint8_t port_id, struct rte_event_dev=
_port_stats *stats);

/** a get function to get a specific queue's statistics. The *stats* pointe=
r is filled in */=20
int rte_event_dev_queue_stats_get(dev, uint8_t queue_id, struct rte_event_d=
ev_queue_stats *stats);


Is this what you meant, or did I misunderstand?


>=20
> +       for (i =3D 0; i < MAX_PORTS; i++) {
> +               char name[32];
> +               snprintf(name, sizeof(name), "port_%u_rx", i);
> +               stats->port_rx_pkts[i] =3D rte_event_dev_xstats_by_name_g=
et(
> +                               dev_id, name, &port_rx_pkts_ids[i]);
>=20
> +       for (i =3D 0; i < MAX_QIDS; i++) {
> +               char name[32];
> +               snprintf(name, sizeof(name), "qid_%u_rx", i);
> +               stats->qid_rx_pkts[i] =3D rte_event_dev_xstats_by_name_ge=
t(
> +                               dev_id, name, &qid_rx_pkts_ids[i]);
>=20