From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Subject: Re: [PATCH v3 01/17] eventdev: fix API docs and test for
 timeout ticks
Date: Fri, 10 Mar 2017 15:24:52 +0000
Message-ID: <E923DB57A917B54B9182A2E928D00FA6129FACA1@IRSMSX102.ger.corp.intel.com>
References: <1485879273-86228-1-git-send-email-harry.van.haaren@intel.com>
 <1487343252-16092-1-git-send-email-harry.van.haaren@intel.com>
 <1487343252-16092-2-git-send-email-harry.van.haaren@intel.com>
 <20170306103356.GA28766@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 9DDD72C48
 for <dev@dpdk.org>; Fri, 10 Mar 2017 16:24:56 +0100 (CET)
In-Reply-To: <20170306103356.GA28766@localhost.localdomain>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Monday, March 6, 2017 10:34 AM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>
> Subject: Re: [PATCH v3 01/17] eventdev: fix API docs and test for timeout=
 ticks

<snip>

> >  	ret =3D rte_event_dequeue_timeout_ticks(TEST_DEV_ID, 100, &timeout_ti=
cks);
> > -	TEST_ASSERT_SUCCESS(ret, "Fail to get timeout_ticks");
> > +	/* -ENOTSUP is a valid return if timeout is not supported by device  =
*/
> > +	if (ret !=3D -ENOTSUP)
> > +		TEST_ASSERT_SUCCESS(ret, "Fail to get timeout_ticks");
>=20
> Header file change looks good. IMO, In the test case, We can introduce
> TEST_UNSUPPORTED in addition to TEST_SUCCESS and TEST_FAILED to reflect
> the actual status. I guess it will useful for future tests as well.

Adding TEST_UNSUPPORTED requires a larger changeset than software eventdev =
should
make to the test infrastructure; my preference is to use the error check so=
lution
as above for v4 patchset.

Rework of testing infrastructure should be done on mainline dpdk if deemed =
required,
and enable on Eventdev branch after a rebase.