From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Van Haaren, Harry" Subject: Re: [PATCH v9 09/18] lib: add symbol versioning to distributor Date: Mon, 13 Mar 2017 11:01:13 +0000 Message-ID: References: <1488354455-142764-2-git-send-email-david.hunt@intel.com> <1488791433-186137-1-git-send-email-david.hunt@intel.com> <1488791433-186137-10-git-send-email-david.hunt@intel.com> <20170310162228.GB339712@bricha3-MOBL3.ger.corp.intel.com> <73b1521e-6517-d74c-8113-86a634f1a0ce@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: "Hunt, David" , "Richardson, Bruce" Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D053F1075 for ; Mon, 13 Mar 2017 12:01:15 +0100 (CET) In-Reply-To: <73b1521e-6517-d74c-8113-86a634f1a0ce@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hunt, David > Subject: Re: [dpdk-dev] [PATCH v9 09/18] lib: add symbol versioning to di= stributor >=20 > On 10/3/2017 4:22 PM, Bruce Richardson wrote: > > On Mon, Mar 06, 2017 at 09:10:24AM +0000, David Hunt wrote: > >> Also bumped up the ABI version number in the Makefile > >> > >> Signed-off-by: David Hunt > >> --- > >> lib/librte_distributor/Makefile | 2 +- > >> lib/librte_distributor/rte_distributor.c | 57 +++++++++++-= -- > >> lib/librte_distributor/rte_distributor_v1705.h | 89 ++++++++++++= ++++++++++ > > A file named rte_distributor_v1705.h was added in patch 4, then deleted > > in patch 7, and now added again here. Seems a lot of churn. > > > > /Bruce > > >=20 > The first introduction of this file is what will become the public > header. For successful compilation, > this cannot be called rte_distributor.h until the symbol versioning > patch, at which stage I will > rename the file, and introduce the symbol versioned header at the same > time. In the next patch > I'll rename this version of the files as rte_distributor_public.h to > make this clearer. Suggestion to use rte_distributor_next.h instead of public? Public doesn't indicate if its old or new, while next would make that clear= er IMO :)