From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Van Haaren, Harry" Subject: Re: [PATCH v6 0/5] Extended xstats API in ethdev library to allow grouping of stats Date: Thu, 13 Apr 2017 16:21:42 +0000 Message-ID: References: <1491928644-10383-2-git-send-email-michalx.k.jastrzebski@intel.com> <1492095568-20993-1-git-send-email-kubax.kozak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Jain, Deepak K" To: "Kozak, KubaX" , "dev@dpdk.org" Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 4EBA52BB1 for ; Thu, 13 Apr 2017 18:21:46 +0200 (CEST) In-Reply-To: <1492095568-20993-1-git-send-email-kubax.kozak@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Kozak, KubaX > Sent: Thursday, April 13, 2017 3:59 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Jain, Deepak K ; > Kozak, KubaX > Subject: [PATCH v6 0/5] Extended xstats API in ethdev library to allow gr= ouping of stats >=20 > Extended xstats API in ethdev library to allow grouping of stats logicall= y > so they can be retrieved per logical grouping managed by the application= . > Changed existing functions rte_eth_xstats_get_names and rte_eth_xstats_ge= t > to use a new list of arguments: array of ids and array of values. > ABI versioning mechanism was used to support backward compatibility. > Introduced two new functions rte_eth_xstats_get_all and > rte_eth_xstats_get_names_all which keeps functionality of the previous > ones (respectively rte_eth_xstats_get and rte_eth_xstats_get_names) > but use new API inside. Both functions marked as deprecated. > Introduced new function: rte_eth_xstats_get_id_by_name to retrieve > xstats ids by its names. > Extended functionality of proc_info application: > --xstats-name NAME: to display single xstat value by NAME > Updated test-pmd application to use new API. >=20 > v6 changes: > * patches arrangement in patchset > * fixes spelling bugs > * release notes >=20 > v5 changes: > * fix clang shared build compilation > * remove wrong versioning macros > * Makefile LIBABIVER 6 change >=20 > v4 changes: > * documentation change after API modification > * fix xstats display for PMD without _by_ids() functions > * fix ABI validator errors >=20 > v3 changes: > * checkpatch fixes > * removed malloc bug in ethdev > * add new command to proc_info and IDs parsing > * merged testpmd and proc_info patch with library patch Please keep Acks when only re-arranging patches and changes. I'll re-Ack the patches on patchwork now :) Thanks, -Harry