From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Van Haaren, Harry" Subject: Re: [PATCH v6 1/5] ethdev: new xstats API add retrieving by ID Date: Thu, 13 Apr 2017 16:23:35 +0000 Message-ID: References: <1491928644-10383-2-git-send-email-michalx.k.jastrzebski@intel.com> <1492095568-20993-1-git-send-email-kubax.kozak@intel.com> <1492095568-20993-2-git-send-email-kubax.kozak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Jain, Deepak K" , "Piasecki, JacekX" , "Kulasek, TomaszX" To: "Kozak, KubaX" , "dev@dpdk.org" Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 7E7842BB1 for ; Thu, 13 Apr 2017 18:23:39 +0200 (CEST) In-Reply-To: <1492095568-20993-2-git-send-email-kubax.kozak@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Kozak, KubaX > Sent: Thursday, April 13, 2017 3:59 PM > To: dev@dpdk.org > Cc: Van Haaren, Harry ; Jain, Deepak K ; > Piasecki, JacekX ; Kozak, KubaX ; Kulasek, > TomaszX > Subject: [PATCH v6 1/5] ethdev: new xstats API add retrieving by ID >=20 > From: Jacek Piasecki >=20 > Extended xstats API in ethdev library to allow grouping of stats > logically so they can be retrieved per logical grouping managed > by the application. > Changed existing functions rte_eth_xstats_get_names and > rte_eth_xstats_get to use a new list of arguments: array of ids > and array of values. ABI versioning mechanism was used to > support backward compatibility. > Introduced two new functions rte_eth_xstats_get_all and > rte_eth_xstats_get_names_all which keeps functionality of the > previous ones (respectively rte_eth_xstats_get and > rte_eth_xstats_get_names) but use new API inside. >=20 > test-pmd: add support for new xstats API retrieving by id in > testpmd application: xstats_get() and > xstats_get_names() call with modified parameters. >=20 > doc: add description for modified xstats API > Documentation change for modified extended statistics API functions. > The old API only allows retrieval of *all* of the NIC statistics > at once. Given this requires a MMIO read PCI transaction per statistic > it is an inefficient way of retrieving just a few key statistics. > Often a monitoring agent only has an interest in a few key statistics, > and the old API forces wasting CPU time and PCIe bandwidth in retrieving > *all* statistics; even those that the application didn't explicitly > show an interest in. > The new, more flexible API allow retrieval of statistics per ID. > If a PMD wishes, it can be implemented to read just the required > NIC registers. As a result, the monitoring application no longer wastes > PCIe bandwidth and CPU time. >=20 > Signed-off-by: Jacek Piasecki > Signed-off-by: Kuba Kozak > Signed-off-by: Tomasz Kulasek Acked-by: Harry van Haaren