From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Subject: Re: [PATCH 14/33] app/testeventdev: order: add eventdev
 port setup
Date: Fri, 23 Jun 2017 12:36:47 +0000
Message-ID: <E923DB57A917B54B9182A2E928D00FA640C31555@IRSMSX102.ger.corp.intel.com>
References: <20170528195854.6064-1-jerin.jacob@caviumnetworks.com>
 <20170528195854.6064-15-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>, "hemant.agrawal@nxp.com"
 <hemant.agrawal@nxp.com>, "Eads, Gage" <gage.eads@intel.com>,
 "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>, "Vangati, Narender"
 <narender.vangati@intel.com>, "Rao, Nikhil" <nikhil.rao@intel.com>,
 "gprathyusha@caviumnetworks.com" <gprathyusha@caviumnetworks.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 2DC3C374
 for <dev@dpdk.org>; Fri, 23 Jun 2017 14:36:51 +0200 (CEST)
In-Reply-To: <20170528195854.6064-15-jerin.jacob@caviumnetworks.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Sunday, May 28, 2017 8:59 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Van Haaren, Harry
> <harry.van.haaren@intel.com>; hemant.agrawal@nxp.com; Eads, Gage <gage.ea=
ds@intel.com>;
> nipun.gupta@nxp.com; Vangati, Narender <narender.vangati@intel.com>; Rao,=
 Nikhil
> <nikhil.rao@intel.com>; gprathyusha@caviumnetworks.com; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH 14/33] app/testeventdev: order: add eventdev p=
ort setup
>=20
> Setup one port per worker and link to all queues and setup
> one producer port to inject the events.
>=20
> Signed-off-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

One suggestion below to increase the enqueue depth, or was there a reason s=
et it to 8?

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>


<snip some code>

> +	/* setup one port per worker, linking to all queues */
> +	for (port =3D 0; port < nb_workers; port++) {
> +		struct worker_data *w =3D &t->worker[port];
> +
> +		w->dev_id =3D opt->dev_id;
> +		w->port_id =3D port;
> +		w->t =3D t;
> +
> +		ret =3D rte_event_port_setup(opt->dev_id, port, &wkr_p_conf);
> +		if (ret) {
> +			evt_err("failed to setup port %d", port);
> +			return ret;
> +		}
> +
> +		ret =3D rte_event_port_link(opt->dev_id, port, NULL, NULL, 0);
> +		if (ret !=3D nb_queues) {
> +			evt_err("failed to link all queues to port %d", port);
> +			return -EINVAL;
> +		}
> +	}
> +	/* port for producer, no links */
> +	const struct rte_event_port_conf prod_conf =3D {
> +			.dequeue_depth =3D 8,
> +			.enqueue_depth =3D 8,

.enqueue_depth =3D 32 or so?