From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Subject: Re: [PATCH 2/5] eventdev: introduce specialized enqueue
 new op variant
Date: Fri, 30 Jun 2017 08:40:06 +0000
Message-ID: <E923DB57A917B54B9182A2E928D00FA640C343A9@IRSMSX102.ger.corp.intel.com>
References: <20170629141956.23132-1-jerin.jacob@caviumnetworks.com>
 <20170629141956.23132-2-jerin.jacob@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>, "hemant.agrawal@nxp.com"
 <hemant.agrawal@nxp.com>, "Eads, Gage" <gage.eads@intel.com>,
 "nipun.gupta@nxp.com" <nipun.gupta@nxp.com>, "Vangati, Narender"
 <narender.vangati@intel.com>, "Rao, Nikhil" <nikhil.rao@intel.com>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 21E9F3772
 for <dev@dpdk.org>; Fri, 30 Jun 2017 10:40:09 +0200 (CEST)
In-Reply-To: <20170629141956.23132-2-jerin.jacob@caviumnetworks.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com]
> Sent: Thursday, June 29, 2017 3:20 PM
> To: dev@dpdk.org
<snip>
> diff --git a/drivers/event/octeontx/ssovf_evdev.c b/drivers/event/octeont=
x/ssovf_evdev.c
> index 8dc7b2ef8..0d0c6a186 100644
> --- a/drivers/event/octeontx/ssovf_evdev.c
> +++ b/drivers/event/octeontx/ssovf_evdev.c
> @@ -158,6 +158,7 @@ ssovf_fastpath_fns_set(struct rte_eventdev *dev)
>  	dev->schedule      =3D NULL;
>  	dev->enqueue       =3D ssows_enq;
>  	dev->enqueue_burst =3D ssows_enq_burst;
> +	dev->enqueue_new_burst =3D ssows_enq_burst;
>  	dev->dequeue       =3D ssows_deq;
>  	dev->dequeue_burst =3D ssows_deq_burst;
>=20
> diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c
> index fe2a61e2f..951ad1b33 100644
> --- a/drivers/event/sw/sw_evdev.c
> +++ b/drivers/event/sw/sw_evdev.c
> @@ -796,6 +796,7 @@ sw_probe(struct rte_vdev_device *vdev)
>  	dev->dev_ops =3D &evdev_sw_ops;
>  	dev->enqueue =3D sw_event_enqueue;
>  	dev->enqueue_burst =3D sw_event_enqueue_burst;
> +	dev->enqueue_new_burst =3D sw_event_enqueue_burst;
>  	dev->dequeue =3D sw_event_dequeue;
>  	dev->dequeue_burst =3D sw_event_dequeue_burst;
>  	dev->schedule =3D sw_event_schedule;


I think it is possible to do this pointer-setting of new_burst() in eventde=
v.c, instead of adding the new_burst() to each PMD individually?
During rte_eventdev_configure(), if the dev->enqueue_new_burst() function i=
s NULL, just point it at the ordinary one;

if (!dev->enqueue_new_burst)
    dev->enqueue_new_burst =3D dev->enqueue_burst;


This saves per-PMD changes for adding new parallel function pointers - and =
avoids PMDs accidentally not being updated. With that change;

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>