From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Van Haaren, Harry" Subject: Re: [PATCH] all: refactor coding style Date: Wed, 19 Jul 2017 09:24:38 +0000 Message-ID: References: <1500455196-182365-1-git-send-email-tiwei.bie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "thomas@monjalon.net" , "dev@dpdk.org" To: "Bie, Tiwei" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id BBCA0532C for ; Wed, 19 Jul 2017 11:24:44 +0200 (CEST) In-Reply-To: <1500455196-182365-1-git-send-email-tiwei.bie@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tiwei Bie > Sent: Wednesday, July 19, 2017 10:07 AM > To: dev@dpdk.org > Cc: thomas@monjalon.net > Subject: [dpdk-dev] [PATCH] all: refactor coding style >=20 > Remove the unwanted spaces before `;' across DPDK source code > by below one-liner with some minor manual refinements. >=20 > find . -name '*.[ch]' | xargs sed -i 's/\([^;(]\) \+;/\1;/g' >=20 > The fixes for cmdline library are skipped, because it has a > different coding style. It deserves a separate cleanup if > necessary. The fixes for drivers' base code are also skipped > to keep the base code intact. >=20 > Signed-off-by: Tiwei Bie Hi Tiwei, Although the idea and motivation for code-cleanup are good, performing large cleanup across a code-base is not a good solution. The reason that these types of cleanups (or even re-formatting the entire codebase) are not performed often is that it "invalidates" any currently-in-progress patch-se= ts. As a result, more work is required from many contributors to rebase useful features due to across-the-board white-space cleanups. Just expressing concern that we need to think carefully about the impacts of such a patch. Regards, -Harry