From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Van Haaren, Harry" Subject: Re: [PATCH v2 07/15] examples/eventdev: modify work cycles Date: Mon, 15 Jan 2018 10:14:58 +0000 Message-ID: References: <20171207203705.25020-1-pbhagavatula@caviumnetworks.com> <20180110111013.14644-1-pbhagavatula@caviumnetworks.com> <20180110111013.14644-7-pbhagavatula@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Pavan Nikhilesh , "Eads, Gage" , "jerin.jacobkollanukkaran@cavium.com" , "hemant.agrawal@nxp.com" , "Ma, Liang J" , "santosh.shukla@caviumnetworks.com" Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 7DA6A2C57 for ; Mon, 15 Jan 2018 11:15:02 +0100 (CET) In-Reply-To: <20180110111013.14644-7-pbhagavatula@caviumnetworks.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com] > Sent: Wednesday, January 10, 2018 11:10 AM > To: Eads, Gage ; jerin.jacobkollanukkaran@cavium.com= ; > Van Haaren, Harry ; hemant.agrawal@nxp.com; M= a, > Liang J ; santosh.shukla@caviumnetworks.com > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [dpdk-dev] [PATCH v2 07/15] examples/eventdev: modify work cycle= s >=20 > The current work cycles function exchanges source and destination mac > address and also pauses the core for the given cycles. > This patch splits the function into two parts i.e. exchange mac and > pause the cores. The pause cores function is invoked at every stage > where as exchange mac is invoked when packet is transmitted. >=20 > Signed-off-by: Pavan Nikhilesh Looks good. After this change, the MAC is only swapped once, making it a "valid" forwarding app, instead of a promiscuous mode performance tester. Acked-by: Harry van Haaren