All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Eads, Gage" <gage.eads@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v2] event/sw: perform partial burst enqueues
Date: Tue, 13 Mar 2018 14:08:20 +0000	[thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA65E00095B@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1520866522-13942-1-git-send-email-gage.eads@intel.com>

> From: Eads, Gage
> Sent: Monday, March 12, 2018 2:55 PM
> To: dev@dpdk.org
> Cc: jerin.jacob@caviumnetworks.com; Van Haaren, Harry
> <harry.van.haaren@intel.com>
> Subject: [PATCH v2] event/sw: perform partial burst enqueues
> 
> Previously, the sw PMD would enqueue either all or no events, depending on
> if enough inflight credits were available for the new events in the burst.
> If a port is enqueueing a large burst (i.e. a multiple of the credit update
> quanta), this can result in suboptimal performance, and requires an
> understanding of the sw PMD implementation (in particular, its credit
> scheme) to tune an application's burst size.
> 
> This affects software that enqueues large bursts of new events, such as the
> ethernet event adapter which uses a 128-deep event buffer, when the input
> packet rate is sufficiently high.
> 
> This change makes the sw PMD enqueue as many events as it has credits, if
> there are any new events in the burst.
> 
> Signed-off-by: Gage Eads <gage.eads@intel.com>


Agree that making forward progress by enqueuing what we have credits for
makes sense for the application.

No performance degradation here, thanks for the patch:

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>

  reply	other threads:[~2018-03-13 14:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08 22:55 [PATCH] event/sw: perform partial burst enqueues Gage Eads
2018-03-12 14:55 ` [PATCH v2] " Gage Eads
2018-03-13 14:08   ` Van Haaren, Harry [this message]
2018-03-20  7:01     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E923DB57A917B54B9182A2E928D00FA65E00095B@IRSMSX102.ger.corp.intel.com \
    --to=harry.van.haaren@intel.com \
    --cc=dev@dpdk.org \
    --cc=gage.eads@intel.com \
    --cc=jerin.jacob@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.