From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Subject: Re: [PATCH v4 04/13] telemetry: add initial connection
	socket
Date: Tue, 16 Oct 2018 00:45:37 +0000
Message-ID: <E923DB57A917B54B9182A2E928D00FA65E2ECA02@IRSMSX102.ger.corp.intel.com>
References: <20181010105134.48079-1-kevin.laatz@intel.com>
 <20181011165837.81030-1-kevin.laatz@intel.com>
 <20181011165837.81030-5-kevin.laatz@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "stephen@networkplumber.org" <stephen@networkplumber.org>,
 "gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>, "shreyansh.jain@nxp.com"
 <shreyansh.jain@nxp.com>, "thomas@monjalon.net" <thomas@monjalon.net>,
 "mattias.ronnblom@ericsson.com" <mattias.ronnblom@ericsson.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>, Ciara Power
 <ciara.power@intel.com>, Brian Archbold <brian.archbold@intel.com>
To: "Laatz, Kevin" <kevin.laatz@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 7E4B74C95
 for <dev@dpdk.org>; Tue, 16 Oct 2018 02:45:42 +0200 (CEST)
In-Reply-To: <20181011165837.81030-5-kevin.laatz@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Laatz, Kevin
> Sent: Thursday, October 11, 2018 9:58 AM
> To: dev@dpdk.org
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>;
> stephen@networkplumber.org; gaetan.rivet@6wind.com; shreyansh.jain@nxp.co=
m;
> thomas@monjalon.net; mattias.ronnblom@ericsson.com; Richardson, Bruce
> <bruce.richardson@intel.com>; Ciara Power <ciara.power@intel.com>; Brian
> Archbold <brian.archbold@intel.com>; Laatz, Kevin <kevin.laatz@intel.com>
> Subject: [PATCH v4 04/13] telemetry: add initial connection socket
>=20
> From: Ciara Power <ciara.power@intel.com>
>=20
> This patch adds the telemetry UNIX socket. It is used to
> allow connections from external clients.
>=20
> On the initial connection from a client, ethdev stats are
> registered in the metrics library, to allow for their retrieval
> at a later stage.
>=20
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> Signed-off-by: Brian Archbold <brian.archbold@intel.com>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---

<big snip>

> +static int32_t
> +rte_telemetry_create_socket(struct telemetry_impl *telemetry)
> +{
> +	int ret;
> +	struct sockaddr_un addr =3D {0};
> +	char socket_path[BUF_SIZE];

BUF_SIZE is not yet defined - it is in the next patch.
Pull the #define back into this patchset; now this patch
(without next one applied) won't build. With that fix;

Acked-by: Harry van Haaren <harry.van.haaren@intel.com>