From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Van Haaren, Harry" Subject: Re: [PATCH v9 03/12] telemetry: initial telemetry infrastructure Date: Sat, 27 Oct 2018 02:19:27 +0000 Message-ID: References: <20181024160311.85457-1-kevin.laatz@intel.com> <20181026235933.79779-1-harry.van.haaren@intel.com> <20181026235933.79779-4-harry.van.haaren@intel.com> <3436860.VK1RJtmnne@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "stephen@networkplumber.org" , "gaetan.rivet@6wind.com" , "shreyansh.jain@nxp.com" , "mattias.ronnblom@ericsson.com" , "Laatz, Kevin" , "Nicolau, Radu" , "Hunt, David" To: Thomas Monjalon , "Richardson, Bruce" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8A1D010A3 for ; Sat, 27 Oct 2018 04:19:32 +0200 (CEST) In-Reply-To: <3436860.VK1RJtmnne@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, October 26, 2018 6:56 PM > To: Van Haaren, Harry ; Laatz, Kevin > ; Nicolau, Radu ; Hunt, Da= vid > > Cc: dev@dpdk.org; Richardson, Bruce ; > stephen@networkplumber.org; gaetan.rivet@6wind.com; shreyansh.jain@nxp.co= m; > mattias.ronnblom@ericsson.com; Ciara Power ; Brian > Archbold > Subject: Re: [dpdk-dev] [PATCH v9 03/12] telemetry: initial telemetry > infrastructure >=20 > 27/10/2018 01:59, Harry van Haaren: > > --- a/mk/rte.vars.mk > > +++ b/mk/rte.vars.mk > > +JANSSON :=3D $(shell pkg-config --exists jansson; echo $$?) > > +ifneq ($(JANSSON),0) > > +$(warning Jansson not found, disabling RTE_LIBRTE_TELEMETRY) > > +CONFIG_RTE_LIBRTE_TELEMETRY =3D n > > +endif >=20 > It fails for cross-compilation. > Example: > When compiling i686 on x86_64 host, no error with > pkg-config --exists jansson > but fails when linking: > /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux- > gnu/8.2.1/../../../libjansson.so when searching for -ljansson > /usr/bin/ld: skipping incompatible /usr/lib/gcc/x86_64-pc-linux- > gnu/8.2.1/../../../libjansson.a when searching for -ljansson > /usr/bin/ld: skipping incompatible /usr/lib/libjansson.so when searching > for -ljansson > /usr/bin/ld: skipping incompatible /usr/lib/libjansson.a when searching > for -ljansson > /usr/bin/ld: cannot find -ljansson >=20 > Note: there is the same issue with examples/vm_power_manager/Makefile >=20 > I start thinking it is not reasonnable to enable an optional dependency > in our Makefiles. Perhaps the only solution is to use meson... Ouch, yes if x86_64 pkg-config finds the available library, and it is not a= vailable in its i686 form, or other combinations thereof, things become ano= ther-level of complex. Indeed Meson is (good | getting better) at detecting these things, Bruce kn= ows more IIRC :) @Thomas, for this release I propose to rework to use CONFIG=3DN as default = for Make, and allow packagers to enable if they wish. Is that a good next-s= tep?