From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Van Haaren, Harry" Subject: Re: [PATCH] service: fix parameter type Date: Mon, 21 Jan 2019 11:43:59 +0000 Message-ID: References: <1547906489-71240-1-git-send-email-nikhil.rao@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: "Rao, Nikhil" Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id ACD325B16 for ; Mon, 21 Jan 2019 12:44:06 +0100 (CET) In-Reply-To: <1547906489-71240-1-git-send-email-nikhil.rao@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Rao, Nikhil > Sent: Saturday, January 19, 2019 2:01 PM > To: Van Haaren, Harry > Cc: dev@dpdk.org; Rao, Nikhil > Subject: [PATCH] service: fix parameter type >=20 > The type of value parameter to rte_service_attr_get > should be uint64_t *, since the attributes > are of type uint64_t. >=20 > Fixes: 4d55194d76a4 ("service: add attribute get function") >=20 > Reviewed-by: Gage Eads > Signed-off-by: Nikhil Rao Acked-by: Harry van Haaren > --- > lib/librte_eal/common/include/rte_service.h | 2 +- > lib/librte_eal/common/rte_service.c | 2 +- > test/test/test_service_cores.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) >=20 > For 19.02, I assume this will require the ABI change announcement. I will > post it once this patch is acked. Correct - this breaks API and ABI, so certainly will need an announce. Thanks for the fixup, -Harry