From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754099AbbFOGmo (ORCPT ); Mon, 15 Jun 2015 02:42:44 -0400 Received: from mga14.intel.com ([192.55.52.115]:40245 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753857AbbFOGmf (ORCPT ); Mon, 15 Jun 2015 02:42:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,617,1427785200"; d="scan'208";a="746761248" From: "Wu, Feng" To: Alex Williamson , Avi Kivity CC: "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "pbonzini@redhat.com" , "mtosatti@redhat.com" , "eric.auger@linaro.org" , "Wu, Feng" Subject: RE: [v4 08/16] KVM: kvm-vfio: User API for IRQ forwarding Thread-Topic: [v4 08/16] KVM: kvm-vfio: User API for IRQ forwarding Thread-Index: AQHQpUKH3jSEQw7RikmlNDUvzTQMLp2tIc3Q Date: Mon, 15 Jun 2015 06:42:19 +0000 Message-ID: References: <1434019912-15423-1-git-send-email-feng.wu@intel.com> <1434019912-15423-9-git-send-email-feng.wu@intel.com> <5579E884.3040500@gmail.com> <1434123695.4927.304.camel@redhat.com> <557B2994.1070900@gmail.com> <1434135815.4927.308.camel@redhat.com> In-Reply-To: <1434135815.4927.308.camel@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t5F6gnwT026155 > -----Original Message----- > From: Alex Williamson [mailto:alex.williamson@redhat.com] > Sent: Saturday, June 13, 2015 3:04 AM > To: Avi Kivity > Cc: Wu, Feng; kvm@vger.kernel.org; linux-kernel@vger.kernel.org; > pbonzini@redhat.com; mtosatti@redhat.com; eric.auger@linaro.org > Subject: Re: [v4 08/16] KVM: kvm-vfio: User API for IRQ forwarding > > On Fri, 2015-06-12 at 21:48 +0300, Avi Kivity wrote: > > On 06/12/2015 06:41 PM, Alex Williamson wrote: > > > On Fri, 2015-06-12 at 00:23 +0000, Wu, Feng wrote: > > >>> -----Original Message----- > > >>> From: Avi Kivity [mailto:avi.kivity@gmail.com] > > >>> Sent: Friday, June 12, 2015 3:59 AM > > >>> To: Wu, Feng; kvm@vger.kernel.org; linux-kernel@vger.kernel.org > > >>> Cc: pbonzini@redhat.com; mtosatti@redhat.com; > > >>> alex.williamson@redhat.com; eric.auger@linaro.org > > >>> Subject: Re: [v4 08/16] KVM: kvm-vfio: User API for IRQ forwarding > > >>> > > >>> On 06/11/2015 01:51 PM, Feng Wu wrote: > > >>>> From: Eric Auger > > >>>> > > >>>> This patch adds and documents a new KVM_DEV_VFIO_DEVICE group > > >>>> and 2 device attributes: KVM_DEV_VFIO_DEVICE_FORWARD_IRQ, > > >>>> KVM_DEV_VFIO_DEVICE_UNFORWARD_IRQ. The purpose is to be able > > >>>> to set a VFIO device IRQ as forwarded or not forwarded. > > >>>> the command takes as argument a handle to a new struct named > > >>>> kvm_vfio_dev_irq. > > >>> Is there no way to do this automatically? After all, vfio knows that a > > >>> device interrupt is forwarded to some eventfd, and kvm knows that some > > >>> eventfd is forwarded to a guest interrupt. If they compare notes > > >>> through a central registry, they can figure out that the interrupt needs > > >>> to be forwarded. > > >> Oh, just like Eric mentioned in his reply, this description is out of context of > > >> this series, I will remove them in the next version. > > > > > > I suspect Avi's question was more general. While forward/unforward is > > > out of context for this series, it's very similar in nature to > > > enabling/disabling posted interrupts. So I think the question remains > > > whether we really need userspace to participate in creating this > > > shortcut or if kvm and vfio can some how orchestrate figuring it out > > > automatically. > > > > > > Personally I don't know how we could do it automatically. We've always > > > relied on userspace to independently setup vfio and kvm such that > > > neither have any idea that the other is there and update each side > > > independently when anything changes. So it seems consistent to continue > > > that here. It doesn't seem like there's much to gain performance-wise > > > either, updates should be a relatively rare event I'd expect. > > > > > > There's really no metadata associated with an eventfd, so "comparing > > > notes" automatically might imply some central registration entity. That > > > immediately sounds like a much more complex solution, but maybe Avi has > > > some ideas to manage it. Thanks, > > > > > > > The idea is to have a central registry maintained by a posted interrupts > > manager. Both vfio and kvm pass the filp (along with extra information) > > to the posted interrupts manager, which, when it detects a filp match, > > tells each of them what to do. > > > > The advantages are: > > - old userspace gains the optimization without change > > - a userspace API is more expensive to maintain than internal kernel > > interfaces (CVEs, documentation, maintaining backwards compatibility) > > - if you can do it without a new interface, this indicates that all the > > information in the new interface is redundant. That means you have to > > check it for consistency with the existing information, so it's extra > > work (likely, it's exactly what the posted interrupt manager would be > > doing anyway). > > Yep, those all sound like good things and I believe that's similar in > design to the way we had originally discussed this interaction at > LPC/KVM Forum several years ago. I'd be in favor of that approach. > Thanks, This seems a little complex compared to the current solution, since I am not quite familiar with VFIO, Alex, can you help on this if we need to do this that way, especially for the VFIO part? Thanks, Feng > > Alex {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Wu, Feng" Subject: RE: [v4 08/16] KVM: kvm-vfio: User API for IRQ forwarding Date: Mon, 15 Jun 2015 06:42:19 +0000 Message-ID: References: <1434019912-15423-1-git-send-email-feng.wu@intel.com> <1434019912-15423-9-git-send-email-feng.wu@intel.com> <5579E884.3040500@gmail.com> <1434123695.4927.304.camel@redhat.com> <557B2994.1070900@gmail.com> <1434135815.4927.308.camel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "pbonzini@redhat.com" , "mtosatti@redhat.com" , "eric.auger@linaro.org" , "Wu, Feng" To: Alex Williamson , Avi Kivity Return-path: In-Reply-To: <1434135815.4927.308.camel@redhat.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQWxleCBXaWxsaWFtc29u IFttYWlsdG86YWxleC53aWxsaWFtc29uQHJlZGhhdC5jb21dDQo+IFNlbnQ6IFNhdHVyZGF5LCBK dW5lIDEzLCAyMDE1IDM6MDQgQU0NCj4gVG86IEF2aSBLaXZpdHkNCj4gQ2M6IFd1LCBGZW5nOyBr dm1Admdlci5rZXJuZWwub3JnOyBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnOw0KPiBwYm9u emluaUByZWRoYXQuY29tOyBtdG9zYXR0aUByZWRoYXQuY29tOyBlcmljLmF1Z2VyQGxpbmFyby5v cmcNCj4gU3ViamVjdDogUmU6IFt2NCAwOC8xNl0gS1ZNOiBrdm0tdmZpbzogVXNlciBBUEkgZm9y IElSUSBmb3J3YXJkaW5nDQo+IA0KPiBPbiBGcmksIDIwMTUtMDYtMTIgYXQgMjE6NDggKzAzMDAs IEF2aSBLaXZpdHkgd3JvdGU6DQo+ID4gT24gMDYvMTIvMjAxNSAwNjo0MSBQTSwgQWxleCBXaWxs aWFtc29uIHdyb3RlOg0KPiA+ID4gT24gRnJpLCAyMDE1LTA2LTEyIGF0IDAwOjIzICswMDAwLCBX dSwgRmVuZyB3cm90ZToNCj4gPiA+Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiA+ Pj4gRnJvbTogQXZpIEtpdml0eSBbbWFpbHRvOmF2aS5raXZpdHlAZ21haWwuY29tXQ0KPiA+ID4+ PiBTZW50OiBGcmlkYXksIEp1bmUgMTIsIDIwMTUgMzo1OSBBTQ0KPiA+ID4+PiBUbzogV3UsIEZl bmc7IGt2bUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcNCj4g PiA+Pj4gQ2M6IHBib256aW5pQHJlZGhhdC5jb207IG10b3NhdHRpQHJlZGhhdC5jb207DQo+ID4g Pj4+IGFsZXgud2lsbGlhbXNvbkByZWRoYXQuY29tOyBlcmljLmF1Z2VyQGxpbmFyby5vcmcNCj4g PiA+Pj4gU3ViamVjdDogUmU6IFt2NCAwOC8xNl0gS1ZNOiBrdm0tdmZpbzogVXNlciBBUEkgZm9y IElSUSBmb3J3YXJkaW5nDQo+ID4gPj4+DQo+ID4gPj4+IE9uIDA2LzExLzIwMTUgMDE6NTEgUE0s IEZlbmcgV3Ugd3JvdGU6DQo+ID4gPj4+PiBGcm9tOiBFcmljIEF1Z2VyIDxlcmljLmF1Z2VyQGxp bmFyby5vcmc+DQo+ID4gPj4+Pg0KPiA+ID4+Pj4gVGhpcyBwYXRjaCBhZGRzIGFuZCBkb2N1bWVu dHMgYSBuZXcgS1ZNX0RFVl9WRklPX0RFVklDRSBncm91cA0KPiA+ID4+Pj4gYW5kIDIgZGV2aWNl IGF0dHJpYnV0ZXM6IEtWTV9ERVZfVkZJT19ERVZJQ0VfRk9SV0FSRF9JUlEsDQo+ID4gPj4+PiBL Vk1fREVWX1ZGSU9fREVWSUNFX1VORk9SV0FSRF9JUlEuIFRoZSBwdXJwb3NlIGlzIHRvIGJlIGFi bGUNCj4gPiA+Pj4+IHRvIHNldCBhIFZGSU8gZGV2aWNlIElSUSBhcyBmb3J3YXJkZWQgb3Igbm90 IGZvcndhcmRlZC4NCj4gPiA+Pj4+IHRoZSBjb21tYW5kIHRha2VzIGFzIGFyZ3VtZW50IGEgaGFu ZGxlIHRvIGEgbmV3IHN0cnVjdCBuYW1lZA0KPiA+ID4+Pj4ga3ZtX3ZmaW9fZGV2X2lycS4NCj4g PiA+Pj4gSXMgdGhlcmUgbm8gd2F5IHRvIGRvIHRoaXMgYXV0b21hdGljYWxseT8gIEFmdGVyIGFs bCwgdmZpbyBrbm93cyB0aGF0IGENCj4gPiA+Pj4gZGV2aWNlIGludGVycnVwdCBpcyBmb3J3YXJk ZWQgdG8gc29tZSBldmVudGZkLCBhbmQga3ZtIGtub3dzIHRoYXQgc29tZQ0KPiA+ID4+PiBldmVu dGZkIGlzIGZvcndhcmRlZCB0byBhIGd1ZXN0IGludGVycnVwdC4gIElmIHRoZXkgY29tcGFyZSBu b3Rlcw0KPiA+ID4+PiB0aHJvdWdoIGEgY2VudHJhbCByZWdpc3RyeSwgdGhleSBjYW4gZmlndXJl IG91dCB0aGF0IHRoZSBpbnRlcnJ1cHQgbmVlZHMNCj4gPiA+Pj4gdG8gYmUgZm9yd2FyZGVkLg0K PiA+ID4+IE9oLCBqdXN0IGxpa2UgRXJpYyBtZW50aW9uZWQgaW4gaGlzIHJlcGx5LCB0aGlzIGRl c2NyaXB0aW9uIGlzIG91dCBvZiBjb250ZXh0IG9mDQo+ID4gPj4gdGhpcyBzZXJpZXMsIEkgd2ls bCByZW1vdmUgdGhlbSBpbiB0aGUgbmV4dCB2ZXJzaW9uLg0KPiA+ID4NCj4gPiA+IEkgc3VzcGVj dCBBdmkncyBxdWVzdGlvbiB3YXMgbW9yZSBnZW5lcmFsLiAgV2hpbGUgZm9yd2FyZC91bmZvcndh cmQgaXMNCj4gPiA+IG91dCBvZiBjb250ZXh0IGZvciB0aGlzIHNlcmllcywgaXQncyB2ZXJ5IHNp bWlsYXIgaW4gbmF0dXJlIHRvDQo+ID4gPiBlbmFibGluZy9kaXNhYmxpbmcgcG9zdGVkIGludGVy cnVwdHMuICBTbyBJIHRoaW5rIHRoZSBxdWVzdGlvbiByZW1haW5zDQo+ID4gPiB3aGV0aGVyIHdl IHJlYWxseSBuZWVkIHVzZXJzcGFjZSB0byBwYXJ0aWNpcGF0ZSBpbiBjcmVhdGluZyB0aGlzDQo+ ID4gPiBzaG9ydGN1dCBvciBpZiBrdm0gYW5kIHZmaW8gY2FuIHNvbWUgaG93IG9yY2hlc3RyYXRl IGZpZ3VyaW5nIGl0IG91dA0KPiA+ID4gYXV0b21hdGljYWxseS4NCj4gPiA+DQo+ID4gPiBQZXJz b25hbGx5IEkgZG9uJ3Qga25vdyBob3cgd2UgY291bGQgZG8gaXQgYXV0b21hdGljYWxseS4gIFdl J3ZlIGFsd2F5cw0KPiA+ID4gcmVsaWVkIG9uIHVzZXJzcGFjZSB0byBpbmRlcGVuZGVudGx5IHNl dHVwIHZmaW8gYW5kIGt2bSBzdWNoIHRoYXQNCj4gPiA+IG5laXRoZXIgaGF2ZSBhbnkgaWRlYSB0 aGF0IHRoZSBvdGhlciBpcyB0aGVyZSBhbmQgdXBkYXRlIGVhY2ggc2lkZQ0KPiA+ID4gaW5kZXBl bmRlbnRseSB3aGVuIGFueXRoaW5nIGNoYW5nZXMuICBTbyBpdCBzZWVtcyBjb25zaXN0ZW50IHRv IGNvbnRpbnVlDQo+ID4gPiB0aGF0IGhlcmUuICBJdCBkb2Vzbid0IHNlZW0gbGlrZSB0aGVyZSdz IG11Y2ggdG8gZ2FpbiBwZXJmb3JtYW5jZS13aXNlDQo+ID4gPiBlaXRoZXIsIHVwZGF0ZXMgc2hv dWxkIGJlIGEgcmVsYXRpdmVseSByYXJlIGV2ZW50IEknZCBleHBlY3QuDQo+ID4gPg0KPiA+ID4g VGhlcmUncyByZWFsbHkgbm8gbWV0YWRhdGEgYXNzb2NpYXRlZCB3aXRoIGFuIGV2ZW50ZmQsIHNv ICJjb21wYXJpbmcNCj4gPiA+IG5vdGVzIiBhdXRvbWF0aWNhbGx5IG1pZ2h0IGltcGx5IHNvbWUg Y2VudHJhbCByZWdpc3RyYXRpb24gZW50aXR5LiAgVGhhdA0KPiA+ID4gaW1tZWRpYXRlbHkgc291 bmRzIGxpa2UgYSBtdWNoIG1vcmUgY29tcGxleCBzb2x1dGlvbiwgYnV0IG1heWJlIEF2aSBoYXMN Cj4gPiA+IHNvbWUgaWRlYXMgdG8gbWFuYWdlIGl0LiAgVGhhbmtzLA0KPiA+ID4NCj4gPg0KPiA+ IFRoZSBpZGVhIGlzIHRvIGhhdmUgYSBjZW50cmFsIHJlZ2lzdHJ5IG1haW50YWluZWQgYnkgYSBw b3N0ZWQgaW50ZXJydXB0cw0KPiA+IG1hbmFnZXIuICBCb3RoIHZmaW8gYW5kIGt2bSBwYXNzIHRo ZSBmaWxwIChhbG9uZyB3aXRoIGV4dHJhIGluZm9ybWF0aW9uKQ0KPiA+IHRvIHRoZSBwb3N0ZWQg aW50ZXJydXB0cyBtYW5hZ2VyLCB3aGljaCwgd2hlbiBpdCBkZXRlY3RzIGEgZmlscCBtYXRjaCwN Cj4gPiB0ZWxscyBlYWNoIG9mIHRoZW0gd2hhdCB0byBkby4NCj4gPg0KPiA+IFRoZSBhZHZhbnRh Z2VzIGFyZToNCj4gPiAtIG9sZCB1c2Vyc3BhY2UgZ2FpbnMgdGhlIG9wdGltaXphdGlvbiB3aXRo b3V0IGNoYW5nZQ0KPiA+IC0gYSB1c2Vyc3BhY2UgQVBJIGlzIG1vcmUgZXhwZW5zaXZlIHRvIG1h aW50YWluIHRoYW4gaW50ZXJuYWwga2VybmVsDQo+ID4gaW50ZXJmYWNlcyAoQ1ZFcywgZG9jdW1l bnRhdGlvbiwgbWFpbnRhaW5pbmcgYmFja3dhcmRzIGNvbXBhdGliaWxpdHkpDQo+ID4gLSBpZiB5 b3UgY2FuIGRvIGl0IHdpdGhvdXQgYSBuZXcgaW50ZXJmYWNlLCB0aGlzIGluZGljYXRlcyB0aGF0 IGFsbCB0aGUNCj4gPiBpbmZvcm1hdGlvbiBpbiB0aGUgbmV3IGludGVyZmFjZSBpcyByZWR1bmRh bnQuICBUaGF0IG1lYW5zIHlvdSBoYXZlIHRvDQo+ID4gY2hlY2sgaXQgZm9yIGNvbnNpc3RlbmN5 IHdpdGggdGhlIGV4aXN0aW5nIGluZm9ybWF0aW9uLCBzbyBpdCdzIGV4dHJhDQo+ID4gd29yayAo bGlrZWx5LCBpdCdzIGV4YWN0bHkgd2hhdCB0aGUgcG9zdGVkIGludGVycnVwdCBtYW5hZ2VyIHdv dWxkIGJlDQo+ID4gZG9pbmcgYW55d2F5KS4NCj4gDQo+IFllcCwgdGhvc2UgYWxsIHNvdW5kIGxp a2UgZ29vZCB0aGluZ3MgYW5kIEkgYmVsaWV2ZSB0aGF0J3Mgc2ltaWxhciBpbg0KPiBkZXNpZ24g dG8gdGhlIHdheSB3ZSBoYWQgb3JpZ2luYWxseSBkaXNjdXNzZWQgdGhpcyBpbnRlcmFjdGlvbiBh dA0KPiBMUEMvS1ZNIEZvcnVtIHNldmVyYWwgeWVhcnMgYWdvLiAgSSdkIGJlIGluIGZhdm9yIG9m IHRoYXQgYXBwcm9hY2guDQo+IFRoYW5rcywNCg0KVGhpcyBzZWVtcyBhIGxpdHRsZSBjb21wbGV4 IGNvbXBhcmVkIHRvIHRoZSBjdXJyZW50IHNvbHV0aW9uLCBzaW5jZSBJIGFtDQpub3QgcXVpdGUg ZmFtaWxpYXIgd2l0aCBWRklPLCBBbGV4LCBjYW4geW91IGhlbHAgb24gdGhpcyBpZiB3ZSBuZWVk IHRvIGRvIHRoaXMNCnRoYXQgd2F5LCBlc3BlY2lhbGx5IGZvciB0aGUgVkZJTyBwYXJ0Pw0KDQpU aGFua3MsDQpGZW5nDQoNCj4gDQo+IEFsZXgNCg0K