From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757276AbcASEoj (ORCPT ); Mon, 18 Jan 2016 23:44:39 -0500 Received: from mga09.intel.com ([134.134.136.24]:48987 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755873AbcASEog convert rfc822-to-8bit (ORCPT ); Mon, 18 Jan 2016 23:44:36 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,315,1449561600"; d="scan'208";a="896124214" From: "Wu, Feng" To: Paolo Bonzini , =?iso-8859-1?Q?Radim_Krcm=E1r?= CC: "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Wu, Feng" Subject: RE: [PATCH v2 1/2] KVM: x86: Use vector-hashing to deliver lowest-priority interrupts Thread-Topic: [PATCH v2 1/2] KVM: x86: Use vector-hashing to deliver lowest-priority interrupts Thread-Index: AQHRPaYWVNvWlqsXtkO3uwvyjy20qJ8AukZw///97wCAAYy/AA== Date: Tue, 19 Jan 2016 04:44:20 +0000 Message-ID: References: <1450229853-3886-1-git-send-email-feng.wu@intel.com> <1450229853-3886-2-git-send-email-feng.wu@intel.com> <20151223171932.GB7061@potion.redhat.com> <569CC162.6090207@redhat.com> In-Reply-To: <569CC162.6090207@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Paolo Bonzini [mailto:pbonzini@redhat.com] > Sent: Monday, January 18, 2016 6:42 PM > To: Wu, Feng ; Radim Krcmár > Cc: kvm@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 1/2] KVM: x86: Use vector-hashing to deliver lowest- > priority interrupts > > > > On 18/01/2016 06:19, Wu, Feng wrote: > > However, > > this will make the vector-hashing lowest-priority handling slightly different > > compare to round-robin, since RR checks "!dst[i]" before injecting the > > interrupts. What is your opinion about it? Thanks a lot! > > I think Radim's suggestion is fine. You can print an error (just once > per guest) to dmesg if the result of the hashing computation corresponds > to a disabled APIC. Good idea, is there already a convenient way to do this in KVM? Thanks, Feng > > Paolo