From: "Hadli, Manjunath" <manjunath.hadli@ti.com>
To: "'Sergei Shtylyov'" <sshtylyov@mvista.com>
Cc: LMML <linux-media@vger.kernel.org>,
dlos <davinci-linux-open-source@linux.davincidsp.com>
Subject: RE: [PATCH v3 04/13] davinci: vpif: fix setting of data width in config_vpif_params() function
Date: Thu, 28 Jun 2012 09:52:50 +0000 [thread overview]
Message-ID: <E99FAA59F8D8D34D8A118DD37F7C8F753E936B16@DBDE01.ent.ti.com> (raw)
In-Reply-To: <4FE99091.7070001@mvista.com>
Hi Sergei,
On Tue, Jun 26, 2012 at 16:06:01, Sergei Shtylyov wrote:
> Hello.
>
> On 25-06-2012 15:07, Manjunath Hadli wrote:
>
> > fix setting of data width in config_vpif_params() function,
> > which was wrongly set.
>
> > Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com>
> > Signed-off-by: Lad, Prabhakar<prabhakar.lad@ti.com>
> > ---
> > drivers/media/video/davinci/vpif.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
>
> > diff --git a/drivers/media/video/davinci/vpif.c b/drivers/media/video/davinci/vpif.c
> > index 774bcd3..08fb81f 100644
> > --- a/drivers/media/video/davinci/vpif.c
> > +++ b/drivers/media/video/davinci/vpif.c
> > @@ -346,7 +346,7 @@ static void config_vpif_params(struct vpif_params *vpifparams,
> >
> > value = regr(reg);
> > /* Set data width */
> > - value&= ((~(unsigned int)(0x3))<<
> > + value&= ~(((unsigned int)(0x3))<<
>
> Why not just 0x3u instead of (unsigned int)(0x3)?
>
Ok.
Thx,
--Manju
> WBR, Sergei
>
prev parent reply other threads:[~2012-06-28 9:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1340622455-10419-1-git-send-email-manjunath.hadli@ti.com>
[not found] ` <1340622455-10419-9-git-send-email-manjunath.hadli@ti.com>
2012-06-25 12:54 ` [PATCH v3 08/13] davinci: vpif: add support for clipping on output data Laurent Pinchart
2012-06-25 13:08 ` Hans Verkuil
2012-06-25 13:18 ` Laurent Pinchart
2012-06-25 13:23 ` Hans Verkuil
2012-06-28 9:50 ` Hadli, Manjunath
[not found] ` <1340622455-10419-10-git-send-email-manjunath.hadli@ti.com>
2012-06-25 12:56 ` [PATCH v3 09/13] davinci: vpif display: Add power management support Laurent Pinchart
2012-06-28 9:56 ` Hadli, Manjunath
[not found] ` <1340622455-10419-11-git-send-email-manjunath.hadli@ti.com>
2012-06-25 12:57 ` [PATCH v3 10/13] davinci: vpif capture:Add " Laurent Pinchart
2012-06-28 9:54 ` Hadli, Manjunath
[not found] ` <1340622455-10419-5-git-send-email-manjunath.hadli@ti.com>
2012-06-26 10:36 ` [PATCH v3 04/13] davinci: vpif: fix setting of data width in config_vpif_params() function Sergei Shtylyov
2012-06-28 9:52 ` Hadli, Manjunath [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E99FAA59F8D8D34D8A118DD37F7C8F753E936B16@DBDE01.ent.ti.com \
--to=manjunath.hadli@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-media@vger.kernel.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.