From: "Madhani, Himanshu" <Himanshu.Madhani@cavium.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v3 2/6] qla2xxx: Fix mailbox command timeout due to starvation
Date: Mon, 5 Dec 2016 18:37:16 +0000 [thread overview]
Message-ID: <E9A30DF7-B137-47DB-BAF9-0BE28B6CBB55@cavium.com> (raw)
In-Reply-To: <20161205160350.GB11206@infradead.org>
On 12/5/16, 8:03 AM, "Christoph Hellwig" <hch@infradead.org> wrote:
>On Fri, Dec 02, 2016 at 01:44:53PM -0800, Himanshu Madhani wrote:
>> From: Samy <samy@purestorage.com>
>>
>> This patch helps resolve some of the mailbox timeout issue discovered
>> during large SAN emulation testing where 1000+ initiators are trying
>> to log into target mode personality. Since current mailbox interface
>> handles submission and processing of commands in a sequential order,
>> command could timeout resulting in some initiator not being able to
>> log into target.
>
>How does the patch hange anything? You're still synchronously
>waiting for the command, it's just that the command processing
>is offloaded to a workqueue now.
The mailbox timeout was issue here where command submitted to mailbox could wait
for more than time allowed to wait_for_completion. We’ll see lot of mailbox timeout if
the number of initiators trying to log into target mode personality increases to few
thousands.
>
next prev parent reply other threads:[~2016-12-05 18:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 21:44 [PATCH v3 0/6] qla2xxx: Feture updates for driver Himanshu Madhani
2016-12-02 21:44 ` [PATCH v3 1/6] qla2xxx: Only allow operational MBX to proceed during RESET Himanshu Madhani
2016-12-05 16:01 ` Christoph Hellwig
2016-12-05 18:36 ` Madhani, Himanshu
2016-12-06 13:57 ` Christoph Hellwig
2016-12-02 21:44 ` [PATCH v3 2/6] qla2xxx: Fix mailbox command timeout due to starvation Himanshu Madhani
2016-12-05 16:03 ` Christoph Hellwig
2016-12-05 18:37 ` Madhani, Himanshu [this message]
2016-12-07 18:49 ` Christoph Hellwig
2016-12-02 21:44 ` [PATCH v3 3/6] qla2xxx: Utilize pci_alloc_irq_vectors/pci_free_irq_vectors calls Himanshu Madhani
2016-12-05 7:19 ` Hannes Reinecke
2016-12-05 12:54 ` Christoph Hellwig
2016-12-05 16:09 ` Christoph Hellwig
2016-12-05 12:55 ` Christoph Hellwig
2016-12-05 21:20 ` Madhani, Himanshu
2016-12-02 21:44 ` [PATCH v3 4/6] qla2xxx: Add multiple queue pair functionality Himanshu Madhani
2016-12-05 7:38 ` Hannes Reinecke
2016-12-05 12:59 ` Christoph Hellwig
2016-12-05 20:43 ` Madhani, Himanshu
2016-12-05 22:08 ` Madhani, Himanshu
2016-12-05 16:20 ` Christoph Hellwig
2016-12-05 22:41 ` Madhani, Himanshu
2016-12-02 21:44 ` [PATCH v3 5/6] qla2xxx: Add Block Multi Queue functionality Himanshu Madhani
2016-12-05 7:39 ` Hannes Reinecke
2016-12-02 21:44 ` [PATCH v3 6/6] qla2xxx: Fix Target mode handling with Multiqueue changes Himanshu Madhani
2016-12-05 7:42 ` Hannes Reinecke
2016-12-05 21:06 ` Madhani, Himanshu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E9A30DF7-B137-47DB-BAF9-0BE28B6CBB55@cavium.com \
--to=himanshu.madhani@cavium.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.