From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [PATCH 7/9] KVM: PPC: Emulate trap SRR1 flags properly Date: Sun, 10 Jan 2010 13:48:17 +0100 Message-ID: References: <1262915889-11526-1-git-send-email-agraf@suse.de> <1262915889-11526-8-git-send-email-agraf@suse.de> <1FB2DDB0-F72E-437C-BEC5-8E1AEE5FBCC7@suse.de> <465359C6-52BD-4227-BEAC-639CDC239964@suse.de> <4B49C959.8040900@redhat.com> Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT Cc: Hollis Blanchard , KVM General , kvm-ppc , Benjamin Herrenschmidt To: Avi Kivity Return-path: In-Reply-To: <4B49C959.8040900-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On 10.01.2010, at 13:34, Avi Kivity wrote: > On 01/08/2010 09:37 PM, Alexander Graf wrote: >> >>> Yes, but I'd rather minimize the behavioral changes as long as we can't test it. >>> >> Right. That's why the semantics of "flags" are Book3S specific right now and as such the comment is correct. >> >> The behavioral change we need to do later is to take the ESR setting into queue_program, but that should wait until after someone has a board to test things on again ;-). The reminder that we need to do this is hereby archived in the mails :). >> > > What's the conclusion here? Do we need a respin or is this good enough? >>From my point of view this is good. Hollis and I were just both agreeing that it would be nice to move BookE to a similar concept. That really isn't in the scope of this series though. Alex From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Date: Sun, 10 Jan 2010 12:48:17 +0000 Subject: Re: [PATCH 7/9] KVM: PPC: Emulate trap SRR1 flags properly Message-Id: List-Id: References: <1262915889-11526-1-git-send-email-agraf@suse.de> <1262915889-11526-8-git-send-email-agraf@suse.de> <1FB2DDB0-F72E-437C-BEC5-8E1AEE5FBCC7@suse.de> <465359C6-52BD-4227-BEAC-639CDC239964@suse.de> <4B49C959.8040900@redhat.com> In-Reply-To: <4B49C959.8040900-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Avi Kivity Cc: Hollis Blanchard , KVM General , kvm-ppc , Benjamin Herrenschmidt On 10.01.2010, at 13:34, Avi Kivity wrote: > On 01/08/2010 09:37 PM, Alexander Graf wrote: >> >>> Yes, but I'd rather minimize the behavioral changes as long as we can't test it. >>> >> Right. That's why the semantics of "flags" are Book3S specific right now and as such the comment is correct. >> >> The behavioral change we need to do later is to take the ESR setting into queue_program, but that should wait until after someone has a board to test things on again ;-). The reminder that we need to do this is hereby archived in the mails :). >> > > What's the conclusion here? Do we need a respin or is this good enough? >From my point of view this is good. Hollis and I were just both agreeing that it would be nice to move BookE to a similar concept. That really isn't in the scope of this series though. Alex