RE: [PATCHv3 0/3] OMAP UART: Adding support for omap-serial driver.

From: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
To: Olof Johansson <olof@lixom.net>,
	"G, Manjunath Kondaiah" <manjugk@ti.com>
Cc: Govindraj <govindraj.ti@gmail.com>, "g@lixom.net" <g@lixom.net>,
	Tony Lindgren <tony@atomide.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"Pandita, Vikram" <vikram.pandita@ti.com>,
	"Raja, Govindraj" <govindraj.raja@ti.com>
Subject: RE: [PATCHv3 0/3] OMAP UART: Adding support for omap-serial driver.
Date: Wed, 25 Nov 2009 12:05:45 +0530	[thread overview]
Message-ID: <EAF47CD23C76F840A9E7FCE10091EFAB02BBDC7CAD@dbde02.ent.ti.com> (raw)
In-Reply-To: <20091124172139.GA22967@lixom.net>

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of Olof Johansson
> Sent: Tuesday, November 24, 2009 10:52 PM
> To: G, Manjunath Kondaiah
> Cc: Govindraj; g@lixom.net; Tony Lindgren; linux-
> omap@vger.kernel.org; Pandita, Vikram; Raja, Govindraj
> Subject: Re: [PATCHv3 0/3] OMAP UART: Adding support for omap-serial
> driver.
> 
> On Tue, Nov 24, 2009 at 03:04:09PM +0530, G, Manjunath Kondaiah
> wrote:
> >
> >
> > > -----Original Message-----
> > > From: Olof Johansson [mailto:olof@lixom.net]
> > > Sent: Monday, November 23, 2009 10:36 PM
> > > To: Govindraj; g@lixom.net
> > > Cc: Tony Lindgren; linux-omap@vger.kernel.org; Pandita,
> > > Vikram; Raja, Govindraj; G, Manjunath Kondaiah
> > > Subject: Re: [PATCHv3 0/3] OMAP UART: Adding support for
> > > omap-serial driver.
> > >
> > > On Fri, Nov 20, 2009 at 03:21:26PM +0530, Govindraj wrote:
> > > > I have not seen any comments on this patch series yet.
> > > >
> > > > Tony,
> > > > Is there something I need to modify?
> > >
> > > Govindaj,
> > >
> > > I'm having problems with these patches on Zoom2 with debug
> > > board, since
> > > they don't seem to coexist very well together with 8250.
> Enabling both
> > > options will result in build errors.
> >
> > Why do we need to enable both 8250 and omap-serial for console.
> The console
> > UART can be either external UART or any one of the omap UART
> right?
> 
> You should allow both of them to be enabled at the same time, so the
> same
> kernel can for example be booted on a ZOOM2 with debug board
> attached
> (8250 on GPMC), or on a beagle/overo board.
> 
> Making them exclusive would be a step backwards.

More so, selecting both config option really shouldn't break the build. If one expect a build break because only one of the options can be enabled then clearly the dependency should be used so that user can select only one option at a time.

Regards,
Santosh