From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753528AbdHKRMw (ORCPT ); Fri, 11 Aug 2017 13:12:52 -0400 Received: from mail-pg0-f67.google.com ([74.125.83.67]:37955 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752959AbdHKRMs (ORCPT ); Fri, 11 Aug 2017 13:12:48 -0400 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH v6 4/7] mm: refactoring TLB gathering API From: Nadav Amit In-Reply-To: <20170811092334.rmeazkklvordrmrl@hirez.programming.kicks-ass.net> Date: Fri, 11 Aug 2017 10:12:45 -0700 Cc: "open list:MEMORY MANAGEMENT" , LKML , Andrew Morton , Minchan Kim , Ingo Molnar , Russell King , Tony Luck , Martin Schwidefsky , "David S. Miller" , Heiko Carstens , Yoshinori Sato , Jeff Dike , linux-arch@vger.kernel.org, Mel Gorman Message-Id: References: <20170802000818.4760-1-namit@vmware.com> <20170802000818.4760-5-namit@vmware.com> <20170811092334.rmeazkklvordrmrl@hirez.programming.kicks-ass.net> To: Peter Zijlstra X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7BHCu7n023513 Peter Zijlstra wrote: > On Tue, Aug 01, 2017 at 05:08:15PM -0700, Nadav Amit wrote: >> From: Minchan Kim >> >> This patch is a preparatory patch for solving race problems caused by >> TLB batch. For that, we will increase/decrease TLB flush pending count >> of mm_struct whenever tlb_[gather|finish]_mmu is called. >> >> Before making it simple, this patch separates architecture specific >> part and rename it to arch_tlb_[gather|finish]_mmu and generic part >> just calls it. > > I absolutely hate this. We should unify this stuff, not diverge it > further. Agreed, but I don’t see how this patch makes the situation any worse. I’ll review your other comments by tomorrow due to some personal constraints. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f69.google.com (mail-pg0-f69.google.com [74.125.83.69]) by kanga.kvack.org (Postfix) with ESMTP id D97906B02B4 for ; Fri, 11 Aug 2017 13:12:49 -0400 (EDT) Received: by mail-pg0-f69.google.com with SMTP id w187so43159352pgb.10 for ; Fri, 11 Aug 2017 10:12:49 -0700 (PDT) Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com. [2607:f8b0:400e:c05::243]) by mx.google.com with ESMTPS id q5si763154pfj.271.2017.08.11.10.12.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Aug 2017 10:12:48 -0700 (PDT) Received: by mail-pg0-x243.google.com with SMTP id l64so3560389pge.2 for ; Fri, 11 Aug 2017 10:12:48 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH v6 4/7] mm: refactoring TLB gathering API From: Nadav Amit In-Reply-To: <20170811092334.rmeazkklvordrmrl@hirez.programming.kicks-ass.net> Date: Fri, 11 Aug 2017 10:12:45 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20170802000818.4760-1-namit@vmware.com> <20170802000818.4760-5-namit@vmware.com> <20170811092334.rmeazkklvordrmrl@hirez.programming.kicks-ass.net> Sender: owner-linux-mm@kvack.org List-ID: To: Peter Zijlstra Cc: "open list:MEMORY MANAGEMENT" , LKML , Andrew Morton , Minchan Kim , Ingo Molnar , Russell King , Tony Luck , Martin Schwidefsky , "David S. Miller" , Heiko Carstens , Yoshinori Sato , Jeff Dike , linux-arch@vger.kernel.org, Mel Gorman Peter Zijlstra wrote: > On Tue, Aug 01, 2017 at 05:08:15PM -0700, Nadav Amit wrote: >> From: Minchan Kim >>=20 >> This patch is a preparatory patch for solving race problems caused by >> TLB batch. For that, we will increase/decrease TLB flush pending = count >> of mm_struct whenever tlb_[gather|finish]_mmu is called. >>=20 >> Before making it simple, this patch separates architecture specific >> part and rename it to arch_tlb_[gather|finish]_mmu and generic part >> just calls it. >=20 > I absolutely hate this. We should unify this stuff, not diverge it > further. Agreed, but I don=E2=80=99t see how this patch makes the situation any = worse. I=E2=80=99ll review your other comments by tomorrow due to some personal constraints. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org