All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars Schneider <larsxschneider@gmail.com>
To: Git List <git@vger.kernel.org>
Cc: Jeff King <peff@peff.net>
Subject: [RFC] Subtle differences in passing configs to git clone
Date: Tue, 21 Feb 2017 12:36:25 +0100	[thread overview]
Message-ID: <EC270E42-9431-446C-96F9-E1A0C3E45333@gmail.com> (raw)

Hi,

I stumbled across the following today:

(1) git -c foo.bar="foobar" clone <URL>

--> uses the config temporarily


(2) git clone -c foo.bar="foobar" <URL>

--> uses the config and writes it to .git/config


This was introduced in 84054f7 ("clone: accept config options on the 
command line") and it makes total sense. However, I think this subtitle
difference can easily confuse users.

I think we should tell the users that we've written to .git/config.
Maybe something like this:

git clone -c foo.bar="foobar" <URL>
Cloning into 'test'...
Writing foo.bar="foobar" to local config...
remote: Counting objects: 2152, done.
remote: Compressing objects: 100% (33/33), done.
remote: Total 2152 (delta 19), reused 0 (delta 0), pack-reused 2119
Receiving objects: 100% (2152/2152), 328.66 KiB | 217.00 KiB/s, done.
Resolving deltas: 100% (1289/1289), done.

What do you think?

Thanks,
Lars

             reply	other threads:[~2017-02-21 11:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-21 11:36 Lars Schneider [this message]
2017-02-21 17:47 ` [RFC] Subtle differences in passing configs to git clone Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EC270E42-9431-446C-96F9-E1A0C3E45333@gmail.com \
    --to=larsxschneider@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.